ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity
26,249 Commits 589 Branches 805 Tags
b9db91aa64cffaa62f2f46b8b37f930feaf0d80c
Commit Graph

26249 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Evan Hunt
b9db91aa64 fix duplicate include guard in dnsconf.h 
- IMHO we should consider removing dnsconf.c and deprecating the
  /etc/dns.conf file, though, as I don't think it's likely anyone
  is using it

(cherry picked from commit a08ba418ef)
 2018-04-22 12:57:58 -07:00
Ondřej Surý
2054c850d8 Merge branch '202-cppcheck-reporting-miscellaneous-issues-v9_11' into 'v9_11' 
Resolve "cppcheck reporting miscellaneous issues"

See merge request isc-projects/bind9!217
 2018-04-20 18:53:54 -04:00
Mark Andrews
cdce9f752c remove exit calls after FATAL_ERROR 
(cherry picked from commit f8d2a46daa)
 2018-04-20 18:47:39 -04:00
Mark Andrews
bd3ad6fb59 remove dead code 
(cherry picked from commit 686edad5c5)
 2018-04-20 18:47:39 -04:00
Mark Andrews
578714e8f1 use %u instead of %d for unsigned int arguments 
(cherry picked from commit 49f8e9571c)
 2018-04-20 18:47:39 -04:00
Ondřej Surý
ac810872c6 Merge branch '206-nslookup-accepts-any-bogus-option-interpret-it-as-vc-v9_11' into 'v9_11' 
Resolve "nslookup accepts any -bogus -option, interpret it as -vc"

See merge request isc-projects/bind9!215
 2018-04-20 18:20:46 -04:00
Mukund Sivaraman
4f35a81004 Remove bogus comparison 
(cherry picked from commit 89cf503880)
 2018-04-20 14:52:43 -07:00
Ondřej Surý
901363a3dd Merge branch '189-fix-tsig-dump-keyfile-name-generation-issues-v9_11' into 'v9_11' 
[v9_11] Fix TSIG dump keyfile name generation issues

See merge request isc-projects/bind9!192
 2018-04-12 03:07:16 -04:00
Ondřej Surý
cf5598156d Sync isc_file_template functions between unix and win32, so they are same 
(cherry picked from commit 8c99d104e3)
 2018-04-12 09:00:13 +02:00
Ondřej Surý
6f550b33bf Cherry-pick changes to isc_file_template and associated unit test from v9_12 to v9_11 
(cherry picked parts of commit 2dfb992349)
 2018-04-12 08:59:35 +02:00
Mukund Sivaraman
63331f010e Fix TSIG dump keyfile name buffer size issues 
(cherry picked from commit 44b84cb5a6)
 2018-04-11 14:38:10 +02:00
Ondřej Surý
d69d5b96c1 Define PATH_MAX on Windows as _MAX_PATH, so we can use it everywhere 
(cherry picked from commit 7467735258)
 2018-04-11 14:38:10 +02:00
Evan Hunt
ec32538c2e Merge branch '193-fix-variable-definitions-in-bin-tests-Makefile.in-v9_11' into 'v9_11' 
Fix variable definitions in bin/tests/Makefile.in

Closes #193

See merge request isc-projects/bind9!183
 2018-04-10 20:04:40 -07:00
Evan Hunt
2a6a2014b4 Alter distclean rule to prevent recursing into the same directory twice 
Commit f87e0c03ee removed the "system" directory from the TESTDIRS
variable in bin/tests/Makefile.in in an attempt to fix "make distclean"
which was broken since commit 0d784de16a.  However, this change
prevented any system tests from being run when "make test" is invoked.

We now put it back into both SUBDIRS and TESTDIRS, but with a modified
rule to check for the existence of a Makefile in each subdirectory before
trying to run make there. This prevents "make distclean" from trying to
run again in a directory where it's already been run.

(cherry picked from commit 93ee6b8a22)
 2018-04-10 20:04:40 -07:00
Michał Kępień
19db5fb1f3 Fail CI pipeline when "make test" does not run any system tests 
Apart from ensuring "make test" returns 0, also check whether any system
test output was generated as a result of running it.  This prevents the
CI job running system tests from succeeding unless it actually tests
something.

(cherry picked from commit 80ab2c0f22)
 2018-04-10 20:04:39 -07:00
Evan Hunt
f7090700c7 Merge branch '197-dnstap-sockaddr-v9_11' into 'v9_11' 
Resolve "dnstap: log actual local IPv6 address, not :: listening address"

Closes #197

See merge request isc-projects/bind9!188
 2018-04-10 17:32:27 -07:00
Evan Hunt
bd60a72551 CHANGES note 
(cherry picked from commit 330b26c9df)
 2018-04-10 17:32:27 -07:00
Tony Finch
b53dee6d8f dnstap: log actual local IPv6 address, not :: listening address 
(cherry picked from commit ccff953c25)
 2018-04-10 17:26:08 -07:00
Evan Hunt
920eb326a5 Merge branch '183-add-dns_fixedname_initname-v9_11' into 'v9_11' 
Add and use dns_fixedname_initname()

Closes #183

See merge request isc-projects/bind9!161
 2018-04-10 14:08:27 -07:00
Mukund Sivaraman
984182a3fc Add CHANGES entry: 
4921.   [cleanup]       Add dns_fixedname_initname() and refactor the caller
                        code to make usage of the new function, as a part of
                        refactoring dns_fixedname_*() macros were turned into
                        functions. [GL #183]

(cherry picked from commit d7faee2566)
(cherry picked from commit d7676d0fa8)
 2018-04-10 13:27:54 -07:00
Michał Kępień
ab88043e74 Do not access dns_fixedname_t fields directly 
Employ dns_fixedname_name() and dns_fixedname_initname() to no longer
directly access dns_fixedname_t fields.

(cherry picked from commit 39ddf9991f)
(cherry picked from commit 706f865a20)
 2018-04-10 13:27:48 -07:00
Michał Kępień
ecea678dac Use dns_fixedname_initname() where possible 
Replace dns_fixedname_init() calls followed by dns_fixedname_name()
calls with calls to dns_fixedname_initname() where it is possible
without affecting current behavior and/or performance.

This patch was mostly prepared using Coccinelle and the following
semantic patch:

    @@
    expression fixedname, name;
    @@
    -	dns_fixedname_init(&fixedname);
    	...
    -	name = dns_fixedname_name(&fixedname);
    +	name = dns_fixedname_initname(&fixedname);

The resulting set of changes was then manually reviewed to exclude false
positives and apply minor tweaks.

It is likely that more occurrences of this pattern can be refactored in
an identical way.  This commit only takes care of the low-hanging fruit.

(cherry picked from commit 4df4a8e731)
(cherry picked from commit 0041aeb751)
 2018-04-10 13:26:23 -07:00
Mukund Sivaraman
1dea0795d1 Add a dns_fixedname_initname() helper function 
This also turns the dns_fixedname macros into functions.

(cherry picked from commit 0d2a03c290)
(cherry picked from commit cee4fef7c5)
 2018-04-10 13:14:25 -07:00
Mark Andrews
1b4f1c26b2 Merge branch 'ssl-double-free-v9_11' into 'v9_11' 
Fix double free after keygen error in dnssec-keygen

Closes #109

See merge request isc-projects/bind9!70
 2018-04-06 14:24:36 +10:00
Ondřej Surý
9a4414b039 Add CHANGES entry 
(cherry picked from commit ef2b2a6c92)
 2018-04-06 14:24:27 +10:00
Ondřej Surý
c5d1fedca8 A couple of more cleanups after free in opensslrsa_generate() 
(cherry picked from commit d2b3188c61)
 2018-04-06 14:23:58 +10:00
Petr Mensik
8baf990392 Do not assign NULL conditionally in OpenSSL < 1.1, make it always explicit. 
(cherry picked from commit edaafacf36)
 2018-04-06 14:23:58 +10:00
Petr Mensik
f36e13b039 Fix double free on RSA_generate_key_ex failure 
(cherry picked from commit 01cc622e7b)
 2018-04-06 14:23:57 +10:00
Mark Andrews
0f67278a7e system should only be in SUBDIRS 
(cherry picked from commit 342e146fe3)
 2018-04-06 13:09:45 +10:00
Ondřej Surý
d653a8bf24 Merge branch 'pemensik/bind9-no-idn2-export-v9_11' into 'v9_11' 
Don't include -lidn2 in isc-config.sh output

See merge request isc-projects/bind9!180
 2018-04-05 06:13:44 -04:00
Ondřej Surý
31e5ceeea7 Print information about LIBIDN2 in Configuration summary (Closes: #163) 
(cherry picked from commit 8da5e5290f)
 2018-04-05 12:05:59 +02:00
Petr Menšík
3b2294c56a Remove -lidn2 from exported LIBS. Do not propagate it from isc-config.sh --libs isc. 
(cherry picked from commit 21c2871667)
 2018-04-05 12:05:57 +02:00
Ondřej Surý
ba1cb23fa3 Merge branch 'kchen/bind9-test-prereqs-v9_11' into 'v9_11' 
Add a Net::DNS prereq for couple of tests

See merge request isc-projects/bind9!177
 2018-04-04 17:09:29 -04:00
Kevin Chen
a39c613ccc Add a Net::DNS prereq for digdelv, fetchlimit, rpzrecurse, and zero 
tests to avoid failed tests when Net::DNS is not present.

(cherry picked from commit 8b1b809ab4)
 2018-04-04 23:02:58 +02:00
Stephen Morris
51fd67202b Merge branch '139-tests-for-idna2008-libidn2-merge-v9_11' into 'v9_11' 
Resolve "Tests for IDNA2008 (libidn2)" - Merge into 9.11

See merge request isc-projects/bind9!173
 2018-04-04 10:00:30 -04:00
Stephen Morris
79b7a5c89b Check libidn2 version before proceding with one of the tests. 
A known issue in libidn2 causes one of the tests of a fake A-label
to fail.  The problem should be corrected in version 2.0.5 of
libidn2.
 2018-04-04 09:48:52 -04:00
Ondřej Surý
05880829e0 Use C.UTF-8 if available, and en_US.UTF-8 is available, otherwise do nothing and let the test break 2018-04-04 09:48:51 -04:00
Stephen Morris
8319ece415 Set known locale prior to running tests. 2018-04-04 09:48:50 -04:00
Stephen Morris
dfb264f85c Fix check for the presence of IDNA. 2018-04-04 09:48:49 -04:00
Stephen Morris
777a37affd Added additional tests for invalid punycode strings. 2018-04-04 09:48:49 -04:00
Stephen Morris
e0b6c11840 Initial set of IDNA tests. 2018-04-04 09:48:47 -04:00
Michał Kępień
a71c9a12f9 Merge branch '188-remove-duplicate-named_g_conffile-init-v9_11' into 'v9_11' 
Remove redundant named_g_conffile initialization

Closes #188

See merge request isc-projects/bind9!166
 2018-04-04 12:34:21 +02:00
Ondřej Surý
61715b2120 Remove redundant ns_g_conffile initialization from bin/named/win32/os.c 
(cherry picked from commit c727f0797b)
 2018-04-04 12:34:07 +02:00
Ondřej Surý
535a4ae85c Merge branch '26-fix-normalization-for-non-IDN-v9_11' into 'v9_11' 
Don't use the IDN translated name if no conversion took a place

See merge request isc-projects/bind9!157
 2018-03-22 10:04:10 -04:00
Ondřej Surý
db7231e4ab Don't use the IDN traslated name if no conversion took a place 
(cherry picked from commit 08f66d8509)
 2018-03-22 13:54:49 +00:00
Mark Andrews
4dd54a688c Merge branch '167-coverity-dereferencing-a-null-pointer-in-lib-dns-tests-rbt_test-c-v9_11' into 'v9_11' 
Resolve "coverity: Dereferencing a null pointer in lib/dns/tests/rbt_test.c"

Closes #167

See merge request isc-projects/bind9!150
 2018-03-20 09:54:56 +11:00
Mukund Sivaraman
4445ee6491 Check return value of isc_mem_get() 
(cherry picked from commit de3a4af1bf)
 2018-03-20 09:54:55 +11:00
Mark Andrews
f56b63d9ac fix temporary file name to have subtest number 
(cherry picked from commit e12453f43c88bac722fb511b62f12303735b788c)
 2018-03-19 23:13:10 +11:00
Mark Andrews
79c85f5e60 Merge branch 'fixtypo-v9_11' into 'v9_11' 
fix typo

See merge request isc-projects/bind9!148
 2018-03-19 22:55:24 +11:00
Mark Andrews
c5d1d9d232 fix typo 
(cherry picked from commit 6e4b5f2345)
 2018-03-19 22:53:09 +11:00