Commit Graph
38565 Commits
Author SHA1 Message Date
Ondřej Surý b7797adc4e Add CHANGES note for [GL #4568]
(cherry picked from commit 299ab7623a3ae6e7442cccaab36b21e047c0d1b1)
2024-02-11 09:39:19 +01:00
Ondřej Surý 14e435b814 Add a system test for mixed-case data for the same owner
We were missing a test where a single owner name would have multiple
types with a different case.  The generated RRSIGs and NSEC records will
then have different case than the signed records and message parser have
to cope with that and treat everything as the same owner.
2024-02-11 09:39:19 +01:00
Ondřej Surý ec11aa2836 Fix case insensitive matching in isc_ht hash table implementation
The case insensitive matching in isc_ht was basically completely broken
as only the hashvalue computation was case insensitive, but the key
comparison was always case sensitive.

(cherry picked from commit 34ae6916f115fc291865857509433f95c2bc0871)
2024-02-11 09:39:19 +01:00
Tom Krizek 96473a5edb Merge branch 'tkrizek/adjust-shotgun-load' into 'bind-9.18'
[9.18] Reduce shotgun load during performance tests

See merge request isc-projects/bind9!8711
2024-02-08 17:03:22 +00:00
Tom Krizek 38c66b8bb0 Reduce shotgun load during performance tests
Make the performance test results more stable by lowering the load on
the resolver.
2024-02-08 16:29:21 +01:00
Tom Krizek 444f005e4c Merge branch '4560-pytest-junit-xml-compat-9.18' into 'bind-9.18'
[9.18] Support older junit XML format in test result processing

See merge request isc-projects/bind9!8709
2024-02-08 14:28:04 +00:00
Tom Krizek 2dd238dbd0 Add CHANGES note for [GL #4560]
(cherry picked from commit 06a977a699)
2024-02-08 14:58:47 +01:00
Tom Krizek 6af67e028e Support older junit XML format in test result processing
When running `make check` on a platform which has older (but still
supported) pytest, e.g. 3.4.2 on EL8, the junit to trs conversion would
fail because the junit format has different structure. Make the junit
XML processing more lenient to support both the older and newer junit
XML formats.

(cherry picked from commit bec3dd10b3)
2024-02-08 14:58:11 +01:00
Tom Krizek a0dfb59c14 Merge branch '4562-use-source-port-for-ditch-pl-9.18' into 'bind-9.18'
[9.18] Use a single local port for ditch.pl

See merge request isc-projects/bind9!8707
2024-02-08 13:40:50 +00:00
Tom Krizek 26356ea078 Use a single local port for ditch.pl
The ditch.pl script is used to generate burst traffic without waiting
for the responses. When running other tests in parallel, this can result
in a ephemeral port clash, since the ditch.pl process closes the socket
immediately. In rare occasions when the message ID also clashes with
other tests' queries, it might result in an UnexpectedSource error from
dnspython.

Use a dedicated port EXTRAPORT8 which is reserved for each test as a
source port for the burst traffic.

(cherry picked from commit 339fa5690a)
2024-02-08 13:43:02 +01:00
Ondřej Surý dc72d71a41 Merge branch 'ondrej/various-rbtdb-fixes-9.18' into 'bind-9.18'
[9.18] Fix missing RRSIG for CNAME with different slabheader order

See merge request isc-projects/bind9!8704
2024-02-08 09:03:53 +00:00
Ondřej Surý 29aa972314 Add CHANGES note for [GL !8675]
(cherry picked from commit 6e81717cff)
2024-02-08 08:48:09 +01:00
Ondřej Surý d43a955d0c Optimize cname_and_other_data to stop as earliest as possible
Stop the cname_and_other_data processing if we already know that the
result is true.  Also, we know that CNAME will be placed in the priority
headers, so we can stop looking for CNAME if we haven't found CNAME and
we are past the priority headers.

(cherry picked from commit 3f774c2a8a)
2024-02-08 08:48:09 +01:00
Ondřej Surý 6557abc8bc Optimize the slabheader placement for certain RRTypes
Mark the infrastructure RRTypes as "priority" types and place them at
the beginning of the rdataslab header data graph.  The non-priority
types either go right after the priority types (if any).

(cherry picked from commit 3ac482be7f)
2024-02-08 08:48:09 +01:00
Ondřej Surý d228dc63c1 Fix missing RRSIG for CNAME with different slabheader order
The cachedb was missing piece of code (already found in zonedb) that
would make lookups in the slabheaders to miss the RRSIGs for CNAME if
the order of CNAME and RRSIG(CNAME) was reversed in the node->data.

(cherry picked from commit 5070c7f5c7)
2024-02-08 08:37:24 +01:00
Mark Andrews 02d7e7bf47 Merge branch '4561-shutdown-test-doesn-t-log-everything-to-named-run-bind-9.18' into 'bind-9.18'
[9.18] Resolve "Shutdown test doesn't log everything to named.run"

See merge request isc-projects/bind9!8701
2024-02-07 01:39:23 +00:00
Tom KrizekandMark Andrews 1b6c96a8ed Re-enable rndc shutdown test
The issue preventing a proper rndc shutdown was recently fixed and
the test now passes.

(cherry picked from commit fb70c4d475)
2024-02-07 12:09:03 +11:00
Mark Andrews 84078b96c0 Capture the resolver's startup and shutdown logging
Also set the debugging to 99.

(cherry picked from commit 3651c58a6a)
2024-02-07 12:09:02 +11:00
Matthijs Mekking 06912673df Merge branch '4531-improve-parental-agents-definition-arm-v9_18' into 'bind-9.18'
[9.18] Improve parental-agents definition in ARM

See merge request isc-projects/bind9!8691
2024-02-02 16:50:50 +00:00
Matthijs Mekking 9f1395e48e Add CHANGES for #4531
Improve ARM parental-agents definition.

(cherry picked from commit ab9c62f4b9)
2024-02-02 17:22:48 +01:00
Matthijs Mekking 37e3c3d7fb Improve parental-agents definition in ARM
"A parental agent is the entity that is allowed to change a zone's
delegation information" is untrue, because it is possible to use some
hidden server or a validating resolver.

Also the new text makes it more clear that named sends DS queries to
these servers.

(cherry picked from commit 604f8e7797)
2024-02-02 17:22:32 +01:00
Arаm Sаrgsyаn e4996fd06a Merge branch 'aram/dns-getdb-flags-fix-9.18' into 'bind-9.18'
[9.18] Fix the DNS_GETDB_STALEFIRST flag

See merge request isc-projects/bind9!8690
2024-02-02 15:46:30 +00:00
Aram Sargsyan 4af93d3c22 Add a CHANGES note for [GL !8683]
(cherry picked from commit f329c1ebc9)
2024-02-02 15:07:30 +00:00
Aram Sargsyan cbc0357881 Improve the definition of the DNS_GETDB_* flags
Use the (1 << N) form for defining the flags, in order to avoid
errors like the one fixed in the previous commit.

Also convert the definitions to an enum, as done in some of our
recent refactoring work.

(cherry picked from commit 0d7c7777da)
2024-02-02 15:06:48 +00:00
Aram Sargsyan 2bcd6c2fd3 Fix the DNS_GETDB_STALEFIRST flag
The DNS_GETDB_STALEFIRST flag is defined as 0x0C, which is the
combination of the DNS_GETDB_PARTIAL (0x04) and the
DNS_GETDB_IGNOREACL (0x08) flags (0x04 | 0x08 == 0x0C) , which is
an obvious error.

All the flags should be power of two, so they don't interfere with
each other. Fix the DNS_GETDB_STALEFIRST flag by setting it to 0x10.

(cherry picked from commit be7d8fafe2)
2024-02-02 15:06:43 +00:00
Matthijs Mekking b9d1ab6df1 Merge branch '4553-return-value-for-checkds-shadows-v9_18' into 'bind-9.18'
Don't also skip keymgr run if checkds is skipped

See merge request isc-projects/bind9!8688
2024-02-01 14:29:33 +00:00
Matthijs Mekking b730a65975 Don't also skip keymgr run if checkds is skipped
Checking the DS at the parent only happens if dns_zone_getdnsseckeys()
returns success. However, if this function somehow fails, it can also
prevent the keymgr from running.

Before adding the check DS functionality, the keymgr should only run
if 'dns_dnssec_findmatchingkeys()' did not return an error (either
ISC_R_SUCCESS or ISC_R_NOTFOUND). After this change the correct
result code is used again.

(cherry picked from commit 07c2acf15d)
2024-02-01 13:32:56 +01:00
Matthijs Mekking 76d1ea8936 Merge branch '4551-dnssec-keygen-does-not-generate-tsig-keys-v9_18' into 'bind-9.18'
[9.18] dnssec-keygen man page still says it can do TSIG

See merge request isc-projects/bind9!8687
2024-02-01 11:36:21 +00:00
Matthijs Mekking f58bf29cad Put reference to RFC 2845 in tsig-keygen man page
(cherry picked from commit 8a8c573be6)
2024-02-01 12:03:42 +01:00
Matthijs Mekking b94bb41e59 dnssec-keygen man page still says it can do TSIG
Remove text in man page that says the program can also be used for
generate TSIG keys, this was removed in 9.13.0 but this text was still
not yet removed.

(cherry picked from commit aabb452953)
2024-02-01 12:03:36 +01:00
Michał Kępień 1a1b7d814e Merge branch 'michal/shift-CHANGES-entries-9.18' into 'bind-9.18'
[9.18] Shift CHANGES entries by two

See merge request isc-projects/bind9!8680
2024-01-31 10:22:22 +00:00
Michał Kępień 83e343a66d Shift CHANGES entries by two
Account for additional entries that will be included in February 2024
releases.

(cherry picked from commit 1b48c99392)
2024-01-31 11:21:04 +01:00
Michal Nowak b8ca87939e Merge branch 'mnowak/drop-freebsd-12-9.18' into 'bind-9.18'
[9.18] Drop FreeBSD 12

See merge request isc-projects/bind9!8672
2024-01-26 10:59:22 +00:00
Michal Nowak 983cebead1 Drop FreeBSD 12
Support for FreeBSD 12.4, the last FreeBSD 12.x release, ended on
December 31, 2023.

Link: https://www.freebsd.org/security/unsupported/

Move the --with-readline=editline ./configure option to FreeBSD 14.

(cherry picked from commit 98bfa22381)
2024-01-26 10:47:23 +01:00
Matthijs Mekking 98db8d9b4c Merge branch '4510-doc-key-lifetime-too-short-9.18' into 'bind-9.18'
[9.18] Fix ZSK lifetime minimum constraints documentation

See merge request isc-projects/bind9!8671
2024-01-25 14:09:09 +00:00
Matthijs Mekking 066b31667a Add CHANGES for #4510
(cherry picked from commit 7e903c52be)
2024-01-25 14:23:06 +01:00
Matthijs Mekking a64197c80f Fix ZSK lifetime minimum constraints documentation
The ARM failed to mention that the ZSK lifetime minimum also depends
on the signing delay.

(cherry picked from commit 53f0541db6)
2024-01-25 14:22:37 +01:00
Michal Nowak f132740869 Merge branch 'mnowak/pytest_rewrite_dialup-9.18' into 'bind-9.18'
[9.18] Rewrite dialup system test to pytest

See merge request isc-projects/bind9!8669
2024-01-24 13:45:55 +00:00
Michal Nowak 816d26eb0d Rewrite dialup system test to pytest
(cherry picked from commit bc4c29888b)
2024-01-24 13:48:10 +01:00
Michal Nowak 03155da31e Speed up test by lowering "heartbeat-interval" to 1
(cherry picked from commit 6c6580ea83)
2024-01-24 13:48:10 +01:00
Tom Krizek 5bc557c3bb Merge branch '4445-stop-leaking-queries-to-root-in-tests-9.18' into 'bind-9.18'
[9.18] Ensure no test queries leak to root server

See merge request isc-projects/bind9!8666
2024-01-19 15:13:02 +00:00
Tom Krizek e5403f39c1 Delete unused config file in dnssec system test
(cherry picked from commit f69df830c6)
2024-01-19 15:24:08 +01:00
Tom Krizek d9fd971231 Ensure tests use mock root server if configured
These tests have ns1 configured as a mock root server. Make sure it is
used in all config files of those tests, otherwise some queries could
leak to root nameservers.

(cherry picked from commit 088fcf9a61)
2024-01-19 15:24:07 +01:00
Tom Krizek 1997c36ce4 Blackhole queries to root servers in tests
Some tests don't have a mock root server configured, because they don't
need one. However, these tests might still leak queries to actual name
servers. Add a shared root hints file which can serve as a blackhole for
these queries.

(cherry picked from commit 8434e5abfc)
2024-01-19 15:24:07 +01:00
Tom Krizek b025e8dd2d Don't use root server in addzone test
(cherry picked from commit 7037eb96d4)
2024-01-19 15:24:05 +01:00
Michal Nowak da7e6a3286 Merge branch 'mnowak/rpz-drop-queryperf-support-9.18' into 'bind-9.18'
[9.18] Drop queryperf support from rpz system test

See merge request isc-projects/bind9!8665
2024-01-19 13:47:49 +00:00
Michal Nowak b1fc4f7dee Drop queryperf support from rpz system test
The queryperf support in the rpz system test is not utilized in the CI,
is likely not unused at all, and should be dropped.

(cherry picked from commit eaab796310)
2024-01-19 12:08:23 +01:00
Mark Andrews eeef5371b6 Merge branch '4541-values-of-ruletype-field-for-update-policy-statement-bind-9.18' into 'bind-9.18'
[9.18] Resolve "values of ruletype field for update-policy statement"

See merge request isc-projects/bind9!8664
2024-01-19 06:17:22 +00:00
Mark Andrews ce5fc0e466 Fix rule count, should be 18
(cherry picked from commit 81f9bcefaf)
2024-01-19 16:20:47 +11:00
Tom Krizek d629795f36 Merge branch 'tkrizek/split-up-dnsrps-test-cases' into 'bind-9.18'
[9.18] Split up the dnsrps and native variants of rpz system tests

See merge request isc-projects/bind9!8661
2024-01-18 17:26:57 +00:00