ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity
30,468 Commits 589 Branches 805 Tags
b1413ccf8db0adfed37282140da5d76868cd1509
Commit Graph

30468 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Michał Kępień
b1413ccf8d Merge branch '1430-fix-logging-long-named-command-lines' into 'master' 
Fix logging long named command lines

Closes #1430

See merge request isc-projects/bind9!2667
 2019-11-29 08:07:47 +00:00
Michał Kępień
009df30f3a Fix logging long named command lines 
The saved_command_line buffer in bin/named/main.c is 8192 bytes long.
The size of libisc's internal logging buffer (defined by the value of
the LOG_BUFFER_SIZE constant in lib/isc/log.c) is also 8192 bytes.
Since the buffer containing the ellipsis is passed as the last argument
to isc_log_write() and the buffer containing the potentially trimmed
named command line (saved_command_line) is passed as the second argument
in the same isc_log_write() call, it may happen that saved_command_line
will exhaust all available space in libisc's internal logging buffer, in
which case the ellipsis will be elided from the output.

Make saved_command_line 4096 bytes long as that value is arguably also
large enough for any reasonable use case and at the same time it ensures
ellipsis will always be printed for excessively long named command
lines.
 2019-11-29 09:06:41 +01:00
Michał Kępień
c6811ed052 Merge branch '1310-improve-portability-of-the-runtime-system-test' into 'master' 
Improve portability of the "runtime" system test

Closes #1310

See merge request isc-projects/bind9!2666
 2019-11-29 07:48:08 +00:00
Michał Kępień
58121f5f6d Improve portability of the "runtime" system test 
The "runtime" system test currently fails on Windows because it waits
for named to log a message indicating successful startup ("running"),
but that never happens since named on Windows fails to open the
configuration file as its path includes control characters.

Instead of putting control characters in directory names, put them in
the value of the -D command line switch passed to named, which is used
for identifying an instance of named in a process listing and whose
value is completely ignored by named, but still logged.

While a similar check using special characters appears to be working
fine on Windows for the time being, modify it in the same way to avoid
potential future problems on other platforms and make the test cleaner.
 2019-11-29 08:47:33 +01:00
Ondřej Surý
b6c96f05f3 Merge branch '1431-summary-sanitizer-grep-is-dangerous' into 'master' 
Resolve ""SUMMARY: .*Sanitizer" grep is dangerous"

Closes #1431

See merge request isc-projects/bind9!2669
 2019-11-29 07:02:30 +00:00
Mark Andrews
36ce99d8a4 replace grep -r with 'find -type f | xargs' 2019-11-29 10:58:28 +11:00
Ondřej Surý
1e7e0d2465 Merge branch 'ondrej/keep-sanitizer-tainted-system-tests-files' into 'master' 
Don't clean the system test temporary files if sanitizer reports were found inside

See merge request isc-projects/bind9!2657
 2019-11-28 21:39:28 +00:00
Ondřej Surý
7489e6e6f9 Don't clean the system test temporary files if sanitizer reports were found inside 2019-11-28 21:39:20 +00:00
Mark Andrews
ef2825f1b8 Merge branch '1417-threadsanitizer-data-race-rbtdb-c-1535-in-add32' into 'master' 
Resolve "ThreadSanitizer: data race rbtdb.c:1535 in add32"

Closes #1417

See merge request isc-projects/bind9!2655
 2019-11-28 20:10:33 +00:00
Mark Andrews
68693f8279 add CHANGES 2019-11-28 13:37:56 +01:00
Mark Andrews
637b2c4e51 rdataset_setownercase and rdataset_getownercase need to obtain a node lock 2019-11-28 13:37:56 +01:00
Ondřej Surý
6be1e9b565 Merge branch 'ondrej/stop-retrying-system-tests' into 'master' 
Stop retrying the system tests; we should fix the tests instead

See merge request isc-projects/bind9!2649
 2019-11-28 12:22:59 +00:00
Ondřej Surý
caa5cd947d Merge branch 'wpk/clock-realtime-fast' into 'master' 
Use clock_realtime_fast where available

See merge request isc-projects/bind9!2661
 2019-11-28 12:07:37 +00:00
Ondřej Surý
8ad67f8b9f Stop retrying the system tests; we should fix the tests instead 2019-11-28 13:06:38 +01:00
Witold Kręcicki
f01d739968 Use clock_realtime_fast where available 2019-11-28 12:36:55 +01:00
Ondřej Surý
1ca1dda266 Merge branch 'ondrej/use_ATOMIC_VAR_INIT_to_initialize_tid_base_in_isc_hp_API' into 'master' 
Use ATOMIC_VAR_INIT to initialize tid_v_base to 0

See merge request isc-projects/bind9!2660
 2019-11-28 11:30:37 +00:00
Ondřej Surý
4d021be52e Merge branch 'ondrej/lib_isc_counter_improvements' into 'master' 
Improve the atomics usage in isc_counter API

See merge request isc-projects/bind9!2658
 2019-11-28 11:07:42 +00:00
Ondřej Surý
c5b18d3dcb Use ATOMIC_VAR_INIT to initialize tid_v_base to 0 2019-11-28 12:06:10 +01:00
Ondřej Surý
9e8feec7d3 Improve the atomics usage in isc_counter API 2019-11-28 11:21:52 +01:00
Ondřej Surý
1a575d0f90 Merge branch '1401-intermittent-failures-in-the-catz-system-test' into 'master' 
Resolve "Intermittent failures in the catz system test"

Closes #1401

See merge request isc-projects/bind9!2633
 2019-11-28 08:37:29 +00:00
Ondřej Surý
51b05189f7 Use retry() and nextpart*() to simplify catz test 2019-11-28 08:02:33 +00:00
Witold Kręcicki
9b43e65c01 Fix timing issues in catz test 
Make the log checks more precise and use the retry() function for
repeating the checks.
 2019-11-28 08:02:33 +00:00
Evan Hunt
e25611457d Merge branch '1376-supported-platforms' into 'master' 
update "supported platforms" in release notes

Closes #1376

See merge request isc-projects/bind9!2654
 2019-11-28 05:42:28 +00:00
Evan Hunt
07f727ba01 update "supported platforms" in release notes 
also added more information about library dependencies in PLATFORMS.md,
and cleaned up the grammar.
 2019-11-27 13:06:13 -08:00
Ondřej Surý
f29dfb45d6 Merge branch 'mnowak/runtime-forward-port-softhsm2-setup' into 'master' 
Fix the UID switch test to work with PKCS#11 build

See merge request isc-projects/bind9!2652
 2019-11-27 17:19:10 +00:00
Michal Nowak
e00d650328 Fix the UID switch test to work with PKCS#11 build 
Forward port of 32fe9a0051fc76be4657fc2742e71d2be6193011 by Ondřej Surý.
 2019-11-27 17:19:10 +00:00
Ondřej Surý
e41b2999be Merge branch '1402-multiple-issues-in-the-runtime-system-test' into 'master' 
Resolve "Multiple issues in the runtime system test"

Closes #1402

See merge request isc-projects/bind9!2636
 2019-11-27 12:02:55 +00:00
Ondřej Surý
cd804158b4 Fix multiple issues in named setuid check 2019-11-27 11:50:29 +01:00
Evan Hunt
7a8269207d fixed a test failure, some other shell cleanup 2019-11-27 11:50:29 +01:00
Ondřej Surý
f020199925 Instead of sleeping for a fixed time, wait for named to log specific message in a loop 2019-11-27 11:50:29 +01:00
Ondřej Surý
d9b3909a21 Use pre-prepared long command line for better portability 2019-11-27 11:50:29 +01:00
Ondřej Surý
340b1d2b6b Make runtime/tests.sh shellcheck and set -e clean 
This mostly comprises of:

* using $(...) instead of `...`
* changing the directories in subshell and not ignoring `cd` return code
* handling every error gracefully instead of ignoring the return code
 2019-11-27 11:50:29 +01:00
Ondřej Surý
8f539a8886 Further improve the runtime tests to look for a specific instead of generic error 2019-11-27 11:50:29 +01:00
Ondřej Surý
c48d8e0d42 The PATH_MAX on macOS is 1024, we can't override conffile path to test for ellipsis 2019-11-27 11:50:29 +01:00
Ondřej Surý
b5a18ac439 Fix couple of no-op tests to actually test something (configuration files were missing) 2019-11-27 11:50:29 +01:00
Ondřej Surý
00114e07ef Skip the runtime ellipsis test 2019-11-27 11:50:29 +01:00
Ondřej Surý
ce86721bc3 runtime test: make the pidfiles match the names of configuration files 2019-11-27 11:50:29 +01:00
Ondřej Surý
e9fa7b831b runtime test: use helper function that kills named and waits for the finish 2019-11-27 11:50:29 +01:00
Mark Andrews
2c0710d5e6 Merge branch '1350-threadsanitizer-data-race-rbt-c-1312-in-dns_rbt_addnode' into 'master' 
Resolve "ThreadSanitizer: data race rbt.c:1312 in dns_rbt_addnode"

Closes #1350

See merge request isc-projects/bind9!2648
 2019-11-27 10:47:04 +00:00
Mark Andrews
8f6aaa7230 add comments 'tree_lock(write) must be held' 2019-11-27 09:58:15 +00:00
Mark Andrews
7cad3b2e91 rbtnode->nsec needs to be read while holding the tree lock 2019-11-27 09:58:15 +00:00
Evan Hunt
d744a6fc23 Merge branch '1399-recursive-limit-stat' into 'master' 
Resolve "recursive-client limit should have a stat counter"

Closes #1399

See merge request isc-projects/bind9!2629
 2019-11-26 19:15:18 +00:00
Evan Hunt
715afa9c57 add a stats counter for clients dropped due to recursive-clients limit 2019-11-26 17:55:06 +00:00
Ondřej Surý
0d7b3b9d73 Merge branch '1336-1404-netmgr-destroy-tsan-fixes' into 'master' 
Fix minor shutdown issues detected by TSAN

Closes #1404 and #1336

See merge request isc-projects/bind9!2639
 2019-11-26 17:32:31 +00:00
Witold Kręcicki
bf2cc19b04 - Access netmgr worker->finished under worker lock only 
- Join network worker thread to silence tsan
 2019-11-26 15:21:25 +01:00
Ondřej Surý
d0bc45be17 Merge branch '1354-threadsanitizer-data-race-message-c-3283-in-dns_message_sectiontotext' into 'master' 
Resolve "ThreadSanitizer: data race message.c:3283 in dns_message_sectiontotext"

Closes #1354

See merge request isc-projects/bind9!2578
 2019-11-26 13:00:01 +00:00
Mark Andrews
f269585de3 provide default yaml indent 2019-11-26 13:52:30 +01:00
Mark Andrews
9936462f31 dns_master_indent and dns_master_indentstr must not be global 
The indentation for dumping the master zone was driven by two
global variables dns_master_indent and dns_master_indentstr.  In
threaded mode, this becomes prone to data access races, so this commit
converts the global variables into a local per-context tuple that
consist of count and string.
 2019-11-26 13:52:18 +01:00
Ondřej Surý
caf18da7f6 Merge branch '1360-threadsanitizer-data-race-adb-c-2790-in-dns_adb_detach' into 'master' 
Resolve "ThreadSanitizer: data race adb.c:2790 in dns_adb_detach"

Closes #1360

See merge request isc-projects/bind9!2595
 2019-11-26 12:16:59 +00:00
Ondřej Surý
21eab267df Fix missing adb->{e,i}refcnt locking 2019-11-26 13:07:12 +01:00