Commit Graph
28780 Commits
Author SHA1 Message Date
Mark Andrews a3c2ad2ee5 Address use after free between view, resolver and nta.
Hold a weak reference to the view so that it can't go away while
nta is performing its lookups.  Cancel nta timers once all external
references to the view have gone to prevent them triggering new work.

(cherry picked from commit 0b2555e8cf)
2020-08-11 14:52:15 +10:00
Mark Andrews f58d2312e8 Merge branch '2046-check-isc_mutex_init' into 'v9_11'
Resolve "lib/isc/nothreads/include/isc/mutex.h:20:12: error: right-hand operand of comma expression has no effect"

See merge request isc-projects/bind9!3925
2020-08-11 01:46:46 +00:00
Mark Andrews 3783de2ed0 Don't use isc_thread_key_* when threads are disabled. 2020-08-11 01:19:02 +00:00
Mark Andrews f155ff75e4 Check isc_mutex_init() return values 2020-08-11 01:19:02 +00:00
Mark Andrews 10736891e8 Merge branch '2068-spnego-c-1430-2-error-len-may-be-used-uninitialized-in-this-function-on-arm-v9_11' into 'v9_11'
Silence 'may be used uninitialized'

See merge request isc-projects/bind9!3933
2020-08-08 08:01:02 +00:00
Mark Andrews 389c121597 Silence 'may be used uninitialized'
(cherry picked from commit 8a4dd25562)
2020-08-08 17:25:20 +10:00
Michał Kępień 348ba25ddd Merge branch 'michal/remove-arm64-jobs-from-gitlab-ci-v9_11' into 'v9_11'
[v9_11] Remove arm64 jobs from GitLab CI

See merge request isc-projects/bind9!3923
2020-08-05 10:12:06 +00:00
Michał Kępień e19584d431 Remove arm64 jobs from GitLab CI
The only arm64 runner we have at our disposal is suffering from
intermittent connectivity issues which make it unusable for extended
periods of time.  Remove arm64 jobs from GitLab CI until we manage to
set up an arm64 runner with more reliable connectivity.

(cherry picked from commit 49f245f7c0)
2020-08-05 12:10:02 +02:00
Michał Kępień 368bc9c57a Merge branch '2030-bind-arm-incorrectly-documents-the-processing-of-forwarders-still-has-the-pre-9-3-0-explanation-v9_11' into 'v9_11'
[v9_11] Update description of forwarding behavior in ARM

See merge request isc-projects/bind9!3918
2020-08-04 19:56:12 +00:00
Suzanne GoldlustandMichał Kępień 1dbefbcfbb Update description of forwarding behavior in ARM
(cherry picked from commit 30e126ad02)
2020-08-04 21:53:23 +02:00
Mark Andrews 7bcacc6b72 Merge branch 'marka-DNS_R_BADTSIG-map-to-FORMERR-v9_11' into 'v9_11'
Marka dns r badtsig map to formerr v9 11

See merge request isc-projects/bind9!3915
2020-08-04 13:32:06 +00:00
Mark Andrews d3281b80a9 Check rcode is FORMERR
(cherry picked from commit 88ff6b846c)
2020-08-04 23:08:49 +10:00
Mark Andrews 5770740587 Map DNS_R_BADTSIG to FORMERR
Now that the log message has been printed set the result code to
DNS_R_FORMERR.  We don't do this via dns_result_torcode() as we
don't want upstream errors to produce FORMERR if that processing
end with DNS_R_BADTSIG.

(cherry picked from commit 20488d6ad3)
2020-08-04 23:07:02 +10:00
Michal Nowak a51de5a7af Merge branch 'mnowak/various-system-test-fixes-v9_11' into 'v9_11'
[v9_11] Various system test fixes

See merge request isc-projects/bind9!3899
2020-07-31 07:28:00 +00:00
Michal Nowak fc1e50e73a Fix name of the test directory of stop.pl in masterformat test 2020-07-31 09:26:51 +02:00
Michal Nowak 9470e9e469 Ensure test fails if packet.pl does not work as expected 2020-07-31 09:26:51 +02:00
Michał Kępień d6262053ac Merge branch 'michal/only-run-system-tests-as-root-in-developer-mode-v9_11' into 'v9_11'
[v9_11] Only run system tests as root in developer mode

See merge request isc-projects/bind9!3902
2020-07-31 05:58:41 +00:00
Michał Kępień 41e2117866 Only run system tests as root in developer mode
Running system tests with root privileges is potentially dangerous.
Only allow it when explicitly requested (by building with
--enable-developer).

(cherry picked from commit 3ef106f69d)
2020-07-31 07:47:49 +02:00
Evan Hunt 64e1429fd7 Merge branch '1619-rpz-wildcard-passthru-ignored-v9_11' into 'v9_11'
Resolve "RPZ wildcard passthru ignored"

See merge request isc-projects/bind9!3874
2020-07-27 21:26:56 +00:00
Diego FronzaandEvan Hunt 4bc9ee1844 Update copyrights 2020-07-27 13:40:50 -07:00
Diego FronzaandEvan Hunt cba75d5854 Add CHANGES entry 2020-07-27 13:40:50 -07:00
Diego FronzaandEvan Hunt 40fd600f25 Add test for RPZ wildcard passthru ignored fix 2020-07-27 13:40:50 -07:00
Diego FronzaandEvan Hunt 33ae88f08d Fix rpz wildcard name matching
Whenever an exact match is found by dns_rbt_findnode(),
the highest level node in the chain will not be put into
chain->levels[] array, but instead the chain->end
pointer will be adjusted to point to that node.

Suppose we have the following entries in a rpz zone:
example.com     CNAME rpz-passthru.
*.example.com   CNAME rpz-passthru.

A query for www.example.com would result in the
following chain object returned by dns_rbt_findnode():

chain->level_count = 2
chain->level_matches = 2
chain->levels[0] = .
chain->levels[1] = example.com
chain->levels[2] = NULL
chain->end = www

Since exact matches only care for testing rpz set bits,
we need to test for rpz wild bits through iterating the nodechain, and
that includes testing the rpz wild bits in the highest level node found.

In the case of an exact match, chain->levels[chain->level_matches]
will be NULL, to address that we must use chain->end as the start point,
then iterate over the remaining levels in the chain.
2020-07-27 13:20:41 -07:00
Mark Andrews 51babc2cd3 Merge branch '2043-dns_rdata_hip_next-fails-to-return-isc_r_nomore-at-the-right-time-v9_11' into 'v9_11'
Resolve "dns_rdata_hip_next() fails to return ISC_R_NOMORE at the right time."

See merge request isc-projects/bind9!3886
2020-07-24 06:00:41 +00:00
Mark Andrews 97d7bb0438 Add CHANGES note
(cherry picked from commit bcd049f116)
2020-07-24 15:43:54 +10:00
Mark Andrews b424dfaada Check walking the hip rendezvous servers.
Also fixes extraneous white space at end of record when
there are no rendezvous servers.

(cherry picked from commit 78db46d746)
2020-07-24 15:43:54 +10:00
Mark Andrews 82ce055a3e Merge branch 'feature/master/unix-cleanup-v9_11' into 'v9_11'
Remove few lines in unix socket handling

See merge request isc-projects/bind9!3883
2020-07-24 04:44:23 +00:00
Petr MenšíkandMark Andrews 72e4be21f1 Remove few lines in unix socket handling
Reuse the same checks two times, make difference minimal.

(cherry picked from commit 72d81c4768)
2020-07-24 13:59:17 +10:00
Mark Andrews b56e821d17 Merge branch 'dstlib-failure-abort-v9_11' into 'v9_11'
Prevent crash on dst initialization failure

See merge request isc-projects/bind9!3879
2020-07-23 03:00:20 +00:00
Petr MenšíkandMark Andrews 35fbfaa498 Prevent crash on dst initialization failure
server might be created, but not yet fully initialized, when fatal
function is called. Check both server and task before attaching
exclusive task.

(cherry picked from commit c5e7152cf0)
2020-07-23 11:29:57 +10:00
Michal Nowak 0af3892dda Merge branch 'mnowak/try-harder-to-analyze-cores-v9_11' into 'v9_11'
[v9_11] Rationalize backtrace logging

See merge request isc-projects/bind9!3870
2020-07-20 17:10:29 +00:00
Michal Nowak 3745767b2b Check tests for core files regardless of test status
Failed test should be checked for core files et al. and have
backtrace generated.
2020-07-20 17:09:20 +02:00
Michal Nowak 9996811493 Rationalize backtrace logging
GDB backtrace generated via "thread apply all bt full" is too long for
standard output, lets save them to .txt file among other log files.
2020-07-20 17:00:13 +02:00
Evan Hunt c1dd887417 Merge branch 'each-doc-fixes-v9_11' into 'v9_11'
additional text edits to ARM

See merge request isc-projects/bind9!3863
2020-07-16 08:02:34 +00:00
Evan Hunt 86a3af1c78 Various text edits and fixes to the documentation 2020-07-16 01:00:39 -07:00
Michał Kępień eaff8860d7 Merge branch 'v9_11_21-release' into 'v9_11'
Merge 9.11.21 release branch

See merge request isc-projects/bind9!3862
2020-07-15 21:37:33 +00:00
Michał Kępień 80f7459de0 Set up release notes for BIND 9.11.22 2020-07-15 23:33:51 +02:00
Michał Kępień 48a7f7fca8 Bump BIND_BASELINE_VERSION for ABI checks 2020-07-15 23:33:51 +02:00
Tinderbox UserandMichał Kępień c9ab76c95f Merge branch 'prep-release' into v9_11_21-release 2020-07-15 23:24:26 +02:00
Tinderbox UserandMichał Kępień 8345bf5f0e prep 9.11.21 2020-07-15 23:24:25 +02:00
Michał Kępień 8defd0b731 Merge branch 'michal/prepare-release-notes-for-bind-9.11.21' into v9_11_21-release 2020-07-15 23:23:51 +02:00
Michał Kępień dfa63df21e Reorder release notes 2020-07-15 23:23:50 +02:00
Michał Kępień 6d0812b66f Tweak and reword release notes 2020-07-15 23:23:50 +02:00
Michał Kępień 46fc1b23e0 Tweak and reword recent CHANGES entries 2020-07-15 23:23:50 +02:00
Michał Kępień d2b8f9d75c Merge branch 'michal/use-image-key-in-qemu-based-ci-job-templates-v9_11' into 'v9_11'
[v9_11] Use "image" key in QEMU-based CI job templates

See merge request isc-projects/bind9!3857
2020-07-14 08:32:46 +00:00
Michał Kępień 80951ba0b1 Use "image" key in QEMU-based CI job templates
Our GitLab Runner Custom executor scripts now use the "image" key
instead of the job name for determining the QCOW2 image to use for a
given CI job.  Update .gitlab-ci.yml to reflect that change.

(cherry picked from commit 72201badf0)
2020-07-14 10:04:20 +02:00
Mark Andrews 6139af5007 Merge branch '1994-netscope-c-23-50-error-unused-parameter-addr-when-have_if_nametoindex-undefined-on-illumos-v9_11' into 'v9_11'
Mark 'addr' as unused if HAVE_IF_NAMETOINDEX is not defined

See merge request isc-projects/bind9!3851
2020-07-14 01:44:41 +00:00
Mark Andrews 4f25e8ee92 Mark 'addr' as unused if HAVE_IF_NAMETOINDEX is not defined
Also 'zone' should be initialised to zero.

(cherry picked from commit e7662c4c63)
2020-07-14 10:55:17 +10:00
Evan Hunt f34bab4145 Merge branch 'each-lmdb-lock-fix-v9_11' into 'v9_11'
ensure new_zone_lock is released after count_newzones()

See merge request isc-projects/bind9!3846
2020-07-13 20:18:49 +00:00
Evan Hunt 0f7f6201e3 make sure new_zone_lock is locked before unlocking it
it was possible for the count_newzones() function to try to
unlock view->new_zone_lock on return before locking it, which
caused a crash on shutdown.

(cherry picked from commit ed37c63e2b)
2020-07-13 12:32:51 -07:00