Commit Graph
27155 Commits
Author SHA1 Message Date
Michał Kępień 9fe44e48b2 Check TTL of stale answers
Make sure that stale answers returned when the serve-stale feature is
enabled have a TTL matching the value of the stale-answer-ttl setting.

(cherry picked from commit 893ab37ce7)
2018-10-31 14:08:43 +01:00
Mark Andrews 0cd60f604c Merge branch '649-resolver-test-failing-v9_12' into 'v9_12'
Resolve "resolver test failing"

See merge request isc-projects/bind9!960
2018-10-31 01:49:41 -04:00
Mark Andrews 86176a9153 use new packet for response; rename variable to request and response
(cherry picked from commit 280d0ca507)
2018-10-31 16:36:34 +11:00
Evan Hunt 806a781638 Merge branch 'silence-warning-v9_12' into 'v9_12'
silence warning from missing print.h

See merge request isc-projects/bind9!956
2018-10-30 11:09:57 -04:00
Evan Hunt d99a9db93a silence warning from missing print.h
(cherry picked from commit a0de6707c0)
2018-10-30 08:09:28 -07:00
Michał Kępień 4b26b9fe74 Merge branch '644-fix-isc_buffer_copyregion-for-auto-reallocated-buffers-v9_12' into 'v9_12'
[v9_12] Fix isc_buffer_copyregion() for auto-reallocated buffers

See merge request isc-projects/bind9!950
2018-10-30 08:52:27 -04:00
Michał Kępień 4447d5e317 Add CHANGES entry
5072.	[bug]		Add unit tests for isc_buffer_copyregion() and fix its
			behavior for auto-reallocated buffers. [GL #644]

(cherry picked from commit 07050fb49a)
2018-10-30 13:33:43 +01:00
Michał Kępień a21c1aacdf Fix isc_buffer_copyregion() for auto-reallocated buffers
While isc_buffer_copyregion() calls isc_buffer_reserve() to ensure the
target buffer will have enough available space to append the contents of
the source region to it, the variables used for subsequently checking
available space are not updated accordingly after that call.  This
prevents isc_buffer_copyregion() from working as expected for
auto-reallocated buffers: ISC_R_NOSPACE will be returned if enough space
is not already available in the target buffer before it is reallocated.
Fix by calling isc_buffer_used() and isc_buffer_availablelength()
directly instead of assigning their return values to local variables.

(cherry picked from commit e1f0aed034)
2018-10-30 13:33:42 +01:00
Michał Kępień 72caf33ffb Add unit tests for isc_buffer_copyregion()
Add some basic checks for isc_buffer_copyregion() to ensure it behaves
as expected for both fixed-size buffers and buffers which can be
automatically reallocated.  Adjust the list of headers included by
lib/isc/tests/buffer_test.c so that it matches what that test program
really uses.

(cherry picked from commit 15440d8027)
2018-10-30 13:33:42 +01:00
Ondřej Surý bc5d26a8fe Merge branch 'ondrej/cleanup-leftover-fatal-v9_12' into 'v9_12'
(v9_12) Remove double result check leftover

See merge request isc-projects/bind9!947
2018-10-30 08:08:30 -04:00
Ondřej Surý 6062d370b6 Remove double result check leftover
(cherry picked from commit 065ff16e40)
2018-10-30 12:59:21 +01:00
Witold Krecicki 2bbdf344e4 Merge branch 'wpk-fix-race-in-rpz-with-min-update-interval-0-v9_12' into 'v9_12'
Fix race in rpz with min update interval 0 v9 12

See merge request isc-projects/bind9!943
2018-10-30 02:59:45 -04:00
Witold Kręcicki c209bb1400 <stdlib.h> include in rpz.c for strtoul
(cherry picked from commit 8283cbabdc)
2018-10-30 06:51:47 +00:00
Michał KępieńandWitold Kręcicki 7258535655 Release all resources when shutting down an RPZ zone during an update
If an RPZ zone is to be freed during an update, canceling the
update_quantum() event is not enough because the resources released when
an update completes also need to be accounted for.  Failure to do this
results in a hang upon shutdown.  Fix by copying cleanup code from the
end of update_quantum() to rpz_detach().

(cherry picked from commit 139bc2c6ab)
2018-10-30 06:51:47 +00:00
Witold Kręcicki 384b3ef596 Fix a race in RPZ with min-update-interval set to 0
If another RPZ update is pending when processing the previous one nears
completion and min-update-interval is set to 0, isc_timer_reset() gets
called with 'interval' set to 0, which triggers an assertion failure.
To prevent such a scenario from causing a crash, queue the update event
directly instead of asking the timer thread to do it.

(cherry picked from commit faf2c7711a)
2018-10-30 06:51:40 +00:00
Mark Andrews b79602e923 Merge branch '631-dns_rdata_compare-for-nxt-performs-case-sensitive-name-comparison-v9_12' into 'v9_12'
Resolve "dns_rdata_compare() for NXT performs case sensitive name comparison"

See merge request isc-projects/bind9!941
2018-10-30 00:17:34 -04:00
Mark Andrews 22feff0b62 add CHANGES note
(cherry picked from commit 921bc89f59)
2018-10-30 15:09:48 +11:00
Mark Andrews 7074cbdacd compare_nxt compared records with identical next fields case insensitively
(cherry picked from commit cf83016682)
2018-10-30 15:09:45 +11:00
Mark Andrews a0ae166058 Merge branch 'move-declaration-of-pending' into 'v9_12'
move declaration of pending

See merge request isc-projects/bind9!939
2018-10-29 20:53:54 -04:00
Mark Andrews bc53e5e5d4 move declaration of pending 2018-10-30 11:51:38 +11:00
Mark Andrews 6768053022 Merge branch '638-record-types-with-empty-rdata-fields-were-not-being-handled-correctly-v9_12' into 'v9_12'
Resolve "Record types with empty rdata fields were not being handled correctly."

See merge request isc-projects/bind9!937
2018-10-29 20:25:19 -04:00
Mark Andrews d09955736a document eol
(cherry picked from commit 97a680e5ce)
2018-10-30 11:16:49 +11:00
Mark Andrews dce7bb3f82 Record types which support a empty rdata field were not handling the empty rdata field case.
(cherry picked from commit 2ff57d8a39)
2018-10-30 11:16:43 +11:00
Evan Hunt 17e574293d Merge branch '641-unquoted-rpz-v9_12' into 'v9_12'
allow unquoted response-policy zone names

See merge request isc-projects/bind9!934
2018-10-29 13:07:23 -04:00
Evan Hunt aa797579ef allow unquoted response-policy zone names
(cherry picked from commit 507230aa88)
2018-10-29 09:59:44 -07:00
Mark Andrews 8da6a31497 Merge branch '635-unchecked-return-in-query-c-v9_12' into 'v9_12'
Resolve "unchecked return in query.c"

See merge request isc-projects/bind9!930
2018-10-29 03:33:41 -04:00
Mark Andrews 18e7934959 always call RUNTIME_CHECK(result == ISC_R_SUCCESS); for dns_rdata_tostruct
(cherry picked from commit e11cfafff2)
2018-10-29 18:25:57 +11:00
Mark Andrews d8485aeee3 Merge branch '553-socket-c-2171-unexpected-error-v9_12' into 'v9_12'
Only set IPV6_USE_MIN_MTU on IPv6.

See merge request isc-projects/bind9!928
2018-10-29 02:39:18 -04:00
Mark Andrews 7ccca052c0 Only set IPV6_USE_MIN_MTU on IPv6.
(cherry picked from commit 561b780ba0)
2018-10-29 17:28:57 +11:00
Mark Andrews f6e5fe1848 Merge branch '624-lib-dns-dnstap_test-totext-does-not-work-well-with-softhsm-pkcs11-v9_12' into 'v9_12'
Resolve "lib/dns/dnstap_test:totext does not work well with SoftHSM PKCS11"

See merge request isc-projects/bind9!922
2018-10-29 01:42:43 -04:00
Mark Andrews c8276a29e6 Initalize TZ environment variable before calling dns_test_begin in dnstap_test.
(cherry picked from commit 1cf1254051)
2018-10-29 16:35:06 +11:00
Evan Hunt a907cb5918 Merge branch '626-implement-eid-and-nimloc-v9_12' into 'v9_12'
Resolve "Implement EID and NIMLOC"

See merge request isc-projects/bind9!913
2018-10-25 18:40:30 -04:00
Mark AndrewsandEvan Hunt b4b006a686 Add support for EID and NIMLOC
(cherry picked from commit fbab100426)
2018-10-25 15:30:58 -07:00
Evan Hunt bf523e9a4b Merge branch '627-check-that-gid-uid-and-uinfo-can-be-loaded-using-unknown-record-format-v9_12' into 'v9_12'
Resolve "Check that GID, UID and UINFO can be loaded using unknown record format."

See merge request isc-projects/bind9!911
2018-10-25 16:43:43 -04:00
Mark AndrewsandEvan Hunt f569c8ad26 GID, UID and UINFO could not be loaded using unknown record format.
(cherry picked from commit eb7ca65b78)
2018-10-25 13:34:49 -07:00
Michał Kępień 2ca5978086 Merge branch 'prep-release-v9_12_3' into 'v9_12'
prep 9.12.3

See merge request isc-projects/bind9!903
2018-10-25 08:30:40 -04:00
Tinderbox UserandMichał Kępień 04d53f446e prep 9.12.3 2018-10-25 14:00:59 +02:00
Michał Kępień 25f679757d Merge branch '427-list-zones-in-the-web-interface-v9_12' into 'v9_12'
[v9_12] Display a per-view list of zones in the web interface

See merge request isc-projects/bind9!899
2018-10-25 04:39:27 -04:00
Michał Kępień a873d93f14 Add CHANGES entry
5059.	[bug]		Display a per-view list of zones in the web interface.
			[GL #427]

(cherry picked from commit d9c4068cc3)
2018-10-25 10:25:25 +02:00
Michał Kępień 9dc1b43f3c Display a per-view list of zones in the web interface
The XSL stylesheet used by the web interface does not currently include
any element which would cause a list of zones configured in each view to
be displayed, making the "Zones" section of the web interface empty
unless some zone has been configured with "zone-statistics full;" and
queried.  Since this can be confusing, modify the XSL stylesheet so that
a list of zones configured in each view is displayed in the web
interface.

(cherry picked from commit aeda3f389e)
2018-10-25 10:21:26 +02:00
Michał Kępień 043445db8b Merge branch '582-fix-server-addresses-configuration-type-v9_12' into 'v9_12'
[v9_12] Fix the configuration type used by the "server-addresses" option

See merge request isc-projects/bind9!897
2018-10-25 03:22:25 -04:00
Michał Kępień 963a441921 Add CHANGES entry
5051.	[doc]		Documentation incorrectly stated that the
			"server-addresses" static-stub zone option accepts
			custom port numbers. [GL #582]

(cherry picked from commit 6b1c0a8e6f)
2018-10-25 09:00:46 +02:00
Michał Kępień 7b9a5ed7d5 Fix the configuration type used by the "server-addresses" option
Contrary to what the documentation states, the "server-addresses"
static-stub zone option does not accept custom port numbers.  Fix the
configuration type used by the "server-addresses" option to ensure
documentation matches source code.  Remove a check_zoneconf() test which
is unnecessary with this fix in place.

(cherry picked from commit b324576858)
2018-10-25 08:58:56 +02:00
Mark Andrews ae7e59c268 Merge branch '619-implement-atma-v9_12' into 'v9_12'
Resolve "Implement ATMA"

See merge request isc-projects/bind9!893
2018-10-24 23:18:30 -04:00
Mark Andrews f6515be8f6 Add support for ATMA
(cherry picked from commit f9ceddd8ca)
2018-10-25 14:08:42 +11:00
Mark Andrews efa5eeeb51 Merge branch '609-address-memory-leak-on-error-v9_12' into 'v9_12'
Resolve "Address memory leak on error"

See merge request isc-projects/bind9!891
2018-10-24 23:05:36 -04:00
Mark Andrews 7f07a0bb5d expand the pool then copy over the old entries so we that failures do not break the old pool; also don't leak the new pool on error
(cherry picked from commit afde30fe9b)
2018-10-25 13:20:03 +11:00
Mark Andrews 7796546fb2 Merge branch '610-address-memory-leak-on-error-v9_12' into 'v9_12'
Resolve "Address memory leak on error"

See merge request isc-projects/bind9!883
2018-10-23 21:05:47 -04:00
Mark Andrews e388288322 free key on error
(cherry picked from commit 607c2d7441)
2018-10-24 11:57:46 +11:00
Evan Hunt 1b276bdb14 Merge branch 'cleanup-changes-v9_12' into 'v9_12'
minor CHANGES edits

See merge request isc-projects/bind9!881
2018-10-23 16:32:17 -04:00