Commit Graph
28799 Commits
Author SHA1 Message Date
Mark Andrews 9d4feae236 X25: Check that record is all ASCII digits
(cherry picked from commit 7e49689746)
2020-08-14 00:27:24 +10:00
Mark Andrews 73602718f9 WKS: reject records with zero octets at the end of the bitmap
(cherry picked from commit 9d446142d8)
2020-08-14 00:26:42 +10:00
Mark Andrews 6cabbdae97 TLSA: fix fromwire length checks
(cherry picked from commit 3429c35f52)
2020-08-14 00:25:41 +10:00
Mark Andrews 0bc76daaf0 SIG: reject records with a zero length signature
(cherry picked from commit 9b93e5d684)
2020-08-14 00:25:08 +10:00
Mark Andrews f266bb2f61 NXT: fix fromwire bitmap checks
(cherry picked from commit 73dd849655)
2020-08-14 00:25:04 +10:00
Mark Andrews 712d3a50df NSEC3PARAM: check that saltlen is consistent with the rdata length
(cherry picked from commit 7dc8e720ff)
2020-08-14 00:24:25 +10:00
Mark Andrews 26f036cccc NSEC3: reject records with a zero length hash field
(cherry picked from commit 031ee9e279)
2020-08-14 00:23:47 +10:00
Mark Andrews 73341adc34 IPSECKEY: require non-zero length public keys
(cherry picked from commit d7f7014803)
2020-08-14 00:23:07 +10:00
Mark Andrews 1ca878708f CERT: reject records with a empty certificate field
(cherry picked from commit a238f37239)
2020-08-14 00:22:04 +10:00
Mark Andrews 74ee0ed911 Get rid of type 'RESERVED0'.
(cherry picked from commit 3c492b3ef1)
2020-08-14 00:21:23 +10:00
Mark Andrews af4dd77a44 base32_decode*() could incorrectly decode a input.
base32_decode_char() added a extra zero octet to the output
if the fifth character was a pad character.  The length
of octets to copy to the output was set to 3 instead of 2.

(cherry picked from commit 6c7e50c267)
2020-08-14 00:16:45 +10:00
Michal Nowak 6f1851dd56 Merge branch 'mnowak/fix-core-dumps-were-found-line-v9_11' into 'v9_11'
[v9_11] Make sure .txt files are not identified as crashed test

See merge request isc-projects/bind9!3948
2020-08-12 10:54:57 +00:00
Michal Nowak d79c96da01 Make sure .txt files are not identified as crashed test
Previously .txt files with full backtrace may be identified as a
crashed test:

    I:Core dumps were found for the following system tests:
    I:	 core.19948-backtrace.txt
    I:   shutdown

Now .txt files are removed from the list.

Change 'run.sh.in' to match the core matching pattern in
'testsummary.sh'.

(cherry picked from commit c2dcd95966)
(cherry picked from commit 01119ac4f9)
2020-08-12 09:56:16 +02:00
Mark Andrews e0e2083659 Merge branch '2045-readline-rltypedefs-h-35-22-error-this-function-declaration-is-not-a-prototype-on-netbsd-9-v9_11' into 'v9_11'
Resolve "readline/rltypedefs.h:35:22: error: this function declaration is not a prototype on NetBSD 9"

See merge request isc-projects/bind9!3946
2020-08-12 00:27:41 +00:00
Mark Andrews 1cc06636fc Ensure rl_message() gets prototype.
(cherry picked from commit fd126553d4)
2020-08-12 09:46:31 +10:00
Mark Andrews fd370a250d Stop deprecated functions being defined
(cherry picked from commit 1532a34658)
2020-08-12 09:42:34 +10:00
Michal Nowak a1efb14ac5 Merge branch 'mnowak/run-tarball-tests-in-schedule-v9_11' into 'v9_11'
[v9_11] Run unit and system tarball tests on schedules

See merge request isc-projects/bind9!3944
2020-08-11 15:06:56 +00:00
Michal Nowak 2b5007ef1a Run unit and system tarball tests on schedules
To prevent problems with unit and system tarball tests being revealed
during release process, run these tests on schedules.

(cherry picked from commit 439fe9bc3c)
2020-08-11 17:03:21 +02:00
Mark Andrews 35fd455956 Merge branch '2067-nta-related-crash-in-checkbogus-after-an-rndc-reload-v9_11' into 'v9_11'
Address use after free between view, resolver and nta.

See merge request isc-projects/bind9!3941
2020-08-11 05:29:20 +00:00
Mark Andrews a3c2ad2ee5 Address use after free between view, resolver and nta.
Hold a weak reference to the view so that it can't go away while
nta is performing its lookups.  Cancel nta timers once all external
references to the view have gone to prevent them triggering new work.

(cherry picked from commit 0b2555e8cf)
2020-08-11 14:52:15 +10:00
Mark Andrews f58d2312e8 Merge branch '2046-check-isc_mutex_init' into 'v9_11'
Resolve "lib/isc/nothreads/include/isc/mutex.h:20:12: error: right-hand operand of comma expression has no effect"

See merge request isc-projects/bind9!3925
2020-08-11 01:46:46 +00:00
Mark Andrews 3783de2ed0 Don't use isc_thread_key_* when threads are disabled. 2020-08-11 01:19:02 +00:00
Mark Andrews f155ff75e4 Check isc_mutex_init() return values 2020-08-11 01:19:02 +00:00
Mark Andrews 10736891e8 Merge branch '2068-spnego-c-1430-2-error-len-may-be-used-uninitialized-in-this-function-on-arm-v9_11' into 'v9_11'
Silence 'may be used uninitialized'

See merge request isc-projects/bind9!3933
2020-08-08 08:01:02 +00:00
Mark Andrews 389c121597 Silence 'may be used uninitialized'
(cherry picked from commit 8a4dd25562)
2020-08-08 17:25:20 +10:00
Michał Kępień 348ba25ddd Merge branch 'michal/remove-arm64-jobs-from-gitlab-ci-v9_11' into 'v9_11'
[v9_11] Remove arm64 jobs from GitLab CI

See merge request isc-projects/bind9!3923
2020-08-05 10:12:06 +00:00
Michał Kępień e19584d431 Remove arm64 jobs from GitLab CI
The only arm64 runner we have at our disposal is suffering from
intermittent connectivity issues which make it unusable for extended
periods of time.  Remove arm64 jobs from GitLab CI until we manage to
set up an arm64 runner with more reliable connectivity.

(cherry picked from commit 49f245f7c0)
2020-08-05 12:10:02 +02:00
Michał Kępień 368bc9c57a Merge branch '2030-bind-arm-incorrectly-documents-the-processing-of-forwarders-still-has-the-pre-9-3-0-explanation-v9_11' into 'v9_11'
[v9_11] Update description of forwarding behavior in ARM

See merge request isc-projects/bind9!3918
2020-08-04 19:56:12 +00:00
Suzanne GoldlustandMichał Kępień 1dbefbcfbb Update description of forwarding behavior in ARM
(cherry picked from commit 30e126ad02)
2020-08-04 21:53:23 +02:00
Mark Andrews 7bcacc6b72 Merge branch 'marka-DNS_R_BADTSIG-map-to-FORMERR-v9_11' into 'v9_11'
Marka dns r badtsig map to formerr v9 11

See merge request isc-projects/bind9!3915
2020-08-04 13:32:06 +00:00
Mark Andrews d3281b80a9 Check rcode is FORMERR
(cherry picked from commit 88ff6b846c)
2020-08-04 23:08:49 +10:00
Mark Andrews 5770740587 Map DNS_R_BADTSIG to FORMERR
Now that the log message has been printed set the result code to
DNS_R_FORMERR.  We don't do this via dns_result_torcode() as we
don't want upstream errors to produce FORMERR if that processing
end with DNS_R_BADTSIG.

(cherry picked from commit 20488d6ad3)
2020-08-04 23:07:02 +10:00
Michal Nowak a51de5a7af Merge branch 'mnowak/various-system-test-fixes-v9_11' into 'v9_11'
[v9_11] Various system test fixes

See merge request isc-projects/bind9!3899
2020-07-31 07:28:00 +00:00
Michal Nowak fc1e50e73a Fix name of the test directory of stop.pl in masterformat test 2020-07-31 09:26:51 +02:00
Michal Nowak 9470e9e469 Ensure test fails if packet.pl does not work as expected 2020-07-31 09:26:51 +02:00
Michał Kępień d6262053ac Merge branch 'michal/only-run-system-tests-as-root-in-developer-mode-v9_11' into 'v9_11'
[v9_11] Only run system tests as root in developer mode

See merge request isc-projects/bind9!3902
2020-07-31 05:58:41 +00:00
Michał Kępień 41e2117866 Only run system tests as root in developer mode
Running system tests with root privileges is potentially dangerous.
Only allow it when explicitly requested (by building with
--enable-developer).

(cherry picked from commit 3ef106f69d)
2020-07-31 07:47:49 +02:00
Evan Hunt 64e1429fd7 Merge branch '1619-rpz-wildcard-passthru-ignored-v9_11' into 'v9_11'
Resolve "RPZ wildcard passthru ignored"

See merge request isc-projects/bind9!3874
2020-07-27 21:26:56 +00:00
Diego FronzaandEvan Hunt 4bc9ee1844 Update copyrights 2020-07-27 13:40:50 -07:00
Diego FronzaandEvan Hunt cba75d5854 Add CHANGES entry 2020-07-27 13:40:50 -07:00
Diego FronzaandEvan Hunt 40fd600f25 Add test for RPZ wildcard passthru ignored fix 2020-07-27 13:40:50 -07:00
Diego FronzaandEvan Hunt 33ae88f08d Fix rpz wildcard name matching
Whenever an exact match is found by dns_rbt_findnode(),
the highest level node in the chain will not be put into
chain->levels[] array, but instead the chain->end
pointer will be adjusted to point to that node.

Suppose we have the following entries in a rpz zone:
example.com     CNAME rpz-passthru.
*.example.com   CNAME rpz-passthru.

A query for www.example.com would result in the
following chain object returned by dns_rbt_findnode():

chain->level_count = 2
chain->level_matches = 2
chain->levels[0] = .
chain->levels[1] = example.com
chain->levels[2] = NULL
chain->end = www

Since exact matches only care for testing rpz set bits,
we need to test for rpz wild bits through iterating the nodechain, and
that includes testing the rpz wild bits in the highest level node found.

In the case of an exact match, chain->levels[chain->level_matches]
will be NULL, to address that we must use chain->end as the start point,
then iterate over the remaining levels in the chain.
2020-07-27 13:20:41 -07:00
Mark Andrews 51babc2cd3 Merge branch '2043-dns_rdata_hip_next-fails-to-return-isc_r_nomore-at-the-right-time-v9_11' into 'v9_11'
Resolve "dns_rdata_hip_next() fails to return ISC_R_NOMORE at the right time."

See merge request isc-projects/bind9!3886
2020-07-24 06:00:41 +00:00
Mark Andrews 97d7bb0438 Add CHANGES note
(cherry picked from commit bcd049f116)
2020-07-24 15:43:54 +10:00
Mark Andrews b424dfaada Check walking the hip rendezvous servers.
Also fixes extraneous white space at end of record when
there are no rendezvous servers.

(cherry picked from commit 78db46d746)
2020-07-24 15:43:54 +10:00
Mark Andrews 82ce055a3e Merge branch 'feature/master/unix-cleanup-v9_11' into 'v9_11'
Remove few lines in unix socket handling

See merge request isc-projects/bind9!3883
2020-07-24 04:44:23 +00:00
Petr MenšíkandMark Andrews 72e4be21f1 Remove few lines in unix socket handling
Reuse the same checks two times, make difference minimal.

(cherry picked from commit 72d81c4768)
2020-07-24 13:59:17 +10:00
Mark Andrews b56e821d17 Merge branch 'dstlib-failure-abort-v9_11' into 'v9_11'
Prevent crash on dst initialization failure

See merge request isc-projects/bind9!3879
2020-07-23 03:00:20 +00:00
Petr MenšíkandMark Andrews 35fbfaa498 Prevent crash on dst initialization failure
server might be created, but not yet fully initialized, when fatal
function is called. Check both server and task before attaching
exclusive task.

(cherry picked from commit c5e7152cf0)
2020-07-23 11:29:57 +10:00
Michal Nowak 0af3892dda Merge branch 'mnowak/try-harder-to-analyze-cores-v9_11' into 'v9_11'
[v9_11] Rationalize backtrace logging

See merge request isc-projects/bind9!3870
2020-07-20 17:10:29 +00:00