Commit Graph
29062 Commits
Author SHA1 Message Date
Mark Andrews 8d2e091d46 Check that a zone in the process of being signed resolves
ans10 simulates a local anycast server which has both signed and
unsigned instances of a zone.  'A' queries get answered from the
signed instance.  Everything else gets answered from the unsigned
instance.  The resulting answer should be insecure.

(cherry picked from commit d7840f4b93)
2020-10-30 08:25:34 +11:00
Mark Andrews 4a4605fbef Handle DNS_R_NCACHENXRRSET in fetch_callback_{dnskey,validator}()
DNS_R_NCACHENXRRSET can be return when zones are in transition state
from being unsigned to signed and signed to unsigned.  The validation
should be resumed and should result in a insecure answer.

(cherry picked from commit 718e597def)
2020-10-30 08:25:03 +11:00
Michal Nowak 85fba4e36b Merge branch 'mnowak/add-freebsd12.2-v9_11' into 'v9_11'
[v9_11] Update to FreeBSD 12.2

See merge request isc-projects/bind9!4330
2020-10-29 15:42:58 +00:00
Michal Nowak 13a934df0b Update to FreeBSD 12.2
(cherry picked from commit 11ab0528d9)
2020-10-29 16:23:56 +01:00
Michal Nowak 70a241ce4c Merge branch 'mnowak/add-fedora-33-v9_11' into 'v9_11'
[v9_11] Add Fedora 33

See merge request isc-projects/bind9!4328
2020-10-29 15:19:20 +00:00
Michal Nowak 00326163ef Add Fedora 33
(cherry picked from commit 91e28d1fb4)
2020-10-29 15:56:35 +01:00
Evan Hunt c86849badd Merge branch 'each-rpz-test-typo-v9_11' into 'v9_11'
fix a typo in rpz test

See merge request isc-projects/bind9!4322
2020-10-29 06:04:27 +00:00
Evan Hunt c94559480e fix a typo in rpz test
"tcp-only" was not being tested correctly in the RPZ system test
because the option to the "digcmd" function that causes queries to
be sent via TCP was misspelled in one case, and was being interpreted
as a query name.

the "ckresult" function has also been changed to be case sensitive
for consistency with "digcmd".

(cherry picked from commit 78af071c11)
2020-10-28 22:42:37 -07:00
Michał Kępień 124b3e6f77 Merge branch '1764-address-make-depend-issues-v9_11' into 'v9_11'
address 'make depend' issues

See merge request isc-projects/bind9!4317
2020-10-28 10:02:09 +00:00
Mark AndrewsandMichał Kępień adc090a478 address 'make depend' issues
(cherry picked from commit 06fa0d7b4e)
2020-10-28 11:00:34 +01:00
Michal Nowak 37dc2e05df Merge branch 'mnowak/test-coverage-visualization-v9_11' into 'v9_11'
[v9_11] Enable Test Coverage Visualization for merge requests

See merge request isc-projects/bind9!4315
2020-10-27 15:56:05 +00:00
Michal Nowak 4cb5c3004d Enable Test Coverage Visualization for merge requests
This feature allows GitLab to visualize test coverage information in the
file diff view of merge requests.

This commit makes the gcov CI job depend on the following chain of jobs:

    gcc:buster:amd64 → unit:gcc:buster:amd64 → system:gcc:buster:amd64

The reason for running the last two jobs above sequentially rather than
in parallel is that both of them create *.gcda files (containing
coverage data) in the same locations.  While some way of merging these
files from different job artifact archives could probably be designed
with the help of additional tools, the simplest thing to do is not to
run unit test and system test jobs in parallel, carrying *.gcda files
over between jobs as gcov knows how to append coverage data to existing
*.gcda files.

Also note that test coverage will not be visualized if any of the jobs
in the above dependency chain fails (because the gcov job will not be
run).

(cherry picked from commit 2dabf328c4)
2020-10-27 16:15:39 +01:00
Michal Nowak d456de2b03 Merge branch 'mnowak/add-stress-test-to-CI-v9_11' into 'v9_11'
[v9_11] Add "stress" tests to GitLab CI

See merge request isc-projects/bind9!4308
2020-10-26 17:19:04 +00:00
Michal Nowak a0c0af642c Add "stress" tests to GitLab CI
Run "stress" tests for scheduled pipelines and pipelines created for
tags.  These tests were previously only performed manually (as part of
pre-release testing of each new BIND version).  Their purpose is to
detect memory leaks and potential performance issues.

As the run time of each "stress" test itself is set to 1 hour, set the
GitLab CI job timeout to 2 hours in order to account for the extra time
needed to set the test up and gather its results.

(cherry picked from commit 39305411e8)
(cherry picked from commit 06f721fdc5)
2020-10-26 18:18:27 +01:00
Michal Nowak d9ed1a85e4 Merge branch 'mnowak/openbsd-fix-gdb-in-system-test-v9_11' into 'v9_11'
[v9_11] Fix system test backtrace generation on OpenBSD

See merge request isc-projects/bind9!4305
2020-10-26 17:00:40 +00:00
Michal Nowak 523050f054 Fix system test backtrace generation on OpenBSD
On Linux core dump contains absolute path to crashed binary

    Core was generated by `/home/newman/isc/ws/bind9/bin/named/.libs/lt-named -D glue-ns1 -X named.lock -m'.

However, on OpenBSD there's only a basename

    Core was generated by `named'.

This commit adds support for the latter, retains the former.

(cherry picked from commit f0b13873a3)
(cherry picked from commit 659feff963)
2020-10-26 16:58:30 +01:00
Diego dos Santos Fronza c679913c04 Merge branch '1736-stub-zone-foiled-by-minimal-responses-v9_11' into 'v9_11'
Resolve "stub zone foiled by minimal-responses"

See merge request isc-projects/bind9!4284
2020-10-26 15:17:28 +00:00
Diego Fronza 29043867c7 Update copyrights 2020-10-26 10:45:27 -03:00
Diego Fronza 9772ebe8de Add CHANGES entry 2020-10-26 10:45:27 -03:00
Diego Fronza 4fef8acbfa Adjusted additional system test (NS, non-root zone)
After the updates from this branch, BIND now sends glue records for
NS queries even when configured with minimal-responses yes.
2020-10-26 10:45:27 -03:00
Diego Fronza acef95ce44 Added test for the proposed fix
This test is very simple, two nameserver instances are created:
    - ns4: master, with 'minimal-responses yes', authoritative
        for example. zone
    - ns5: slave, stub zone

The first thing verified is the transfer of zone data from master
to slave, which should be saved in ns5/example.db.

After that, a query is issued to ns5 asking for target.example.
TXT, a record present in the master database with the "test" string
as content.

If that query works, it means stub zone successfully request
nameserver addresses from master, ns4.example. A/AAAA

The presence of both A/AAAA records for ns4 is also verified in the
stub zone local file, ns5/example.db.
2020-10-26 10:45:27 -03:00
Diego Fronza 07564aedcf Always return address records in additional section for NS queries 2020-10-26 10:45:27 -03:00
Diego Fronza 6b97de3813 Fix transfer of glue records in stub zones if master has minimal-responses set
Stub zones don't make use of AXFR/IXFR for the transfering of zone
data, instead, a single query is issued to the master asking for
their nameserver records (NS).

That works fine unless master is configured with 'minimal-responses'
set to yes, in which case glue records are not provided by master
in the answer with nameservers authoritative for the zone, leaving
stub zones with incomplete databases.

This commit fix this problem in a simple way, when the answer with
the authoritative nameservers is received from master (stub_callback),
for each nameserver listed (save_nsrrset), a A and AAAA records for
the name is verified in the additional section, and if not present
a query is created to resolve the corresponsing missing glue.

A struct 'stub_cb_args' was added to keep relevant information for
performing a query, like TSIG key, udp size, dscp value, etc, this
information is borrowed from, and created within function 'ns_query',
where the resolving of nameserver from master starts.

A new field was added to the struct 'dns_stub', an atomic integer,
namely pending_requests, which is used to keep how many queries are
created when resolving nameserver addresses that were missing in
the glue.

When the value of pending_requests is zero we know we can release
resources, adjust zone timers, dump to zone file, etc.
2020-10-26 10:45:27 -03:00
Mark Andrews 7995626ae9 Merge branch '2226-tsan-error-in-dispatch-c-v9_11' into 'v9_11'
Hold qid->lock when calling deref_portentry() as

See merge request isc-projects/bind9!4303
2020-10-23 21:39:06 +00:00
Mark Andrews 86d9d04fd8 Hold qid->lock when calling deref_portentry() as
socket_search() need portentry to be unchanging.

    WARNING: ThreadSanitizer: data race
    Write of size 8 at 0x000000000001 by thread T1 (mutexes: write M1):
    #0 deref_portentry lib/dns/dispatch.c:630
    #1 deactivate_dispsocket lib/dns/dispatch.c:861
    #2 udp_recv lib/dns/dispatch.c:1105
    #3 udp_exrecv lib/dns/dispatch.c:1028
    #4 dispatch lib/isc/task.c:1152
    #5 run lib/isc/task.c:1344
    #6 <null> <null>

    Previous read of size 8 at 0x000000000001 by thread T2 (mutexes: write M1, write M2):
    #0 socket_search lib/dns/dispatch.c:661
    #1 get_dispsocket lib/dns/dispatch.c:744
    #2 dns_dispatch_addresponse lib/dns/dispatch.c:3120
    #3 resquery_send lib/dns/resolver.c:2467
    #4 fctx_query lib/dns/resolver.c:2217
    #5 fctx_try lib/dns/resolver.c:4245
    #6 fctx_timeout lib/dns/resolver.c:4570
    #7 dispatch lib/isc/task.c:1152
    #8 run lib/isc/task.c:1344
    #9 <null> <null>

(cherry picked from commit 5c253c416d)
2020-10-24 08:23:31 +11:00
Mark Andrews bc3436c340 Merge branch '2215-dns_zoneflag_noixfr-is-misnamed-v9_11' into 'v9_11'
DNS_ZONEFLAG_NOIXFR should be DNS_ZONEFLG_NOIXFR

See merge request isc-projects/bind9!4301
2020-10-23 13:59:48 +00:00
Mark Andrews a2d2161be4 DNS_ZONEFLAG_NOIXFR should be DNS_ZONEFLG_NOIXFR
(cherry picked from commit 3a044444bd)
2020-10-24 00:29:07 +11:00
Michał Kępień ee3414b60b Merge branch 'michal/test-a-disable-atomic-build-in-gitlab-ci' into 'v9_11'
Test a --disable-atomic build in GitLab CI

See merge request isc-projects/bind9!4280
2020-10-22 13:08:48 +00:00
Michał Kępień 97fbd08f81 Test a --disable-atomic build in GitLab CI
Extend GitLab CI with build and test jobs utilizing the --disable-atomic
configure switch as it is used to work around broken atomics support in
certain build toolchains.
2020-10-22 15:03:31 +02:00
Michal Nowak 6d5a8be495 Merge branch '2218-ensure-use-of-echo_i-where-possible-in-system-tests-v9_11' into 'v9_11'
[v9_11] Ensure use of "echo_i" where possible

See merge request isc-projects/bind9!4291
2020-10-22 10:50:33 +00:00
Michal Nowak e0af53ac0f Ensure use of "echo_i" where possible
In many instances 'echo "I:' construct was used where echo_i function
should have been.
2020-10-22 12:16:24 +02:00
Michał Kępień 9cd810f3aa Merge branch 'v9_11_24-release' into 'v9_11'
Merge 9.11.24 release branch

See merge request isc-projects/bind9!4289
2020-10-22 07:29:52 +00:00
Michał Kępień f8119c27f0 Set up release notes for BIND 9.11.25 2020-10-22 09:27:36 +02:00
Michał Kępień 72786104c1 Bump BIND_BASELINE_VERSION for ABI checks 2020-10-22 09:27:36 +02:00
Michał Kępień b7e02857a6 Bump BIND_BASELINE_VERSION for respdiff tests 2020-10-22 09:27:36 +02:00
Tinderbox UserandMichał Kępień 4fc5607d52 Merge branch 'prep-release' into v9_11_24-release 2020-10-22 09:22:48 +02:00
Michał Kępień 4e9a2a7793 Merge branch 'michal/prepare-release-notes-for-bind-9.11.24' into 'v9_11_24-release'
Prepare release notes for BIND 9.11.24

See merge request isc-private/bind9!218
2020-10-22 09:22:48 +02:00
Tinderbox UserandMichał Kępień 6995173371 prep 9.11.24 2020-10-22 09:22:48 +02:00
Michał Kępień d5524cf332 Prepare release notes for BIND 9.11.24 2020-10-22 09:22:48 +02:00
Michał Kępień eef36e64e8 Tweak and reword release notes 2020-10-22 09:22:48 +02:00
Michał Kępień 8218d23eb0 Tweak and reword recent CHANGES entries 2020-10-22 09:22:48 +02:00
Diego dos Santos Fronza e79c001356 Merge branch '2195-freebsd-dnstap-system-test-failure-v9_11' into 'v9_11'
Fix dnstap system test on FreeBSD

See merge request isc-projects/bind9!4276
2020-10-20 14:32:48 +00:00
Diego Fronza 0cd414a390 Fix dnstap system test on FreeBSD
This commit ensures that dnstap output files captured
by fstrm_capture are properly flushed before any attempt
on reading them with dnstap-read is done.

By reading fstrm-capture source code it was noticed that
signal SIGHUP is used to flush the capture file.
2020-10-20 10:39:48 -03:00
Mark Andrews f7a271d562 Merge branch 'marka-fix-not-enough-categories-v9_11' into 'v9_11'
Drop the expected minimum number of buckets to 4.

See merge request isc-projects/bind9!4266
2020-10-15 01:57:54 +00:00
Mark Andrews 140659c57a Drop the expected minimum number of buckets to 4.
The previous value of 5 produced too many false errors.

(cherry picked from commit 0abb49034e)
2020-10-15 12:32:26 +11:00
Mark Andrews 75ad006928 Merge branch 'marka-rrl-mdig-burst-v9_11' into 'v9_11'
Try to improve rrl timing

See merge request isc-projects/bind9!4264
2020-10-15 01:15:48 +00:00
Mark Andrews 96399960c1 Try to improve rrl timing
Add a +burst option to mdig so that we have a second to setup the
mdig calls then they run at the start of the next second.

RRL uses 'queries in a second' as a approximation to
'queries per second'. Getting the bursts of traffic to all happen in
the same second should prevent false negatives in the system test.

We now have a second to setup the traffic in.  Then the traffic should
be sent at the start of the next second.  If that still fails we
should move to +burst=<now+2> (further extend mdig) instead of the
implicit <now+1> as the trigger second.

(cherry picked from commit 92cdc7b6c7)
2020-10-15 11:47:08 +11:00
Mark Andrews a5ea10c162 Merge branch '2204-investigate-pipeline-system-test-failure-2' into 'v9_11'
Resolve "Investigate pipeline system test failure"

See merge request isc-projects/bind9!4248
2020-10-08 05:21:27 +00:00
Mark Andrews 56e8628e92 Restore the dns_message_reset() call before the dns_dispatch_getnext()
This was accidentally lost in the process of moving rmessage from fctx
to query.  Without this dns_message_setclass() will fail.
2020-10-08 13:10:31 +11:00
Mark Andrews 21bff35408 Merge branch 'mnowak/bring_--rpz-log-qtype-qclass_back' into 'v9_11'
Bring back --rpz-log-qtype-qclass feature-test option

See merge request isc-projects/bind9!4243
2020-10-07 20:10:10 +00:00