Commit Graph

34990 Commits

Author SHA1 Message Date
Tom Krizek
7324a7b5e4 Randomize algorithm selection for mkeys test
Use the ALGORITHM_SET option to use randomly selected default algorithm
in this test. Make sure the test works by using variables instead of
hard-coding values.

(cherry picked from commit f65f276f98)
2022-12-22 15:17:41 +01:00
Tom Krizek
aa5453f5e5 Set algorithms for system tests at runtime
Use the get_algorithms.py script to detect supported algorithms and
select random algorithms to use for the tests.

Make sure to load common.conf.sh after KEYGEN env var is exported.

(cherry picked from commit 69b608ee9f)
2022-12-22 15:17:41 +01:00
Tom Krizek
34497e2350 Script for random algorithm selection in system tests
Multiple algorithm sets can be defined in this script. These can be
selected via the ALGORITHM_SET environment variable. For compatibility
reasons, "stable" set contains the currently used algorithms, since our
system tests need some changes before being compatible with randomly
selected algorithms.

The script operation is similar to the get_ports.py - environment
variables are created and then printed out as `export NAME=VALUE`
commands, to be interpreted by shell. Once we support pytest runner for
system tests, this should be a fixture instead.

(cherry picked from commit 5f480c8485)
2022-12-22 15:17:41 +01:00
Tom Krizek
d45aa7581e Export env variables in system tests
Certain variables have to be exported in order for the system tests to
work. It makes little sense to export the variables in one place/script
while they're defined in another place.

Since it makes no harm, export all the variables to make the behaviour
more predictable and consistent. Previously, some variables were
exported as environment variables, while others were just shell
variables which could be used once the configuration was sourced from
another script. However, they wouldn't be exposed to spawned processes.

For simplicity sake (and for the upcoming effort to run system tests
with pytest), export all variables that are used. TESTS, PARALLEL_UNIX
and SUBDIRS variables are automake-specific, aren't used anywhere else
and thus not exported.

(cherry picked from commit 37d14c69c0)

conf.sh.win32 was modified in addition of the above mentioned commit.
2022-12-22 15:17:41 +01:00
Tom Krizek
4d74430259 Support testcrypto.sh usage without including conf.sh
The only variable really needed for the script to work is the path to
the $KEYGEN binary. Allow setting this via an environment variable to
avoid loading conf.sh (and causing a chicken-egg problem). Also make
testcrypto.sh executable to allow its use from conf.sh.

(cherry picked from commit bb1c6bbdc7)
2022-12-22 15:17:41 +01:00
Tom Krizek
28815949f8 Unify indentation level in testcrypto.sh
(cherry picked from commit 01b293b055)
2022-12-22 15:17:39 +01:00
Tom Krizek
09ec13097f Merge tag 'v9_16_36' into v9_16
BIND 9.16.36
2022-12-22 09:51:08 +01:00
Tom Krizek
6770e16d8c Merge branch 'tkrizek/system-tests-conventions-v9_16' into 'v9_16'
[9.16] Unify system tests naming conventions

See merge request isc-projects/bind9!7258
2022-12-21 13:37:34 +00:00
Tom Krizek
18e2298ed3 Update tests gitignore file
The .mypy_cache was added to the system test dir gitignore, since it
should be ignored.

(cherry picked from commit 4145068bfa)
2022-12-21 13:58:24 +01:00
Tom Krizek
1283d5263b Use common name convention for pytest files
It is better to use consistent file names to avoid issue with sorting
etc.

Using underscore in filenames as opposed to dash was chosen because it
seems more common in pytest/python to use underscore for filenames.

Also rename the bin/tests/system/timeouts/tests-tcp.py file to
bin/tests/system/timeouts/tests_tcp_timeouts.py to avoid pytest name
collision (there can't be two files named tests_tcp.py).

(cherry picked from commit f6409ee6ac)
2022-12-21 13:57:58 +01:00
Tom Krizek
3628613996 Merge branch 'tkrizek/danger-backports-v9_16' into 'v9_16'
Check backport workflow in danger CI [v9_16]

See merge request isc-projects/bind9!7246
2022-12-16 13:42:06 +00:00
Tom Krizek
9438051e86 danger: remove obsolete check for cherry pick msg
With proper backport commit detection, this check has been made
redundant.

(cherry picked from commit e8a5ebaee5)
2022-12-16 14:22:05 +01:00
Tom Krizek
90ce669183 danger: check backport commits for original commit IDs
A full backport must have all the commit from the original MR and the
original commit IDs must be referenced in the backport commit messages.

If the criteria above is not met, the MR should be marked as a partial
backport. In that case, any discrepencies are only logged as informative
messages rather than failures.

(cherry picked from commit c617f97784)
2022-12-16 14:22:05 +01:00
Tom Krizek
d03cbcf1f5 danger: check that original MR has been merged
When checking a backport MR, ensure that the original MR has been merged
already. This is vital for followup checks that verify commit IDs from
original commits are present in backport commit messages.

(cherry picked from commit 89530f1a1c)
2022-12-16 14:22:05 +01:00
Tom Krizek
dcfaba5398 danger: check backport links to the original MR
When doing archeology, it is much easier to find stuff if it's properly
linked. This check ensures that backport MR are linked to their original
MR via a "Backport of !XXXX" message.

The regular expression is fairly broad and has been tested to accept the
following variants of the message:
Backport of MR !XXXX
Backport of: !XXXX
backport of mr !XXXX
Backport of   !XXXX
Backport of https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/XXXX

(cherry picked from commit 12e0b05738)
2022-12-16 14:22:05 +01:00
Tom Krizek
ef9cecb79a danger: ensure target branch is in the MR title
Having the MR title clearly marked in its title can be very useful when
looking through older issues/MRs.

This check also ensures that the version from the version label matches
the proper version branch (i.e. v9.16 must be marked with [v9_16]).

(cherry picked from commit 14b027cf83)
2022-12-16 14:22:04 +01:00
Tom Krizek
5e31882596 danger: support partial backport label
Treat the Backport::Partial label as a backport as well.

(cherry picked from commit 1c0c1ba8b9)
2022-12-16 14:22:01 +01:00
Tony Finch
0195cb6de8 Merge branch '3740-rpz-reconfig-v9_16' into 'v9_16'
A couple of RPZ options were not reconfigured as expected

See merge request isc-projects/bind9!7239
2022-12-16 10:26:47 +00:00
Tony Finch
2d5160a9b9 A couple of RPZ options were not reconfigured as expected
[bug]	Changes to the RPZ response-policy min-update-interval
	and add-soa options now take effect as expected when
	named is reconfigured. [GL #3740]

(cherry picked from commit d8a3d328db)
2022-12-16 09:54:47 +00:00
Arаm Sаrgsyаn
59a76a7fa0 Merge branch '3742-catz-update-log-incorrect-soa-serial-representation-v9_16' into 'v9_16'
[v9_16] Fix an incorrect SOA serial representation in catz

See merge request isc-projects/bind9!7237
2022-12-15 14:48:22 +00:00
Aram Sargsyan
18932eb635 Add a CHANGES note for [GL #3742]
(cherry picked from commit ac7149aa88)
2022-12-15 13:50:36 +00:00
Aram Sargsyan
a634488a24 Fix logging a uint32_t SOA serial value in dns_catz_update_from_db()
The dns_catz_update_from_db() function prints serial number as a signed
number (with "%d" in the format string), but the `vers` variable's type
is 'uint32_t'. This breaks serials bigger than 2^31.

Use PRIu32 instead of "d" in the format string.

(cherry picked from commit 72b1760ea6)
2022-12-15 13:49:58 +00:00
Aram Sargsyan
d510221f7e Add big SOA serial logging check into the catz system test
Check that the SOA serial numbers printed when updating a catalog zone
is represented correctly for numbers bigger than 2^31.

(cherry picked from commit de232ab446)
2022-12-15 13:48:30 +00:00
Tony Finch
edc12bd49f Merge branch 'fanf-rsasha236-v9_16' into 'v9_16'
Fix a typo RSASHA236 -> RSASHA256

See merge request isc-projects/bind9!7225
2022-12-14 12:47:23 +00:00
Tony Finch
f3d96ab1f1 Fix a typo RSASHA236 -> RSASHA256
Use dns_secalg_format() to avoid error-prone repetition.

(cherry picked from commit c18a9a208d)
2022-12-14 12:46:56 +00:00
Tony Finch
1adcd723b4 Merge branch 'fanf-dnssec-algorithm-loglevel-v9_16' into 'v9_16'
List supported DNSSEC algorithms at log level NOTICE

See merge request isc-projects/bind9!7227
2022-12-14 12:32:01 +00:00
Tony Finch
bdfb06eb5a List supported DNSSEC algorithms at log level NOTICE
NOTICE matches the other startup messages. WARNING weirdly
suggests the list is a problem.

(cherry picked from commit 72f8d03cad)
2022-12-14 11:04:35 +00:00
Mark Andrews
929042cb51 Merge branch '3737-fix-initialisation-of-local-in-isdotlocal-in-dig-v9_16' into 'v9_16'
Resolve "fix initialisation of local. in isdotlocal in dig" [v9_16]

See merge request isc-projects/bind9!7222
2022-12-14 00:32:34 +00:00
Mark Andrews
7258465d28 Properly initialise local_ndata in isdotlocal in dig
Remove the trailing '\0' so that the length field of the dns_name_t
structure is correct.  The old data just happens to work with
dns_name_issubdomain but would fail with dns_name_equal.

(cherry picked from commit 8ce163bbc5)
2022-12-14 10:30:51 +11:00
Mark Andrews
219e808ff2 Merge branch '3728-v9_16-docs-can-t-retrieve-updated-man-pages' into 'v9_16'
Resolve "v9_16 docs can't retrieve updated man pages"

See merge request isc-projects/bind9!7200
2022-12-13 23:22:50 +00:00
Mark Andrews
a6f41f91e1 Make docs artifacts always available 2022-12-13 22:48:34 +00:00
Tom Krizek
b5a95414ae Merge branch 'tkrizek/set-up-version-and-release-notes-for-bind-9.16.37' into 'v9_16'
Set up version and release notes for bind 9.16.37

See merge request isc-projects/bind9!7220
2022-12-13 16:18:19 +00:00
Tom Krizek
2e76df3e09 Set up release notes for BIND 9.16.37 2022-12-13 17:05:05 +01:00
Tom Krizek
fd42890e76 Update BIND version to 9.16.37-dev 2022-12-13 17:04:02 +01:00
Tom Krizek
edc1615077 Merge branch 'prep-release' into v9_16_36-release v9.16.36 2022-12-12 15:43:23 +01:00
Tom Krizek
fe86c38f6c prep 9.16.36 2022-12-12 14:18:17 +01:00
Tom Krizek
ca10ac2811 Merge branch 'tkrizek/prepare-documentation-for-bind-9.16.36' into 'v9_16_36-release'
Prepare documentation for BIND 9.16.36

See merge request isc-private/bind9!489
2022-12-12 12:57:25 +00:00
Michał Kępień
d5a58400de Reorder release notes 2022-12-12 13:05:36 +01:00
Michał Kępień
c29739744e Tweak and reword release notes 2022-12-12 13:05:36 +01:00
Michał Kępień
2ff2ce0307 Prepare release notes for BIND 9.16.36 2022-12-12 13:05:36 +01:00
Ondřej Surý
9a61c53c71 Merge branch '3731-attach-keyfileio-to-zone-v9_16' into 'v9_16'
Implement proper reference counting for dns_keyfileio_t [v9.16]

See merge request isc-projects/bind9!7208
2022-12-09 14:53:51 +00:00
Ondřej Surý
075c7f7562 Implement proper reference counting for dns_keyfileio_t
Instead of relying on hash table search when using the keys, implement a
proper reference counting in dns_keyfileio_t objects, and attach/detach
the objects to the zone.

(cherry picked from commit 79115a0c3b)
2022-12-09 15:20:11 +01:00
Ondřej Surý
5b16afa378 Merge branch '3724-fix-doc-man-dig-v9_16' into 'v9_16'
Update the doc/man/dig.1in

See merge request isc-projects/bind9!7195
2022-12-08 10:20:07 +00:00
Ondřej Surý
a5fd5482af Update the doc/man/dig.1in
The MR !7187 forgot to update the precompiled doc/man/dig.1in.  Update
the file.
2022-12-08 10:20:03 +00:00
Ondřej Surý
d10351e4d1 Merge branch '3727-fix-off-by-one-reference-counting-in-zonemgr_keymgmt_delete-v9_16' into 'v9_16'
Release unused key file IO lock objects [v9.16]

See merge request isc-projects/bind9!7192
2022-12-08 09:57:28 +00:00
Ondřej Surý
1cb66e1b58 Add CHANGES and release note for [GL #3727]
(cherry picked from commit 56a997b0b5)
2022-12-08 10:32:59 +01:00
Ondřej Surý
98fca774b6 Release unused key file IO lock objects
Due to off-by-one error in zonemgr_keymgmt_delete, unused key file IO
lock objects were never freed and they were kept until the server
shutdown.  Adjust the returned value by -1 to accomodate the fact that
the atomic_fetch_*() functions return the value before the operation and
not current value after the operation.

(cherry picked from commit fb1acd6736)
2022-12-08 10:32:59 +01:00
Tom Krizek
f723643bdb Merge branch 'tkrizek/revert-3678-serve-stale-servfail-v9_16' into 'v9_16'
Revert "Merge branch '3678-serve-stale-servfailing-unexpectedly-v9_16' into 'v9_16'"

See merge request isc-projects/bind9!7185
2022-12-08 09:32:22 +00:00
Tom Krizek
da42fa7622 Revert "Merge branch '3678-serve-stale-servfailing-unexpectedly-v9_16' into 'v9_16'"
This reverts commit b2a4447af8, reversing
changes made to 8924f92956.

It also removes release note 6038, since the fix is reverted.
2022-12-08 10:23:40 +01:00
Mark Andrews
b386e272b7 Merge branch '3613-redo-dumping-expired-rdatasets-v9_16' into 'v9_16'
Resolve "TTL issue with resolver's cached and expired results for qtype ANY queries" [v9_16]

See merge request isc-projects/bind9!7189
2022-12-08 00:49:45 +00:00