Commit Graph

37121 Commits

Author SHA1 Message Date
Ondřej Surý
6ca03d1012 Add CHANGES and release notes for [GL #3637]
(cherry picked from commit d1f1db2f5a)
2022-12-16 18:38:02 +01:00
Ondřej Surý
2cb6001a2e Add comment why statistics/ns3 has misconfigure root.hints
To count pending queries in the statistics, we need the ns3 to be
misconfigured.  Document the fact in the statistics/ns3/root.hints.

(cherry picked from commit 32c2acf6fc)
2022-12-16 18:37:22 +01:00
Ondřej Surý
9e8c23be7e Revert the statistics system test change after we fixed the resolver
When the resolver was refactored, the statistics system test had to be
adjusted in c6b4d82557.  Unfortunately,
this change had to be done because of an error in the resolver
refactoring where timeout would not retry next server, but keep trying
the same server.  As we have now fixed this bug, revert the change to
the test back to the previous state.

(cherry picked from commit b679640950)
2022-12-16 18:37:22 +01:00
Ondřej Surý
095f634f48 Try next server on resolver timeout
Instead of resending to the same server on the (dispatch) timeout in the
resolver, try the next server.

(cherry picked from commit 5466a48fc9)
2022-12-16 18:37:22 +01:00
Tom Krizek
773517960f Merge branch 'tkrizek/danger-backports-v9_18' into 'v9_18'
Check backport workflow in danger CI [v9_18]

See merge request isc-projects/bind9!7245
2022-12-16 13:39:32 +00:00
Tom Krizek
a11bcfa8ba danger: remove obsolete check for cherry pick msg
With proper backport commit detection, this check has been made
redundant.

(cherry picked from commit e8a5ebaee5)
2022-12-16 14:21:10 +01:00
Tom Krizek
90b4441e3e danger: check backport commits for original commit IDs
A full backport must have all the commit from the original MR and the
original commit IDs must be referenced in the backport commit messages.

If the criteria above is not met, the MR should be marked as a partial
backport. In that case, any discrepencies are only logged as informative
messages rather than failures.

(cherry picked from commit c617f97784)
2022-12-16 14:21:10 +01:00
Tom Krizek
8ebfcb6b5a danger: check that original MR has been merged
When checking a backport MR, ensure that the original MR has been merged
already. This is vital for followup checks that verify commit IDs from
original commits are present in backport commit messages.

(cherry picked from commit 89530f1a1c)
2022-12-16 14:21:10 +01:00
Tom Krizek
eab1d81072 danger: check backport links to the original MR
When doing archeology, it is much easier to find stuff if it's properly
linked. This check ensures that backport MR are linked to their original
MR via a "Backport of !XXXX" message.

The regular expression is fairly broad and has been tested to accept the
following variants of the message:
Backport of MR !XXXX
Backport of: !XXXX
backport of mr !XXXX
Backport of   !XXXX
Backport of https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/XXXX

(cherry picked from commit 12e0b05738)
2022-12-16 14:21:10 +01:00
Tom Krizek
cb6ba18aaa danger: ensure target branch is in the MR title
Having the MR title clearly marked in its title can be very useful when
looking through older issues/MRs.

This check also ensures that the version from the version label matches
the proper version branch (i.e. v9.16 must be marked with [v9_16]).

(cherry picked from commit 14b027cf83)
2022-12-16 14:21:09 +01:00
Tom Krizek
2b5b016f1e danger: support partial backport label
Treat the Backport::Partial label as a backport as well.

(cherry picked from commit 1c0c1ba8b9)
2022-12-16 14:21:07 +01:00
Tony Finch
4d8f551195 Merge branch '3740-rpz-reconfig-v9_18' into 'v9_18'
A couple of RPZ options were not reconfigured as expected

See merge request isc-projects/bind9!7238
2022-12-16 10:15:31 +00:00
Tony Finch
08d0d24d3b A couple of RPZ options were not reconfigured as expected
[bug]	Changes to the RPZ response-policy min-update-interval
	and add-soa options now take effect as expected when
	named is reconfigured. [GL #3740]

(cherry picked from commit d8a3d328db)
2022-12-16 09:53:01 +00:00
Arаm Sаrgsyаn
61c2337a1e Merge branch '3742-catz-update-log-incorrect-soa-serial-representation-v9_18' into 'v9_18'
[v9_18] Fix an incorrect SOA serial representation in catz

See merge request isc-projects/bind9!7236
2022-12-15 14:27:33 +00:00
Aram Sargsyan
c833de15c0 Add a CHANGES note for [GL #3742]
(cherry picked from commit ac7149aa88)
2022-12-15 13:32:27 +00:00
Aram Sargsyan
19325a228c Fix logging a uint32_t SOA serial value in dns_catz_update_from_db()
The dns_catz_update_from_db() function prints serial number as a signed
number (with "%d" in the format string), but the `vers` variable's type
is 'uint32_t'. This breaks serials bigger than 2^31.

Use PRIu32 instead of "d" in the format string.

(cherry picked from commit 72b1760ea6)
2022-12-15 13:31:30 +00:00
Aram Sargsyan
eae5c06e57 Add big SOA serial logging check into the catz system test
Check that the SOA serial numbers printed when updating a catalog zone
is represented correctly for numbers bigger than 2^31.

(cherry picked from commit de232ab446)
2022-12-15 13:31:04 +00:00
Artem Boldariev
de9c75a532 Merge branch '3725-mutual-tls-session-resumption-fix-v9-18' into 'v9_18'
[Backport to 9.18] Fix TLS session resumption via IDs when Mutual TLS is used

See merge request isc-projects/bind9!7234
2022-12-14 17:45:52 +00:00
Artem Boldariev
055974a709 Update Release notes [GL #3725]
Mention that TLS session resumption for Mutual TLS has been fixed.

(cherry picked from commit 67d74e228f)
2022-12-14 18:32:32 +02:00
Artem Boldariev
3ce5d6c119 Update CHANGES [GL #3725]
Mention that TLS session resumption for Mutual TLS has been fixed.

(cherry picked from commit d8e04cdbc7)
2022-12-14 18:32:32 +02:00
Artem Boldariev
e903ce1f3e Extend the 'doth' system test with a Mutual TLS resumption check
This commit adds a simple check to the 'doth' system test which
ensures that session resumption when Mutual TLS is used works as
expected.

(cherry picked from commit d5d31c6ba1)
2022-12-14 18:32:32 +02:00
Artem Boldariev
5de938c6cf Fix TLS session resumption via IDs when Mutual TLS is used
This commit fixes TLS session resumption via session IDs when
client certificates are used. To do so it makes sure that session ID
contexts are set within server TLS contexts. See OpenSSL documentation
for 'SSL_CTX_set_session_id_context()', the "Warnings" section.

(cherry picked from commit 837fef78b1)
2022-12-14 18:32:26 +02:00
Tony Finch
605e714438 Merge branch 'fanf-rsasha236-v9_18' into 'v9_18'
Fix a typo RSASHA236 -> RSASHA256

See merge request isc-projects/bind9!7224
2022-12-14 15:52:06 +00:00
Tony Finch
d2fff95bc0 Fix a typo RSASHA236 -> RSASHA256
Use dns_secalg_format() to avoid error-prone repetition.

(cherry picked from commit c18a9a208d)
2022-12-14 15:51:33 +00:00
Tony Finch
1c68885cee Merge branch 'fanf-dnssec-algorithm-loglevel-v9_18' into 'v9_18'
List supported DNSSEC algorithms at log level NOTICE

See merge request isc-projects/bind9!7226
2022-12-14 12:30:14 +00:00
Tony Finch
24d02d0986 List supported DNSSEC algorithms at log level NOTICE
NOTICE matches the other startup messages. WARNING weirdly
suggests the list is a problem.

(cherry picked from commit 72f8d03cad)
2022-12-14 11:03:48 +00:00
Mark Andrews
18e407c712 Merge branch '3737-fix-initialisation-of-local-in-isdotlocal-in-dig-v9_18' into 'v9_18'
Resolve "fix initialisation of local. in isdotlocal in dig" [v9_18]

See merge request isc-projects/bind9!7221
2022-12-14 00:32:52 +00:00
Mark Andrews
d2aa4ad87c Properly initialise local_ndata in isdotlocal in dig
Remove the trailing '\0' so that the length field of the dns_name_t
structure is correct.  The old data just happens to work with
dns_name_issubdomain but would fail with dns_name_equal.

(cherry picked from commit 8ce163bbc5)
2022-12-14 10:30:16 +11:00
Tom Krizek
c5e392a226 Merge branch 'tkrizek/set-up-version-and-release-notes-for-bind-9.18.11' into 'v9_18'
Set up version and release notes for bind 9.18.11

See merge request isc-projects/bind9!7219
2022-12-13 16:18:12 +00:00
Tom Krizek
6b498a12cf Set up release notes for BIND 9.18.11 2022-12-13 17:02:14 +01:00
Tom Krizek
4d79f073b6 Update BIND version to 9.18.11-dev 2022-12-13 17:02:03 +01:00
Ondřej Surý
e0bf7ed171 Merge branch '3731-attach-keyfileio-to-zone-v9_18' into 'v9_18'
Implement proper reference counting for dns_keyfileio_t

See merge request isc-projects/bind9!7210
2022-12-09 14:56:01 +00:00
Ondřej Surý
9ebd775e29 Implement proper reference counting for dns_keyfileio_t
Instead of relying on hash table search when using the keys, implement a
proper reference counting in dns_keyfileio_t objects, and attach/detach
the objects to the zone.

(cherry picked from commit 79115a0c3b)
2022-12-09 15:17:02 +01:00
Ondřej Surý
8b8c761a90 Merge branch 'pspacek/configure-doh-help-fix-v9_18' into 'v9_18'
Fix configure --disable-doh help text [v9_18]

See merge request isc-projects/bind9!7194
2022-12-08 10:17:41 +00:00
Petr Špaček
0d78be7057 Fix configure --disable-doh help text
This is technically fixup for 2bb454182b.

Related: !4926
(cherry picked from commit 5ec272007d)
2022-12-08 10:17:32 +00:00
Ondřej Surý
c51cb3b390 Merge branch '3727-fix-off-by-one-reference-counting-in-zonemgr_keymgmt_delete-v9_18' into 'v9_18'
Release unused key file IO lock objects [v9.18]

See merge request isc-projects/bind9!7193
2022-12-08 10:17:15 +00:00
Ondřej Surý
f79a9c856c Add CHANGES and release note for [GL #3727]
(cherry picked from commit 56a997b0b5)
2022-12-08 10:56:31 +01:00
Ondřej Surý
85f5071a6d Release unused key file IO lock objects
Due to off-by-one error in zonemgr_keymgmt_delete, unused key file IO
lock objects were never freed and they were kept until the server
shutdown.  Adjust the returned value by -1 to accomodate the fact that
the atomic_fetch_*() functions return the value before the operation and
not current value after the operation.

(cherry picked from commit fb1acd6736)
2022-12-08 10:56:31 +01:00
Tom Krizek
b5d53e75b7 Merge branch 'tkrizek/revert-3678-serve-stale-servfail-v9_18' into 'v9_18'
Revert "Merge branch '3678-serve-stale-servfailing-unexpectedly-v9_18' into 'v9_18'"

See merge request isc-projects/bind9!7184
2022-12-08 09:31:50 +00:00
Tom Krizek
f4d0b2dca9 Revert "Merge branch '3678-serve-stale-servfailing-unexpectedly-v9_18' into 'v9_18'"
This reverts commit 81b6f17e7c, reversing
changes made to ea47a9c100.

It also removes release note 6038, since the fix is reverted.
2022-12-08 10:22:33 +01:00
Mark Andrews
aa7870cd2e Merge branch '3613-redo-dumping-expired-rdatasets-v9_18' into 'v9_18'
Resolve "TTL issue with resolver's cached and expired results for qtype ANY queries" [v9_18]

See merge request isc-projects/bind9!7188
2022-12-08 01:03:23 +00:00
Mark Andrews
2ddf710e40 Add CHANGES note for [GL #3613]
(cherry picked from commit 485e968087)
2022-12-07 23:59:36 +00:00
Mark Andrews
d218c7f2f3 Remove different zero TTL handling for rdataset iterator
Zero TTL handling does not need to be different for 'rdatasetiter_first'
and 'rdatasetiter_next' and it interacts badly with 'bind_rdatadataset'
which makes different determinations.

(cherry picked from commit 1a39328feb)
2022-12-07 23:59:36 +00:00
Mark Andrews
47239b45e6 Add dns_db_allrdatasets options
'DNS_DB_STALEOK' returns stale rdatasets as well as current rdatasets.

'DNS_DB_EXPIREDOK' returns expired rdatasets as well as current
rdatasets. This option is currently only set when DNS_DB_STALEOK is
also set.

(cherry picked from commit 85048ddeee)
2022-12-07 23:59:36 +00:00
Mark Andrews
6f998bbe51 Extend dns_db_allrdatasets to control interation results
Add an options parameter to control what rdatasets are returned when
iteratating over the node.  Specific modes will be added later.

(cherry picked from commit 7695c36a5d)
2022-12-07 23:59:36 +00:00
Mark Andrews
434b53281b Properly select active rdatasets when iterating across node
Active rdatasets where not being properly selected in rdatasetiter_first
and rdatasetiter_next.

(cherry picked from commit 3bdab2d111)
2022-12-07 23:59:36 +00:00
Mark Andrews
52a9db2180 Check TTLs of mixed TTL ANY response with expired records
(cherry picked from commit e49f83499a)
2022-12-07 23:59:36 +00:00
Mark Andrews
50caecea06 Revert "Fix rndc dumpdb -expired for stuck cache contents"
This reverts commit f8d866c6ef.

(cherry picked from commit 90249e4aa5)
2022-12-07 23:59:36 +00:00
Mark Andrews
2cc91f65c4 Merge branch '3724-update-dig-tcp-documentation-v9_18' into 'v9_18'
Add reference to +tcp for +ignore [v9_18]

See merge request isc-projects/bind9!7186
2022-12-07 23:13:46 +00:00
Mark Andrews
f8ce443684 Add reference to +tcp for +ignore
(cherry picked from commit b5951f0411)
2022-12-08 09:29:35 +11:00