Commit Graph
29382 Commits
Author SHA1 Message Date
Michał Kępień 68e930b97f Merge branch '2467-add-a-system-test-checking-a-malformed-ixfr-v9_11' into 'v9_11'
[v9_11] Add a system test checking a malformed IXFR

See merge request isc-projects/bind9!5134
2021-06-02 12:17:31 +00:00
Mark AndrewsandMichał Kępień 8db59aea11 Add a system test checking a malformed IXFR
Make sure an incoming IXFR containing an SOA record which is not placed
at the apex of the transferred zone does not result in a broken version
of the zone being served by named and/or a subsequent crash.

(cherry picked from commit 5547003a3d)
2021-06-02 13:57:01 +02:00
Michal Nowak d67d86577d Merge branch 'mnowak/add-fedora-34-v9_11' into 'v9_11'
[v9_11] Add Fedora 34

See merge request isc-projects/bind9!5114
2021-05-28 11:34:28 +00:00
Michal Nowak 7889acbc85 Add Fedora 34
(cherry picked from commit 5f27aaa0ff)
2021-05-28 13:09:20 +02:00
Michal Nowak bcf9363d64 Merge branch 'mnowak/install-bind-by-setting-DESTDIR-v9_11' into 'v9_11'
[v9_11] Install BIND with "make DESTDIR=<PATH> install"

See merge request isc-projects/bind9!5092
2021-05-25 16:47:30 +00:00
Michal Nowak 039979e460 Install BIND with "make DESTDIR=<PATH> install"
BIND installation should be done by setting $DESTDIR during "make
install", not by setting --prefix via ./configure to the destination
directory. However, on 9.11 --prefix still needs to be set to eliminate
the compatibility mode with older BIND9 releases (see the comment in
configure.ac, lines 379-396), which does not place sysconfdir and
localstatedir to $DESTDIR/$prefix but directly to $DESTDIR. When
--prefix is set they end up in $DESTDIR/$prefix, which is the BIND 9.16+
default).

    $ ./configure && make && make install DESTDIR=/tmp/bind9
    $ ls /tmp/bind9/{,usr/local}
    /tmp/bind9/:
    etc  usr  var
    /tmp/bind9/usr/local:
    bin  include  lib  sbin  share

    $ ./configure --prefix=/usr/local && make && make install DESTDIR=/tmp/bind9
    $ ls /tmp/bind9/{,usr/local}
    /tmp/bind9/:
    usr
    /tmp/bind9/usr/local:
    bin  etc  include  lib  sbin  share  var

Make sure that installation with DESTDIR=<PATH> works by checking that
named binary and it's respective man page were installed and that
well-known BIND9 directories - and only them - are present in DESTDIR.

Also rename install path variable from BIND_INSTALL_PATH to
INSTALL_PATH to avoid namespace clash in stress tests which use
BIND_INSTALL_PATH variable to configure path to BIND9 binaries.

(cherry picked from commit 823bf3e79b)
2021-05-25 18:42:37 +02:00
Ondřej Surý 4243b429df Merge branch 'ondrej/replace-ubuntu-xenial-with-ubuntu-bionic-v9_11' into 'v9_11'
Replace Ubuntu 16.04 LTS with Ubuntu 18.04 LTS in the GitLab CI (v9.11)

See merge request isc-projects/bind9!5089
2021-05-24 20:22:44 +00:00
Ondřej Surý 46b969f23b Replace Ubuntu 16.04 LTS with Ubuntu 18.04 LTS in the GitLab CI
Ubuntu 16.04 (Xenial Xerus) is reaching End of Standard Support in April
2021 thus we are removing it from the list of supported platforms and
replacing it with Ubuntu 18.04 LTS (Bionic Beaver).

(cherry picked from commit 4402a90bb7)
2021-05-24 21:57:42 +02:00
Michal Nowak 16499e47fc Merge branch 'mnowak/freebsd-13-v9_11' into 'v9_11'
[v9_11] Add FreeBSD 13.0

See merge request isc-projects/bind9!5087
2021-05-24 18:51:30 +00:00
Michal Nowak 25b8add382 Run gcc:tarball CI job for merge requests
Running gcc:tarball CI job for merge requests is consistent with how we
run gcc:out-of-tree CI job and should help identify problems with the
build system during the review process, not once merged during daily
runs. For the sake of time, unit and system tests associated with the
gcc:tarball CI job are excluded from merge requests.

Also, make sure that the tarball-create CI job includes the
default_triggering_rules anchor (as it is on the main branch), otherwise
adding the gcc:tarball CI job to merge request-triggered pipeline fails
with:

    Found errors in your .gitlab-ci.yml: 'gcc:tarball' job needs 'tarball-create' job but it was not added to the pipeline

(cherry picked from commit 83617cea9a)
2021-05-24 20:04:44 +02:00
Michal Nowak a3bd8d36d8 Do not spawn FreeBSD 11 CI jobs in merge requests
(cherry picked from commit 70eccd2952)
2021-05-24 20:04:08 +02:00
Michal Nowak 7319cc786a Create an anchor for schedules, tags, and web rules
It's a common pattern to spawn CI jobs only for pipelines triggered by
schedules, tags, and web. There should be an anchor so that the rules
are not repeated.

(cherry picked from commit e4f88c359c)
2021-05-24 20:03:48 +02:00
Michal Nowak 3f56557d55 Add FreeBSD 13.0
(cherry picked from commit 0714fe6f40)
2021-05-24 19:45:22 +02:00
Michal Nowak 4dea18e4a2 Merge branch '2452-iterated_hash-c-warning-argument-1-of-type-unsigned-char-20-with-mismatched-bound' into 'v9_11'
Fix argument with mismatched bound in isc_iterated_hash()

See merge request isc-projects/bind9!5039
2021-05-20 12:28:27 +00:00
Michal Nowak 57a3ae9d97 Fix argument with mismatched bound in isc_iterated_hash()
GCC 11 produced the following warning:

    iterated_hash.c:21:33: warning: argument 1 of type ‘unsigned char[20]’ with mismatched bound [-Warray-parameter=]
       21 | isc_iterated_hash(unsigned char out[ISC_SHA1_DIGESTLENGTH],
          |                   ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
    In file included from iterated_hash.c:18:
    ./include/isc/iterated_hash.h:33:37: note: previously declared as ‘unsigned char[155]’
       33 | int isc_iterated_hash(unsigned char out[NSEC3_MAX_HASH_LENGTH],
          |                       ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
2021-05-20 13:35:08 +02:00
Michal Nowak ed85a2f866 Merge branch '2453-sha2-c-warning-argument-with-mismatched-bound' into 'v9_11'
Fix arguments with mismatched bound in lib/isc/sha2.c

See merge request isc-projects/bind9!5038
2021-05-20 11:34:20 +00:00
Michal Nowak 7ceeaca0dc Fix arguments with mismatched bound in lib/isc/sha2.c
GCC 11 produced the following warnings:

    sha2.c:888:26: error: argument 1 of type ‘uint8_t[]’ {aka ‘unsigned char[]’} with mismatched bound [-Werror=array-parameter=]
      888 | isc_sha224_final(uint8_t digest[], isc_sha224_t *context) {
          |                  ~~~~~~~~^~~~~~~~
    In file included from sha2.c:58:
    ./include/isc/sha2.h:132:24: note: previously declared as ‘uint8_t[28]’ {aka ‘unsigned char[28]’}
      132 | void isc_sha224_final (uint8_t[ISC_SHA224_DIGESTLENGTH], isc_sha224_t *);
          |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    sha2.c:1151:26: error: argument 1 of type ‘uint8_t[]’ {aka ‘unsigned char[]’} with mismatched bound [-Werror=array-parameter=]
     1151 | isc_sha256_final(uint8_t digest[], isc_sha256_t *context) {
          |                  ~~~~~~~~^~~~~~~~
    In file included from sha2.c:58:
    ./include/isc/sha2.h:139:24: note: previously declared as ‘uint8_t[32]’ {aka ‘unsigned char[32]’}
      139 | void isc_sha256_final (uint8_t[ISC_SHA256_DIGESTLENGTH], isc_sha256_t *);
          |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    sha2.c:1514:31: error: argument 1 of type ‘uint8_t[]’ {aka ‘unsigned char[]’} with mismatched bound [-Werror=array-parameter=]
     1514 | void isc_sha512_final(uint8_t digest[], isc_sha512_t *context) {
          |                       ~~~~~~~~^~~~~~~~
    In file included from sha2.c:58:
    ./include/isc/sha2.h:153:24: note: previously declared as ‘uint8_t[64]’ {aka ‘unsigned char[64]’}
      153 | void isc_sha512_final (uint8_t[ISC_SHA512_DIGESTLENGTH], isc_sha512_t *);
          |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    sha2.c:1567:26: error: argument 1 of type ‘uint8_t[]’ {aka ‘unsigned char[]’} with mismatched bound [-Werror=array-parameter=]
     1567 | isc_sha384_final(uint8_t digest[], isc_sha384_t *context) {
          |                  ~~~~~~~~^~~~~~~~
    In file included from sha2.c:58:
    ./include/isc/sha2.h:146:24: note: previously declared as ‘uint8_t[48]’ {aka ‘unsigned char[48]’}
      146 | void isc_sha384_final (uint8_t[ISC_SHA384_DIGESTLENGTH], isc_sha384_t *);
          |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    sha2.c:1604:44: error: argument 2 of type ‘char[]’ with mismatched bound [-Werror=array-parameter=]
     1604 | isc_sha224_end(isc_sha224_t *context, char buffer[]) {
          |                                       ~~~~~^~~~~~~~
    In file included from sha2.c:58:
    ./include/isc/sha2.h:133:39: note: previously declared as ‘char[57]’
      133 | char *isc_sha224_end (isc_sha224_t *, char[ISC_SHA224_DIGESTSTRINGLENGTH]);
          |                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    sha2.c:1645:44: error: argument 2 of type ‘char[]’ with mismatched bound [-Werror=array-parameter=]
     1645 | isc_sha256_end(isc_sha256_t *context, char buffer[]) {
          |                                       ~~~~~^~~~~~~~
    In file included from sha2.c:58:
    ./include/isc/sha2.h:140:39: note: previously declared as ‘char[65]’
      140 | char *isc_sha256_end (isc_sha256_t *, char[ISC_SHA256_DIGESTSTRINGLENGTH]);
          |                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    sha2.c:1686:44: error: argument 2 of type ‘char[]’ with mismatched bound [-Werror=array-parameter=]
     1686 | isc_sha512_end(isc_sha512_t *context, char buffer[]) {
          |                                       ~~~~~^~~~~~~~
    In file included from sha2.c:58:
    ./include/isc/sha2.h:154:39: note: previously declared as ‘char[129]’
      154 | char *isc_sha512_end (isc_sha512_t *, char[ISC_SHA512_DIGESTSTRINGLENGTH]);
          |                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    sha2.c:1727:44: error: argument 2 of type ‘char[]’ with mismatched bound [-Werror=array-parameter=]
     1727 | isc_sha384_end(isc_sha384_t *context, char buffer[]) {
          |                                       ~~~~~^~~~~~~~
    In file included from sha2.c:58:
    ./include/isc/sha2.h:147:39: note: previously declared as ‘char[97]’
      147 | char *isc_sha384_end (isc_sha384_t *, char[ISC_SHA384_DIGESTSTRINGLENGTH]);
          |                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cc1: all warnings being treated as errors
2021-05-20 12:55:14 +02:00
Michał Kępień a529145553 Merge branch 'v9_11_32-release' into 'v9_11'
Merge 9.11.32 release branch

See merge request isc-projects/bind9!5070
2021-05-20 10:44:35 +00:00
Michał Kępień 89ac216731 Set up release notes for BIND 9.11.33 2021-05-20 12:34:09 +02:00
Michał Kępień 80ffcfe774 Bump BIND_BASELINE_VERSION for ABI checks 2021-05-20 12:34:09 +02:00
Tinderbox UserandMichał Kępień bb002982b6 Merge branch 'prep-release' into v9_11_32-release 2021-05-20 12:34:09 +02:00
Michał Kępień 27c8369c3c Merge branch 'michal/prepare-documentation-for-bind-9.11.32' into 'v9_11_32-release'
Prepare documentation for BIND 9.11.32

See merge request isc-private/bind9!295
2021-05-20 12:34:09 +02:00
Tinderbox UserandMichał Kępień 82a83e41bf prep 9.11.32 2021-05-20 12:34:09 +02:00
Michał Kępień 1c2c3a90df Prepare release notes for BIND 9.11.32 2021-05-20 12:34:09 +02:00
Michał Kępień 20b7a5d31b Reorder release notes 2021-05-20 12:34:09 +02:00
Michał Kępień 40cce0bb71 Tweak and reword release notes 2021-05-20 12:34:09 +02:00
Michał Kępień 8351a774b3 Tweak and reword recent CHANGES entries 2021-05-20 12:34:09 +02:00
Michal Nowak c0d1666f21 Merge branch 'mnowak/openbsd-6.9-v9_11' into 'v9_11'
[v9_11] Add OpenBSD 6.9

See merge request isc-projects/bind9!5065
2021-05-19 17:33:39 +00:00
Michal Nowak 4b6b04e8bf Add OpenBSD 6.9
(cherry picked from commit 315b8522ba)
2021-05-19 18:27:40 +02:00
Mark Andrews a6e1e8b8a8 Merge branch '2701-gcc-10-fanalyzer-reports-dereference-of-null-label-in-lib-dns-name-c-1167-v9_11' into 'v9_11'
Silence gcc-10-fanalyzer false positive

See merge request isc-projects/bind9!5050
2021-05-18 08:30:23 +00:00
Mark Andrews ff88e33cff Silence gcc-10-fanalyzer false positive
If 'state == ft_ordinary' then 'label' can't be NULL. Add
INSIST to reflect this.

(cherry picked from commit 29f1c1e677)
2021-05-18 16:46:07 +10:00
Mark Andrews c78813338a Merge branch '2702-gcc-10-fanalyzer-reports-v9_11' into 'v9_11'
Silence gcc-10-fanalyzer false positive

See merge request isc-projects/bind9!5045
2021-05-18 06:15:25 +00:00
Mark Andrews baa40e47cd Silence gcc-10-fanalyzer false positive
Add REQUIRE(type == dns_rdatatype_nsec3 || firstp != NULL); so
that dereferences of *firstp is not flagged as a NULL pointer
dereference.

(cherry picked from commit 683ad6e4bd)
2021-05-18 15:48:32 +10:00
Michal Nowak 0703eb14eb Merge branch '2692-grep-from-freebsd-13-0-stumbles-on-r-in-digdelv-test-v9_11' into 'v9_11'
[v9_11] Do not use escape codes for matching with grep

See merge request isc-projects/bind9!5033
2021-05-17 11:37:40 +00:00
Michal Nowak 62035221e3 Do not use escape codes for matching with grep
FreeBSD 13.0 replaced GNU grep with BSD grep and removed support for
"redundant escapes for most ordinary characters" from regex(3) library,
therefore the matching sequence in digdelv/tests.sh needs to be
rewritten otherwise it fails with:

    grep: trailing backslash (\)

(cherry picked from commit 253ae96bf1)
2021-05-17 13:14:31 +02:00
Michal Nowak c524142b74 Merge branch 'mnowak/use-sigabrt-from-start.pl-v9_11' into 'v9_11'
[v9_11] Use SIGABRT instead of SIGKILL to produce cores on failed start

See merge request isc-projects/bind9!4992
2021-05-04 15:54:20 +00:00
Ondřej SurýandMichal Nowak 401b3519eb Use SIGABRT instead of SIGKILL to produce cores on failed start
When the `named` would hang on startup it would be killed with SIGKILL
leaving us with no information about the state the process was in.
This commit changes the start.pl script to send SIGABRT instead, so we
can properly collect and process the coredump from the hung named
process.

(cherry picked from commit 861a236937)
2021-05-04 17:22:41 +02:00
Matthijs Mekking dfadbc9d7b Merge branch 'matthijs-nsupdate-update_test-v9_11' into 'v9_11'
Update nsupdate test (9.11)

See merge request isc-projects/bind9!4979
2021-04-30 12:57:46 +00:00
Matthijs Mekking 5d899d0d99 Update nsupdate test
The nsupdate system test did not record failures from the
'update_test.pl' Perl script. This was because the 'ret' value was
not being saved outside the '{ $PERL ... || ret=1 } cat_i' scope.

Change this piece to store the output in a separate file and then
cat its contents. Now the 'ret' value is being saved.

Also record failures in 'update_test.pl' if sending the update
failed.

Add missing 'n' incrementals to 'nsupdate/test.sh' to keep track of
test numbers.

(cherry picked from commit 5b31811b5f)
2021-04-30 14:30:51 +02:00
Matthijs Mekking f2ff6fcc47 Merge branch '2445-nsec3-iterations-resolver-v9_11' into 'v9_11'
Mark DNSSEC responses with NSEC3 records that exceed 150 as insecure (9.11)

See merge request isc-projects/bind9!4974
2021-04-30 09:35:20 +00:00
Mark AndrewsandMatthijs Mekking 83cbbf0ac8 Add release note for [GL #2445]
(manually picked from commit ad236976fc)
2021-04-30 11:13:37 +02:00
Mark AndrewsandMatthijs Mekking 523b9b02af Add CHANGES for [GL #2445]
(cherry picked from commit fd1f7b6480)
2021-04-30 11:13:37 +02:00
Mark AndrewsandMatthijs Mekking 02f4a9d6b3 Check insecure responses returned with too many NSEC3 iterations
(cherry picked from commit e6e0e29fbb)
2021-04-30 11:13:37 +02:00
Matthijs Mekking 2c81206984 Sync dns results
Add missing DNS results from 9.16. We only care about
DNS_R_NSEC3ITERRANGE but better to sync and use the same numbers than
use a different number for this result code than what is used in 9.16.
2021-04-30 09:58:44 +02:00
Mark AndrewsandMatthijs Mekking 1647bc7dc4 Mark DNSSEC responses with NSEC3 records that exceed 150 as insecure
(cherry picked from commit af02bbcdd6)
2021-04-30 09:36:45 +02:00
Mark Andrews 2ee92dd506 Merge branch '2668-handle-net-dns-versions-that-don-t-support-nsec3param-v9_11' into 'v9_11'
NSEC3PARAM support was added to Net::DNS in 1.00_06

See merge request isc-projects/bind9!4973
2021-04-30 06:56:14 +00:00
Mark Andrews eb3122cd38 NSEC3PARAM support was added to Net::DNS in 1.00_06
Require 1.01 or later to when adding a NSEC3PARAM records.

(cherry picked from commit 044933756a)
2021-04-30 16:29:57 +10:00
Mark Andrews e0fcb90b09 Merge branch '2658-update-zonemd-now-that-rfc-8976-has-been-issued-v9_11' into 'v9_11'
Update ZONEMD to match RFC 8976

See merge request isc-projects/bind9!4970
2021-04-30 02:30:23 +00:00
Mark Andrews e4e4ff0e10 Update ZONEMD to match RFC 8976
* The location of the digest type field has changed to where the
  reserved field was.
* The reserved field is now called scheme and is where the digest
  type field was.
* Digest type 2 has been defined (SHA256).

(cherry picked from commit 8510ccaa54)
2021-04-30 11:31:05 +10:00
Mark Andrews 4aaddec8d9 Merge branch '2642-reduce-the-maximum-nsec3-iterations-that-can-be-configured-v9_11' into 'v9_11'
Reduce nsec3 max iterations to 150 (9.11)

See merge request isc-projects/bind9!4967
2021-04-30 01:14:38 +00:00