Commit Graph

33648 Commits

Author SHA1 Message Date
Evan Hunt
6773c1144f increase 1-second timeout in fetchlimit
when "checking lame server clients are dropped below the hard limit",
periodically a query is sent for a name for which the server is
authoritative, to verify that legitimate queries can still be
processed while the server is dealing with a flood of lame delegation
queries. those queries used the same dig options as elsewhere in the
fetchlimit test, including "+tries=1 +timeout=1". on slow systems, a
1-second timeout may be insufficient to get an answer even if the server
is behaving well. this commit increases the timeout for the check
queries to 2 seconds in hopes that will be enough to eliminate test
failures in CI.

(cherry picked from commit 45f330339c)
2021-09-02 23:24:57 -07:00
Mark Andrews
0a3e398e0c Merge branch '2890-update-documentation-with-respect-to-sig-validity-interval-and-update-v9_16' into 'v9_16'
Update sig-validity-interval description

See merge request isc-projects/bind9!5379
2021-09-03 03:45:01 +00:00
Mark Andrews
ad411b1120 Update sig-validity-interval description
Document that the interval on new RRSIG records is randomally
chosen between the limits specified by sig-validity-interval.
document the operatations when this occurs.

(cherry picked from commit e65ce00f11)
2021-09-03 13:19:09 +10:00
Evan Hunt
9174cff949 Merge branch '2878-large-map-file-v9_16' into 'v9_16'
map files over 2GB could not be loaded

See merge request isc-projects/bind9!5374
2021-09-01 15:53:47 +00:00
Evan Hunt
fe66c88d02 CHANGES 2021-09-01 08:17:32 -07:00
Evan Hunt
06b9fc8a7d add a test for large map files
- a test has been added to 'masterformat', but disabled by default,
  because it takes several minutes to run and uses a lot of disk.
2021-09-01 08:17:32 -07:00
Evan Hunt
e9d62d2442 map files over 2GB could not be loaded
- fixed a size comparison using "signed int" that failed if the file
  size was more than 2GB, since that was treated as a negative number.
- incidentally renamed deserialize32() to just deserialize(). we no
  longer have separate 32 and 64 bit rbtdb implementations.
2021-09-01 00:43:54 -07:00
Mark Andrews
cfaba88f15 Merge branch '2891-missing-parenthesis-in-the-atomic_load_explicit-macro' into 'v9_16'
Resolve "Missing parenthesis in the `atomic_load_explicit` macro"

See merge request isc-projects/bind9!5375
2021-09-01 07:42:43 +00:00
Mark Andrews
6cbfbe5381 Add CHANGES for [GL #2891] 2021-09-01 17:23:14 +10:00
Mark Andrews
9a01b867af Fix the definition of atomic_load_explicit in the win32 shim
incorrect parentheses result in incorrect sizeof test
2021-09-01 10:26:16 +10:00
Ondřej Surý
f9b005e2f6 Merge branch '2837-windows-service-isc-trampoline-v9_16' into 'v9_16'
Initialize the main thread trampoline for Windows Service process

See merge request isc-projects/bind9!5352
2021-08-31 18:19:35 +00:00
Ondřej Surý
49212d9595 Add CHANGES for [GL #2837] 2021-08-31 17:54:04 +00:00
Ondřej Surý
ec64f4492b Initialize the main thread trampoline for Windows Service process
When BIND is running as a Windows Service the ISC library's
initializations initiated by the DLLMain loading procedure are
happening under the Windows Service Manager thread instead of
BIND's main thread.

This commit will make sure that BIND's main thread trampoline has
been initialized before running the main() function.
2021-08-31 17:53:30 +00:00
Evan Hunt
05ce4af871 Merge branch '1944-primary-secondary-v9_16' into 'v9_16'
update to primary/secondary terminology internally

See merge request isc-projects/bind9!5370
2021-08-30 19:32:05 +00:00
Evan Hunt
9acd616ba5 CHANGES
(cherry picked from commit 18b878fb01)
2021-08-30 12:00:42 -07:00
Evan Hunt
fb88554bf0 switch to primary/secondary in config.c
some of the built-in configuration was still using outdated terms.

(cherry picked from commit ae8cfa4683)
2021-08-30 12:00:42 -07:00
Evan Hunt
255d092c40 change CFG_ZONE_MASTER and CFG_ZONE_SLAVE
these values have been renamed as CFG_ZONE_PRIMARY and
CFG_ZONE_SECONDARY.

(cherry picked from commit 679f1c0dad)
2021-08-30 12:00:39 -07:00
Evan Hunt
ddc677ae64 rename dns_zone_master and dns_zone_slave
dns_zone_master and dns_zone_slave are renamed as dns_zone_primary
and dns_zone_secondary.

(cherry picked from commit 916760ae46)
2021-08-30 11:58:29 -07:00
Petr Špaček
2bd05add9a Merge branch '2856-CVE-2021-25218-regression-test-v9_16' into 'v9_16'
[v9_16] Add a regression test in the RRL system test

See merge request isc-projects/bind9!5361
2021-08-30 16:44:12 +00:00
Petr Špaček
d1a5f4ee9f Lower loopback MTU size on other unix systems as well
This change should cover recent versions of:
Solaris, illumos, OpenBSD, FreeBSD, Dragonfly BSD, NetBSD.

(cherry picked from commit d8363845b6)
2021-08-30 17:31:48 +02:00
Evan Hunt
422c032151 Add a regression test in the RRL system test
This commit modifies the MTU of the loopback interface on
Linux systems to 1500, so that oversized UDP packets can
trigger EMSGSIZE errors, and tests that named handles
such errors correctly.

Note that the loopback MTU size has not yet been modified
for other platforms.

(cherry picked from commit cfd058d622)
2021-08-30 17:31:43 +02:00
Evan Hunt
1dacb46892 Merge branch '2872-fix-map-zonefile-version-number-v9_16' into 'v9_16'
Fix crash while loading map zone files generated by BIND >= 9.16.2 && <= 9.16.19 [v9.16]

See merge request isc-projects/bind9!5346
2021-08-28 15:20:58 +00:00
Evan Hunt
9123feca1e CHANGES, release note
(cherry picked from commit 351ed777c2)
2021-08-28 07:45:39 -07:00
Evan Hunt
8118ce9f6d expand map file documentation
discuss map file compatibility issues in more detail.

(cherry picked from commit 4b61e74470)
2021-08-28 07:45:39 -07:00
Petr Špaček
b70a2c2d07 increase MAPAPI
bump the map zonefile version number to avoid an assertion
failure when loading map files from versions of BIND prior to
the most recent change to the in-memory structure of zone
databases.

(cherry picked from commit 4a68c7be22)
2021-08-28 07:45:39 -07:00
Evan Hunt
405fa18ff3 Merge branch '1927-fix-keepalive-v9_16' into 'v9_16'
Resolve "keepalive appears to be unused"

See merge request isc-projects/bind9!5368
2021-08-27 20:40:36 +00:00
Evan Hunt
a69008210b CHANGES
(cherry picked from commit 45752f9505)
2021-08-27 13:20:06 -07:00
Evan Hunt
e28f5e28c4 add a test of the keepalive timeout
test server now has tcp-idle-timeout set to 5 seconds and
tcp-keepalive-timeout set to 7, so queries that follow a 6-second sleep
should either succeed or fail depending on whether the keepalive option
was sent.

(cherry picked from commit 947e80066c)
2021-08-27 13:20:06 -07:00
Evan Hunt
4f87dcac1a replace per-protocol keepalive functions with a common one
this commit removes isc__nm_tcpdns_keepalive(); the keepalive
value for this protocol and for TCP will now be set directly from
isc_nmhandle_keepalive().

(cherry picked from commit fc6f751fbe)
2021-08-27 13:20:06 -07:00
Evan Hunt
6b7e4e753a enable keepalive when the keepalive EDNS option is seen
previously, receiving a keepalive option had no effect on how
long named would keep the connection open; there was a place to
configure the keepalive timeout but it was never used. this commit
corrects that.

this also fixes an error in isc__nm_tcpdns_keepalive()
in which the sense of a REQUIRE test was reversed; previously this
error had not been noticed because the functions were not being
used.

(cherry picked from commit 7867b8b57d)
2021-08-27 13:20:06 -07:00
Evan Hunt
de00df3669 cleanup netmgr-int.h
- fix some duplicated and out-of-order prototypes declared in
  netmgr-int.h
- rename isc_nm_tcpdns_keepalive to isc__nm_tcpdns_keepalive as
  it's for internal use

(cherry picked from commit 19e24e22f5)
2021-08-27 13:20:02 -07:00
Mark Andrews
1c721e67d6 Merge branch '1805-save-failed-build-artifacts-v9_16' into 'v9_16'
always save build artifacts

See merge request isc-projects/bind9!5364
2021-08-26 04:45:22 +00:00
Mark Andrews
b8e7bdc8e6 always save build artifacts
(cherry picked from commit 221228572f)
2021-08-26 14:21:52 +10:00
Mark Andrews
e216c79a5e Merge branch '2880-timing-issues-with-rndc-system-test-v9_16' into 'v9_16'
wait for post 'rndc freeze' writes to complete

See merge request isc-projects/bind9!5363
2021-08-26 04:15:58 +00:00
Mark Andrews
a8413d5f0f wait for post 'rndc freeze' writes to complete
(cherry picked from commit 45b6b8199e)
2021-08-26 13:18:33 +10:00
Mark Andrews
a8914f9e11 Merge branch '2461-named-checkconf-fails-to-detect-illegal-key-names-in-primaries-lists-v9_16' into 'v9_16'
[v9_16] Named-checkconf fails to detect illegal key names in primaries lists

See merge request isc-projects/bind9!5359
2021-08-26 00:27:51 +00:00
Mark Andrews
2ffb2e5ffd Add CHANGED for [GL #2461]
(cherry picked from commit 5d2183c450)
2021-08-26 00:00:16 +00:00
Mark Andrews
706f5811c3 Check that primary key names are syntactically valid
(cherry picked from commit 4fa9d8389a)
2021-08-26 00:00:16 +00:00
Evan Hunt
3638f2d284 Merge branch '331-further-refactoring-of-functions-in-lib-dns-zoneverify-c-v9_16' into 'v9_16'
Resolve "Further refactoring of functions in lib/dns/zoneverify.c"

See merge request isc-projects/bind9!5362
2021-08-25 23:32:58 +00:00
Diego Fronza
f262860d5d Replace literal 255 with a more descriptive macro name
More details on thread:
https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/291#note_12186

(cherry picked from commit bd0cc048d1)
2021-08-25 15:57:35 -07:00
Diego Fronza
caa4af08d4 Avoid an empty block under if condition
This commit doesn't change the logic flow from previous code, it only
makes the code more readable and consistent.

More details on thread:
https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/291#note_12185

(cherry picked from commit 90e724af45)
2021-08-25 15:57:35 -07:00
Diego Fronza
7af2573219 Remove redundant function 'newchain'
The removed function 'newchain(a, b)' was almost the same as calling
!chain_equal(a, b), varying only in the amount of data compared
in the non-fixed-length data portion of given chain nodes.

A third argument 'data_size' has been introduced into 'chain_equal'
function in order to allow it to know how many bytes to compare in the
variable-length data portion of the chain nodes.

A helper function 'chain_length(e)' has been introduced to allow
easy calculation of the total length of the non-fixed-length data part
of chain nodes.

Check the thread below for more details:
https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/291#note_12184

(cherry picked from commit 37f42d19a1)
2021-08-25 15:57:35 -07:00
Diego Fronza
063bc21543 Use sizeof instead of arbitrary number to iterate fixed size array
More details on thread:
https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/291#note_12180

(cherry picked from commit 6a12e37382)
2021-08-25 15:57:34 -07:00
Diego Fronza
9954c2da91 Initialize buffers with { 0 } instead of memset
More details on threads:
https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/291#note_12178
https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/291#note_12181

(cherry picked from commit 87e970474f)
2021-08-25 15:57:34 -07:00
Diego Fronza
9f5c643769 Minor refactoring on function match_nsec3
The logic for matching a set of nsec3 objects against an nsec3param
object was moved to a specific function.

For more details check thread:
https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/291#note_12176

(cherry picked from commit 98d1e40143)
2021-08-25 15:57:34 -07:00
Diego Fronza
ebb827c1d5 Minor refactoring/cleanup
This commit moves the warning message to the logical block where it
belongs better.

For more details check thread comment:
https://gitlab.isc.org/isc-projects/bind9/merge_requests/291#note_12167

(cherry picked from commit 966c06a9e6)
2021-08-25 15:57:34 -07:00
Mark Andrews
cac4c29f64 Merge branch '2842-clean-up-catalog-journal-v9_16' into 'v9_16'
[v9_16] Clean up catalog journal

See merge request isc-projects/bind9!5358
2021-08-25 05:44:48 +00:00
Mark Andrews
d4d7e060ab Add CHANGES for [GL #2842]
(cherry picked from commit 53f9416176)
2021-08-25 15:17:51 +10:00
Mark Andrews
c3db4acf61 Also delete journal file
(cherry picked from commit 0b83636648)
2021-08-25 15:17:51 +10:00
Mark Andrews
3e2a39dc7a check that journal files are also removed
(cherry picked from commit 1972300919)
2021-08-25 15:17:51 +10:00