Commit Graph

38552 Commits

Author SHA1 Message Date
Ondřej Surý
6557abc8bc Optimize the slabheader placement for certain RRTypes
Mark the infrastructure RRTypes as "priority" types and place them at
the beginning of the rdataslab header data graph.  The non-priority
types either go right after the priority types (if any).

(cherry picked from commit 3ac482be7f)
2024-02-08 08:48:09 +01:00
Ondřej Surý
d228dc63c1 Fix missing RRSIG for CNAME with different slabheader order
The cachedb was missing piece of code (already found in zonedb) that
would make lookups in the slabheaders to miss the RRSIGs for CNAME if
the order of CNAME and RRSIG(CNAME) was reversed in the node->data.

(cherry picked from commit 5070c7f5c7)
2024-02-08 08:37:24 +01:00
Mark Andrews
02d7e7bf47 Merge branch '4561-shutdown-test-doesn-t-log-everything-to-named-run-bind-9.18' into 'bind-9.18'
[9.18] Resolve "Shutdown test doesn't log everything to named.run"

See merge request isc-projects/bind9!8701
2024-02-07 01:39:23 +00:00
Tom Krizek
1b6c96a8ed Re-enable rndc shutdown test
The issue preventing a proper rndc shutdown was recently fixed and
the test now passes.

(cherry picked from commit fb70c4d475)
2024-02-07 12:09:03 +11:00
Mark Andrews
84078b96c0 Capture the resolver's startup and shutdown logging
Also set the debugging to 99.

(cherry picked from commit 3651c58a6a)
2024-02-07 12:09:02 +11:00
Matthijs Mekking
06912673df Merge branch '4531-improve-parental-agents-definition-arm-v9_18' into 'bind-9.18'
[9.18] Improve parental-agents definition in ARM

See merge request isc-projects/bind9!8691
2024-02-02 16:50:50 +00:00
Matthijs Mekking
9f1395e48e Add CHANGES for #4531
Improve ARM parental-agents definition.

(cherry picked from commit ab9c62f4b9)
2024-02-02 17:22:48 +01:00
Matthijs Mekking
37e3c3d7fb Improve parental-agents definition in ARM
"A parental agent is the entity that is allowed to change a zone's
delegation information" is untrue, because it is possible to use some
hidden server or a validating resolver.

Also the new text makes it more clear that named sends DS queries to
these servers.

(cherry picked from commit 604f8e7797)
2024-02-02 17:22:32 +01:00
Arаm Sаrgsyаn
e4996fd06a Merge branch 'aram/dns-getdb-flags-fix-9.18' into 'bind-9.18'
[9.18] Fix the DNS_GETDB_STALEFIRST flag

See merge request isc-projects/bind9!8690
2024-02-02 15:46:30 +00:00
Aram Sargsyan
4af93d3c22 Add a CHANGES note for [GL !8683]
(cherry picked from commit f329c1ebc9)
2024-02-02 15:07:30 +00:00
Aram Sargsyan
cbc0357881 Improve the definition of the DNS_GETDB_* flags
Use the (1 << N) form for defining the flags, in order to avoid
errors like the one fixed in the previous commit.

Also convert the definitions to an enum, as done in some of our
recent refactoring work.

(cherry picked from commit 0d7c7777da)
2024-02-02 15:06:48 +00:00
Aram Sargsyan
2bcd6c2fd3 Fix the DNS_GETDB_STALEFIRST flag
The DNS_GETDB_STALEFIRST flag is defined as 0x0C, which is the
combination of the DNS_GETDB_PARTIAL (0x04) and the
DNS_GETDB_IGNOREACL (0x08) flags (0x04 | 0x08 == 0x0C) , which is
an obvious error.

All the flags should be power of two, so they don't interfere with
each other. Fix the DNS_GETDB_STALEFIRST flag by setting it to 0x10.

(cherry picked from commit be7d8fafe2)
2024-02-02 15:06:43 +00:00
Matthijs Mekking
b9d1ab6df1 Merge branch '4553-return-value-for-checkds-shadows-v9_18' into 'bind-9.18'
Don't also skip keymgr run if checkds is skipped

See merge request isc-projects/bind9!8688
2024-02-01 14:29:33 +00:00
Matthijs Mekking
b730a65975 Don't also skip keymgr run if checkds is skipped
Checking the DS at the parent only happens if dns_zone_getdnsseckeys()
returns success. However, if this function somehow fails, it can also
prevent the keymgr from running.

Before adding the check DS functionality, the keymgr should only run
if 'dns_dnssec_findmatchingkeys()' did not return an error (either
ISC_R_SUCCESS or ISC_R_NOTFOUND). After this change the correct
result code is used again.

(cherry picked from commit 07c2acf15d)
2024-02-01 13:32:56 +01:00
Matthijs Mekking
76d1ea8936 Merge branch '4551-dnssec-keygen-does-not-generate-tsig-keys-v9_18' into 'bind-9.18'
[9.18] dnssec-keygen man page still says it can do TSIG

See merge request isc-projects/bind9!8687
2024-02-01 11:36:21 +00:00
Matthijs Mekking
f58bf29cad Put reference to RFC 2845 in tsig-keygen man page
(cherry picked from commit 8a8c573be6)
2024-02-01 12:03:42 +01:00
Matthijs Mekking
b94bb41e59 dnssec-keygen man page still says it can do TSIG
Remove text in man page that says the program can also be used for
generate TSIG keys, this was removed in 9.13.0 but this text was still
not yet removed.

(cherry picked from commit aabb452953)
2024-02-01 12:03:36 +01:00
Michał Kępień
1a1b7d814e Merge branch 'michal/shift-CHANGES-entries-9.18' into 'bind-9.18'
[9.18] Shift CHANGES entries by two

See merge request isc-projects/bind9!8680
2024-01-31 10:22:22 +00:00
Michał Kępień
83e343a66d Shift CHANGES entries by two
Account for additional entries that will be included in February 2024
releases.

(cherry picked from commit 1b48c99392)
2024-01-31 11:21:04 +01:00
Michal Nowak
b8ca87939e Merge branch 'mnowak/drop-freebsd-12-9.18' into 'bind-9.18'
[9.18] Drop FreeBSD 12

See merge request isc-projects/bind9!8672
2024-01-26 10:59:22 +00:00
Michal Nowak
983cebead1 Drop FreeBSD 12
Support for FreeBSD 12.4, the last FreeBSD 12.x release, ended on
December 31, 2023.

Link: https://www.freebsd.org/security/unsupported/

Move the --with-readline=editline ./configure option to FreeBSD 14.

(cherry picked from commit 98bfa22381)
2024-01-26 10:47:23 +01:00
Matthijs Mekking
98db8d9b4c Merge branch '4510-doc-key-lifetime-too-short-9.18' into 'bind-9.18'
[9.18] Fix ZSK lifetime minimum constraints documentation

See merge request isc-projects/bind9!8671
2024-01-25 14:09:09 +00:00
Matthijs Mekking
066b31667a Add CHANGES for #4510
(cherry picked from commit 7e903c52be)
2024-01-25 14:23:06 +01:00
Matthijs Mekking
a64197c80f Fix ZSK lifetime minimum constraints documentation
The ARM failed to mention that the ZSK lifetime minimum also depends
on the signing delay.

(cherry picked from commit 53f0541db6)
2024-01-25 14:22:37 +01:00
Michal Nowak
f132740869 Merge branch 'mnowak/pytest_rewrite_dialup-9.18' into 'bind-9.18'
[9.18] Rewrite dialup system test to pytest

See merge request isc-projects/bind9!8669
2024-01-24 13:45:55 +00:00
Michal Nowak
816d26eb0d Rewrite dialup system test to pytest
(cherry picked from commit bc4c29888b)
2024-01-24 13:48:10 +01:00
Michal Nowak
03155da31e Speed up test by lowering "heartbeat-interval" to 1
(cherry picked from commit 6c6580ea83)
2024-01-24 13:48:10 +01:00
Tom Krizek
5bc557c3bb Merge branch '4445-stop-leaking-queries-to-root-in-tests-9.18' into 'bind-9.18'
[9.18] Ensure no test queries leak to root server

See merge request isc-projects/bind9!8666
2024-01-19 15:13:02 +00:00
Tom Krizek
e5403f39c1 Delete unused config file in dnssec system test
(cherry picked from commit f69df830c6)
2024-01-19 15:24:08 +01:00
Tom Krizek
d9fd971231 Ensure tests use mock root server if configured
These tests have ns1 configured as a mock root server. Make sure it is
used in all config files of those tests, otherwise some queries could
leak to root nameservers.

(cherry picked from commit 088fcf9a61)
2024-01-19 15:24:07 +01:00
Tom Krizek
1997c36ce4 Blackhole queries to root servers in tests
Some tests don't have a mock root server configured, because they don't
need one. However, these tests might still leak queries to actual name
servers. Add a shared root hints file which can serve as a blackhole for
these queries.

(cherry picked from commit 8434e5abfc)
2024-01-19 15:24:07 +01:00
Tom Krizek
b025e8dd2d Don't use root server in addzone test
(cherry picked from commit 7037eb96d4)
2024-01-19 15:24:05 +01:00
Michal Nowak
da7e6a3286 Merge branch 'mnowak/rpz-drop-queryperf-support-9.18' into 'bind-9.18'
[9.18] Drop queryperf support from rpz system test

See merge request isc-projects/bind9!8665
2024-01-19 13:47:49 +00:00
Michal Nowak
b1fc4f7dee Drop queryperf support from rpz system test
The queryperf support in the rpz system test is not utilized in the CI,
is likely not unused at all, and should be dropped.

(cherry picked from commit eaab796310)
2024-01-19 12:08:23 +01:00
Mark Andrews
eeef5371b6 Merge branch '4541-values-of-ruletype-field-for-update-policy-statement-bind-9.18' into 'bind-9.18'
[9.18] Resolve "values of ruletype field for update-policy statement"

See merge request isc-projects/bind9!8664
2024-01-19 06:17:22 +00:00
Mark Andrews
ce5fc0e466 Fix rule count, should be 18
(cherry picked from commit 81f9bcefaf)
2024-01-19 16:20:47 +11:00
Tom Krizek
d629795f36 Merge branch 'tkrizek/split-up-dnsrps-test-cases' into 'bind-9.18'
[9.18] Split up the dnsrps and native variants of rpz system tests

See merge request isc-projects/bind9!8661
2024-01-18 17:26:57 +00:00
Tom Krizek
575728dee8 Remove extraneous dnsrps-secondary.conf from rpz tests
The contents of the dnsrps-secondary.conf file are identical to the
contents of dnsrps.conf. Remove it since it's redundant.
2024-01-18 17:05:11 +01:00
Tom Krizek
cd6c9590f1 Remove obsolete ckdnsrps.sh script
As dnsrps and native test cases have been properly split up, the
ckdnsrps.sh script is no longer used anywhere, as the logic for
selecting these test cases is handled by pytest.

(cherry picked from commit b1d71c4d26)
2024-01-18 17:05:10 +01:00
Tom Krizek
bb5b41ad95 Split up the dnsrps and native variants of rpz system tests
Previously, dnsrps test was executed as an optional part of the rpz and
rpzrecurse system tests. This was conceptually problematic, as the test
took the responsibility of running parts of the test framework -
cleaning files and setting up servers again.

Instead, allow these tests to execute either the native variant, or the
dnsrps one. To ensure the same test coverage, trigger both of these
variants as separate test cases from pytest.

(cherry picked from commit cb55fb2cae)
2024-01-18 17:05:09 +01:00
Ondřej Surý
231dc3ff15 Merge branch '4404-add-workaround-to-force-jemalloc-linking-order-9.18' into 'bind-9.18'
[9.18] Add workaround for jemalloc linking order

See merge request isc-projects/bind9!8659
2024-01-18 10:24:16 +00:00
Ondřej Surý
e0bcda8923 Add CHANGES note for [GL #4404]
(cherry picked from commit ec12682933)
2024-01-18 10:40:46 +01:00
Aydın Mercan
3d0bfa3f28 Link jemalloc again for testing unit build order
(cherry picked from commit 6215206801)
2024-01-18 10:40:46 +01:00
Aydın Mercan
afb0b3971c Forward declare mallocx in isc/mem.h
cmocka.h and jemalloc.h/malloc_np.h has conflicting macro definitions.
While fixing them with push_macro for only malloc is done below, we only
need the non-standard mallocx interface which is easy to just define by
ourselves.

(cherry picked from commit 197de93bdc)
2024-01-18 10:40:46 +01:00
Ondřej Surý
f82f4d1d77 Add workaround for jemalloc linking order
Because we don't use jemalloc functions directly, but only via the
libisc library, the dynamic linker might pull the jemalloc library
too late when memory has been already allocated via standard libc
allocator.

Add a workaround round isc_mem_create() that makes the dynamic linker
to pull jemalloc earlier than libc.

(cherry picked from commit 41a0ee1071)
2024-01-18 10:40:46 +01:00
Tom Krizek
705924d233 Merge branch '3535-fetchlimit-test-flaky-9.18' into 'bind-9.18'
[9.18] Allow the fetchlimit test to be re-run

See merge request isc-projects/bind9!8657
2024-01-17 16:34:53 +00:00
Tom Krizek
a1af755a14 Allow the fetchlimit test to be re-run
The test is known to be unstable due to timing issues. Prevent frequent
false positives by allowing the test to be re-run by the flaky pytest
plugin.

(cherry picked from commit 10827fe96c)
2024-01-17 16:36:03 +01:00
Tom Krizek
4679bfe604 Don't type-check the flaky plugin with mypy
Since we execute mypy for bin/tests/system/isctest package, this is now
needed because the flaky package doesn't have type hints.

(cherry picked from commit a65b654a23)
2024-01-17 16:36:03 +01:00
Tom Krizek
af12ce03f3 Move custom pytest markers into isctest module
Keep our pytest code more organized by moving the shared code for custom
pytest markers into a dedicated isctest/mark.py module.

(cherry picked from commit f314f1b432)
2024-01-17 16:36:03 +01:00
Matthijs Mekking
17efc13cab Merge branch 'matthijs-fix-cds-is-published-log' into 'bind-9.18'
Fix CDS/CDNSKEY is published logging

See merge request isc-projects/bind9!8656
2024-01-17 12:31:07 +00:00