ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity
31,757 Commits 589 Branches 805 Tags
5a590c47a50bec2b6936aad685d10ead850dfd6b
Commit Graph

31757 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Matthijs Mekking
5a590c47a5 Set key rollover relationship without settime 
Using dnssec-setttime after dnssec-keygen in the kasp system test
can lead to off by one second failures, so reduce the usage of
dnssec-settime in the setup scripts.  This commit deals with
setting the key rollover relationship (predecessor/successor).
 2020-06-02 09:12:55 +02:00
Matthijs Mekking
637d5f9a68 Move setting keytimes from settime to keygen 
In the kasp system test, we are going to set the keytimes on
dnssec-keygen so we can test them against the key creation time.
This prevents off by one second in the test, something that can
happen if you set those times with dnssec-settime after
dnssec-keygen.

Also fix some test output filenames.
 2020-06-02 09:12:52 +02:00
Matthijs Mekking
18dc27afd3 Set keytimes appropriately when using kasp 
While kasp relies on key states to determine when a key needs to
be published or be used for signing, the keytimes are used by
operators to get some expectation of key publication and usage.

Update the code such that these keytimes are set appropriately.
That means:
- Print "PublishCDS" and "DeleteCDS" times in the state files.
- The keymgr sets the "Removed" and "PublishCDS" times and derives
  those from the dnssec-policy.
- Tweak setting of the "Retired" time, when retiring keys, only
  update the time to now when the retire time is not yet set, or is
  in the future.

This also fixes a bug in "keymgr_transition_time" where we may wait
too long before zone signatrues become omnipresent or hidden. Not
only can we skip waiting the sign delay Dsgn if there is no
predecessor, we can also skip it if there is no successor.

Finally, this commit moves setting the lifetime, reducing two calls
to one.
 2020-06-02 09:12:47 +02:00
Matthijs Mekking
1c21631730 keygen -k: allow to set times, not genonly 
For testing purposes mainly, we want to allow set keytimings on
generated keys, such that we don't have to "keygen/settime" which
can result in one second off times.
 2020-06-02 09:12:38 +02:00
Ondřej Surý
31fa72ec2e Merge branch '1164-add-danger-python-to-gitlab-ci' into 'master' 
Add Danger Python to GitLab CI

Closes #1164

See merge request isc-projects/bind9!3583
 2020-06-01 11:40:58 +00:00
Michał Kępień
36bb45a8b6 Add Danger Python to GitLab CI 
Certain rules of the BIND development process are not codified anywhere
and/or are used inconsistently.  In an attempt to improve this
situation, add a GitLab CI job which uses Danger Python to add comments
to merge requests when certain expectations are not met.  Two categories
of feedback are used, only one of which - fail() - causes the GitLab CI
job to fail.  Exclude dangerfile.py from Python QA checks as the way the
contents of that file are evaluated triggers a lot of Flake8 and PyLint
warnings.
 2020-06-01 11:13:31 +00:00
Ondřej Surý
a8aa9d4ff8 Merge branch 'ondrej/fix-higlight-typo' into 'master' 
Fix typo (higlight -> highlight) in documentation

See merge request isc-projects/bind9!3610
 2020-06-01 07:45:39 +00:00
Ondřej Surý
e6c867195d Fix typo (higlight -> highlight) in documentation 2020-06-01 09:41:58 +02:00
Ondřej Surý
3138bdf406 Merge branch 'sgoldlust-1826-various-text-edits-needed-in-bind-arm-patch-99571' into 'master' 
Text edits in reference.rst

See merge request isc-projects/bind9!3569
 2020-06-01 07:32:40 +00:00
Suzanne Goldlust
1e067c4d0b Grammar, clarity, and content fixes in reference.rst 
Also converted logging-categories.rst from a table to text and adjusted
the util/check-categories.sh script.
 2020-06-01 09:21:38 +02:00
Suzanne Goldlust
c7264db658 Text, grammar, typo, and clarity edits in multiple ARM chapters 
Files requirements.rst, configuration.rs, plugins.rst, and partially
reference.rst has been edited.
 2020-06-01 09:09:34 +02:00
Ondřej Surý
b3931bfaa3 Merge branch '1888-text-edits-in-catz-rst' into 'master' 
Resolve "Text edits in catz.rst"

Closes #1888

See merge request isc-projects/bind9!3596
 2020-06-01 07:02:44 +00:00
Suzanne Goldlust
19ff2e2a79 Content and grammar edits to catz.rst 2020-06-01 07:02:44 +00:00
Ondřej Surý
5337e2e1f7 Merge branch '1894-edits-to-contributing-md' into 'master' 
Resolve "Edits to CONTRIBUTING.md"

Closes #1894

See merge request isc-projects/bind9!3603
 2020-06-01 07:01:16 +00:00
Suzanne Goldlust
58c61b6e7b Content updates to CONTRIBUTING.md 2020-06-01 07:01:15 +00:00
Mark Andrews
1e08a53932 Merge branch '1898-rst-files-should-be-independent-of-configure-option' into 'master' 
Resolve "'.rst' files should be independent of configure option."

Closes #1898

See merge request isc-projects/bind9!3604
 2020-06-01 04:51:42 +00:00
Mark Andrews
52dc7fd89d remove ' // not configured' comment when generating options.active 2020-06-01 12:06:42 +10:00
Evan Hunt
4b91732c09 Merge branch '1857-assertion-failure-insist-nlabels-name-labels' into 'master' 
Resolve "assertion failure in 9.16.2: name.c:1738: INSIST(nlabels == name->labels)"

Closes #1857

See merge request isc-projects/bind9!3577
 2020-05-29 21:50:17 +00:00
Evan Hunt
6ebab27567 CHANGES, release note 2020-05-29 14:22:37 -07:00
Mark Andrews
eded3efb79 Ensure tree lock is always held when dns_rbt_fullnamefromnode is called 2020-05-29 14:17:39 -07:00
Evan Hunt
db9d10e3c1 pass the nodename to add32() instead of calling dns_rbt_fullnamefromnode() 
in addition to being more efficient, this prevents a possible crash by
looking up the node name before the tree sructure can be changed when
cleaning up dead nodes in addrdataset().
 2020-05-29 14:17:36 -07:00
Ondřej Surý
f027763d3a Merge branch 'wpk/fix-leaking-mutexes-and-conditionals' into 'master' 
Add missing isc_mutex_destroy and isc_conditional_destroy calls.

Closes #1893

See merge request isc-projects/bind9!3600
 2020-05-29 19:47:26 +00:00
Witold Kręcicki
4ae2a74873 CHANGES and release notes 2020-05-29 19:18:58 +00:00
Witold Kręcicki
7ef756f639 Clear sock->magic to 0 when destroying a netmgr socket 2020-05-29 19:18:58 +00:00
Witold Kręcicki
a8807d9a7b Add missing isc_mutex_destroy and isc_conditional_destroy calls. 
While harmless on Linux, missing isc_{mutex,conditional}_destroy
causes a memory leak on *BSD. Missing calls were added.
 2020-05-29 19:18:58 +00:00
Ondřej Surý
146748f5c6 Merge branch 'feature/rndc-confgen-quiet' into 'master' 
Make possible not printing written path

See merge request isc-projects/bind9!3578
 2020-05-29 13:59:42 +00:00
Petr Menšík
4748202fac Make possible not printing written path 
Changes written path from stderr to stdout if enabled.
Adds -q parameter to hide written path.
 2020-05-29 13:22:13 +00:00
Ondřej Surý
a746166f7a Merge branch '1872-text-edits-in-advanced-rst' into 'master' 
Resolve "Text edits in advanced.rst"

Closes #1872

See merge request isc-projects/bind9!3580
 2020-05-29 13:21:46 +00:00
Suzanne Goldlust
a0f2dceb02 Oops, missed one text edit. 2020-05-29 13:20:28 +00:00
Suzanne Goldlust
087c4c3b9e Various text edits to advanced.rst 2020-05-29 13:20:28 +00:00
Ondřej Surý
eb13bd8ece Merge branch '1825-improperly-formatted-commands-in-bind-arm' into 'master' 
Resolve "Improperly formatted commands in BIND ARM"

Closes #1825

See merge request isc-projects/bind9!3579
 2020-05-29 13:20:09 +00:00
Suzanne Goldlust
047680d53b Fix incorrect command formatting 2020-05-29 13:19:41 +00:00
Ondřej Surý
1c7f63b300 Merge branch '1881-text-edits-in-dnssec-rst' into 'master' 
Resolve "Text edits in dnssec.rst"

Closes #1881

See merge request isc-projects/bind9!3589
 2020-05-29 13:15:24 +00:00
Suzanne Goldlust
5d3ef17ac8 Content and grammar edits to dnssec.rst 2020-05-29 13:14:36 +00:00
Ondřej Surý
45b3afc8d7 Merge branch '1882-text-edits-in-managed-keys-rst' into 'master' 
Resolve "Text edits in managed-keys.rst"

Closes #1882

See merge request isc-projects/bind9!3590
 2020-05-29 13:11:20 +00:00
Suzanne Goldlust
c269c061ee Content and grammar changes to managed-keys.rst 2020-05-29 13:10:43 +00:00
Ondřej Surý
0999d84f57 Merge branch '1886-text-edits-in-dlz-rst' into 'master' 
Resolve "Text edits in dlz.rst"

Closes #1886

See merge request isc-projects/bind9!3594
 2020-05-29 13:02:18 +00:00
Suzanne Goldlust
5d6c93aed7 Content and grammar updates to dlz.rst 2020-05-29 13:01:33 +00:00
Ondřej Surý
d57200f2ab Merge branch '1887-text-edits-in-dyndb-rst' into 'master' 
Resolve "Text edits in dyndb.rst"

Closes #1887

See merge request isc-projects/bind9!3595
 2020-05-29 13:00:10 +00:00
Suzanne Goldlust
18129808f7 Content and grammar updates to dyndb.rst 2020-05-29 12:59:39 +00:00
Ondřej Surý
25c675a9de Merge branch '1774-fix-windows-build' into 'master' 
Get Windows builds working again

Closes #1774

See merge request isc-projects/bind9!3571
 2020-05-29 12:31:22 +00:00
Ondřej Surý
bf60e445ed Stop using AC_C_FLEXIBLE_ARRAY_MEMBER, support for it is part of C99 2020-05-28 11:28:44 +02:00
Ondřej Surý
fe04426778 Define WIN32_LEAN_AND_MEAN globally instead of anecdotically 2020-05-28 11:28:44 +02:00
Ondřej Surý
7208c94ee3 Use forward slashes instead of backslashes as directory separator on Windows 2020-05-28 11:28:44 +02:00
Ondřej Surý
d179d12686 Cleanup the shell scripts used to run tests on Windows 2020-05-28 11:28:44 +02:00
Ondřej Surý
54a049d94f Add support for replacing {,top_,abs_}{srcdir,builddir} from win32util/Configure 2020-05-28 08:08:38 +02:00
Ondřej Surý
0ce7ded9f9 Add xsl.c generation to vcxproj files for named build 2020-05-28 08:08:38 +02:00
Ondřej Surý
1a870e054d Set the PACKAGE_BUILDER to include _MSC_VER 2020-05-28 08:08:38 +02:00
Ondřej Surý
4c23724c97 Move the dependencies from sln to vcxproj files 2020-05-28 08:08:30 +02:00
Ondřej Surý
5dcef1c53e Fix the makejournal.vcxproj file 2020-05-28 08:07:57 +02:00