Commit Graph
27220 Commits
Author SHA1 Message Date
Mark Andrews 4dc0d7eadd fixup
(cherry picked from commit ba0e5ffc09)
2018-11-13 07:50:11 +11:00
Mark Andrews 433f77a5ef link in lib/isccc/tests/Kyuafile
(cherry picked from commit 9a59352b4c)
2018-11-13 07:49:11 +11:00
Mark Andrews e4831a81ba Merge branch 'backport-require-cmocka-greater-than-or-equal-1.0.0' into 'v9_12'
require cmocka >= 1.0.0

See merge request isc-projects/bind9!1023
2018-11-12 02:41:22 -05:00
Mark Andrews 1e8cdc20f3 define CMOCKA_CFLAGS and CMOCKA_LIBS 2018-11-12 18:31:02 +11:00
Mark Andrews f3ff5f63ac require cmocka >= 1.0.0 2018-11-12 18:00:55 +11:00
Mark Andrews 76960ad3ae Merge branch '351-fix-with-cmocka=path-build-v9_12' into 'v9_12'
Resolve "configure fails unless --enable-developer is specified"

See merge request isc-projects/bind9!1020
2018-11-12 01:34:07 -05:00
Ondřej SurýandMark Andrews 28a6c9e2a5 Use cmocka_set_message_output as test function for cmocka presence
(cherry picked from commit 0158c1a4ea)
2018-11-12 17:25:13 +11:00
Mark Andrews 4e002e9e02 Merge branch '351-disable-cmocka-by-default-v9_12' into 'v9_12'
Resolve "configure fails unless --enable-developer is specified"

See merge request isc-projects/bind9!1019
2018-11-12 00:12:41 -05:00
Ondřej SurýandMark Andrews a765151465 Set with_cmocka=no by default
(cherry picked from commit ed8000f333)
2018-11-12 00:01:55 -05:00
Mark Andrews fef2f618f7 Merge branch '676-isc_result_toid-tables-not-complete-v9_12' into 'v9_12'
Resolve "isc_result_toid tables not complete"

See merge request isc-projects/bind9!1016
2018-11-11 23:20:16 -05:00
Evan HuntandMark Andrews 0a2706b288 convert result tests to use CMocka instead of ATF
(cherry picked from commit 471110933a)
2018-11-12 15:10:52 +11:00
Mark Andrews 3bc66aa712 check result tables are complete
(cherry picked from commit 4f04a79250)
2018-11-12 15:09:37 +11:00
Mark Andrews 39fe368c4f Merge branch '250-integrate-cmocka-into-our-build-scripts-v9_12' into 'v9_12'
Add cmocka support to infrastructure (build) files

See merge request isc-projects/bind9!1014
2018-11-11 20:40:27 -05:00
Ondřej SurýandMark Andrews 3223b1b540 Add support for cmocka assert testing by overriding REQUIRE/INSIST/... macros when UNIT_TESTING is defined
(cherry picked from commit 52731c000d)
2018-11-12 12:31:45 +11:00
Ondřej SurýandMark Andrews f2243e5f18 Add --wrap linker option detection
(cherry picked from commit 10535d1c79)
2018-11-12 12:22:37 +11:00
Ondřej SurýandMark Andrews f28f971eca Enforce TAP output from cmocka based unit tests
(cherry picked from commit bd2ddec58f)
2018-11-12 12:22:37 +11:00
Ondřej SurýandMark Andrews 3b2f9ceec6 Integrate cmocka unit testing framework to kyua
(cherry picked from commit 07910f0153)
2018-11-12 12:22:33 +11:00
Mark Andrews a9c162d2e5 Merge branch '186-bind-9-12-x-potential-bug-with-dig-when-tools-installed-on-windows-v9_12' into 'v9_12'
Resolve "Bind 9.12.x: Potential bug with Dig when Tools installed on Windows"

See merge request isc-projects/bind9!1009
2018-11-09 00:47:47 -05:00
Mark Andrews 990743181b add CHANGES note
(cherry picked from commit 4f7deb348b)
2018-11-09 16:26:43 +11:00
Mark Andrews 4cc245abdc look in windows registry for nameservers, domainname and search list
(cherry picked from commit 6ead8c7be8)
2018-11-09 16:22:52 +11:00
Mark Andrews 2266b6e0fa Merge branch '673-fix-windows-build-resource-discover-v9_12' into 'v9_12'
Resolve "fix windows build resource discover"

See merge request isc-projects/bind9!1006
2018-11-08 20:51:23 -05:00
Mark Andrews 818e6822c4 isc_resource_getlimit under windows only supports isc_resource_openfiles
(cherry picked from commit 896fb585b3)
2018-11-09 12:42:33 +11:00
Ondřej Surý 63f620ed43 Merge branch '451-fix-atomic-int-lock-free-usage-v9_12' into 'v9_12'
Properly use ATOMIC_*_LOCK_FREE preprocessor constants

See merge request isc-projects/bind9!997
2018-11-08 16:54:15 -05:00
Ondřej Surý a5e7901eb9 Properly use ATOMIC_*_LOCK_FREE preprocessor constants
The ATOMIC_*_LOCK_FREE can evalutate either 0, 1, or 2 which indicate the
lock-free property of the corresponding atomic types (both signed and unsigned).

	Value	Explanation
	-----	--------------------------------------
	  0	The atomic type is never lock-free
	  1	The atomic type is sometimes lock-free
	  2	The atomic type is always lock-free
	-----	--------------------------------------
2018-11-09 04:50:50 +07:00
Ondřej Surý f914cd93b8 Merge branch '449-isc_stdtime_t-post-stdint-cleanup-v9_12' into 'v9_12'
(v9_12) Resolve "Follow-up from "Redefine ISC's int and boolean types to use <stdint.h> and <stdbool.h> types""

See merge request isc-projects/bind9!1001
2018-11-08 15:07:20 -05:00
Ondřej Surý 956d1bda02 isc_stdtime_t is always 32-bit now, so remove the always true macro STDTIME_ON_32BITS
(cherry picked from commit 6f5fe11f5a)
2018-11-09 02:56:49 +07:00
Ondřej Surý 15a4f74b28 Print isc_stdtime_t with PRIu32
(cherry picked from commit c355e1f38f)
2018-11-09 02:56:48 +07:00
Ondřej Surý 7b083a4958 Merge branch '224-remove-isc-hmax-fixup-exe-bnff-from-win32utils-configure-v9_12' into 'v9_12'
Remove isc-hmac-fixup.exe remains from win32util/Configure

See merge request isc-projects/bind9!999
2018-11-08 13:58:51 -05:00
Ondřej Surý fe4b48b694 Remove isc-hmac-fixup.exe remains from win32util/Configure 2018-11-09 01:50:22 +07:00
Ondřej Surý a0a6fc8b85 Merge branch '656-add-support-for-utimaco-hsm-v9_11-v9_12' into 'v9_12'
(v9_12) Resolve "Add support for Utimaco HSM"

See merge request isc-projects/bind9!996
2018-11-08 12:44:08 -05:00
Ondřej Surý 039cef9235 Add CHANGES entry for GL #656
(cherry picked from commit ebe63fd316)
2018-11-09 00:35:05 +07:00
Ondřej Surý 8ffcef8435 Disable runtime detection of md5 and sha1 support for Utimaco HSM.
Utimaco HSM requires user to be logged in before executing DigestUpdate, thus
breaking dst_lib_init2 that ran isc_md5_check and isc_sha1_check before sending
PIN to the HSM.  Therefore isc_*_check needs to be disabled when Utimaco HSM is
being used as PKCS#11 library.

(cherry picked from commit 52784fc3cc)
2018-11-09 00:35:05 +07:00
Ondřej Surý 6610da90d1 Define PK11_UTIMACO_FLAVOR and add detection code to configure.ac
(cherry picked from commit 2079e44fb9)
2018-11-09 00:35:05 +07:00
Ondřej Surý 12a2b25612 Merge branch '305-misc-fixes-v9_12' into 'v9_12'
(v9_12) Miscellaneous style fixes - implicit casts to bool and uninitialized variables fixes

See merge request isc-projects/bind9!993
2018-11-08 09:33:51 -05:00
Ondřej Surý 03c7bb9ab3 Disable Ed448 algorithm, the implementation in BIND 9 is incomplete and broken 2018-11-08 19:53:05 +07:00
Ondřej Surý bc7a1b00e9 fixup! Hint the compiler with ISC_UNREACHABLE(); that code after INSIST(0); cannot be reached 2018-11-08 19:45:37 +07:00
Ondřej Surý 5ad72603a8 Remove dummy ISLOCKED macro
(cherry picked from commit 68ca987792)
2018-11-08 15:09:12 +07:00
Ondřej Surý 4568669807 Hint the compiler with ISC_UNREACHABLE(); that code after INSIST(0); cannot be reached
(cherry picked from commit 23fff6c569)
2018-11-08 15:09:12 +07:00
Ondřej Surý ce6ef5b50e Modify the dbversion_test.c to detect disabled assertions
(cherry picked from commit b992b5b811)
2018-11-08 14:37:14 +07:00
Ondřej Surý 2a26189256 Add extra return failure after INSIST(0) in default branch
(cherry picked from commit 29c45200e7)
2018-11-08 14:37:14 +07:00
Ondřej Surý 65536fb10b Use larger buffers on snprintf buffer overflow false positives
(cherry picked from commit 4eaf927571)
2018-11-08 14:37:14 +07:00
Ondřej Surý 1e6329038b Don't assert on failed getrlimit call to allow called to handle this gracefully as it already does, just abort where we need to know the numbers
(cherry picked from commit e2e138a801)
2018-11-08 14:37:14 +07:00
Ondřej Surý 3d834566f1 When ISC assertions are disabled, still execute the condition to prevent unused variable warnings/errors from the compiler
(cherry picked from commit a831e0f72d)
2018-11-08 14:37:14 +07:00
Ondřej Surý c5825eba40 Add a GitLab CI job that runs with all assertions disabled
(cherry picked from commit 461ffead1f)
2018-11-08 14:37:14 +07:00
Ondřej Surý fcd1569e2b Turn (int & flag) into (int & flag) != 0 when implicitly typed to bool
(cherry picked from commit b2b43fd235)
2018-11-08 14:37:14 +07:00
Ondřej Surý b222783ae9 Add small tweaks to the code to fix compilation when ISC assertions are disabled
While implementing the new unit testing framework cmocka, it was found that the
BIND 9 code doesn't compile when assertions are disabled or replaced with any
function (such as mock_assert() from cmocka unit testing framework) that's not
directly recognized as assertion by the compiler.

This made the compiler to complain about blocks of code that was recognized as
unreachable before, but now it isn't.

The changes in this commit include:

* assigns default values to couple of local variables,
* moves some return statements around INSIST assertions,
* adds __builtin_unreachable(); annotations after some INSIST assertions,
* fixes one broken assertion (= instead of ==)

(cherry picked from commit fbd2e47f51)
2018-11-08 14:05:23 +07:00
Mark Andrews f8620738e5 Merge branch 'wpk-get-rid-of-bashism-in-CDS-test-v9_12' into 'v9_12'
Small system tests fixes for Solaris

See merge request isc-projects/bind9!991
2018-11-07 20:32:50 -05:00
Witold KrecickiandMark Andrews 070e4135c4 Remove unnecessary sed from autosign test
(cherry picked from commit 82dfb77328)
2018-11-08 12:19:57 +11:00
Witold KrecickiandMark Andrews f49bd1e77f Use 'local' variable in echo functions in tests
(cherry picked from commit 0949b1fe2c)
2018-11-08 12:19:51 +11:00
Witold KręcickiandMark Andrews 5d4074c4e4 Get rid of bashism in CDS test
(cherry picked from commit dbf2e7928e)
2018-11-08 12:14:31 +11:00