"./rdata/generic/loc_29.c", line ??: remark(1506): implicit conversion from
"unsigned long" to "int": rounding, sign extension, or loss of
accuracy may result
by making sure that the range was suitable for an int and casting to
int in each case. (This appeared to be more desirable than changing
all of the variables in question to longs.)
"./rdata/generic/mx_15.c", line 202: warning(1184): possible use of "=" where
"==" was intended
by changing to == since it was clear that test was desired, not assignment.
"./rdata/in_1/a_1.c", line 178: warning(1184): possible use of "=" where "=="
was intended
"./rdata/in_1/a_1.c", line 179: warning(1184): possible use of "=" where "=="
was intended
By chaning them to ==, because (a) we don't allow side-effects in REQUIRE()
and (b) it is clear from the rest of the code that it really was a test that
was desired and not an assignment.
"rbtdb.c", line 1579: remark(1552): parameter "now" was set but never used
"rbtdb.c", line 2888: remark(1552): parameter "version" was set but never used
by using UNUSED() rather than setting variables to unused values.
"journal.c", line 169: remark(1552): variable "zoneclass" was set but never
used
by removing zoneclass declaration and zoneclass = dns_db_class(db) from
dns_db_createsoatuple.
"adb.c", line 2042: remark(1552): variable "result" was set but never used
isc_result_t result;
^
"adb.c", line 3082: warning(1185): enumerated type mixed with another type
NAME_GLUEOK(adbname), NAME_HINTOK(adbname),
^
"adb.c", line 3187: warning(1185): enumerated type mixed with another type
now, NAME_GLUEOK(adbname), NAME_HINTOK(adbname),
Note that the first is in timer_cleanup, a function returning void in a context
that can't do anything with something other than void (as an isc_taskaction_t).
It calls isc_timer_reset, which could conceivably return ISC_R_NOMEMORY or
ISC_R_UNEXPECTED. For now the call has been cast to void, but someone
who knows the code better should have a look and see whether something more
intelligent could be done with an error (and, if not, remove my XXX and
make sure the comment is clear as to why ignoring the return is the
best that can be done).
"confzone.c", line 445: remark(1552): variable "res" was set but never used
Made *_zone_init functions return void since they all always returned
ISC_R_SUCCESS.
"bsafe_link.c", line 116: remark(1692): prototyped function redeclared without
prototype
dst_s_bsafersa_init() {
and several variations of:
"bsafe_link.c", line 155: remark(1552): variable "status" was set but never
used
int status = 0;
along with style lint (notably bitwise operands used as truth values:
mode & DST_SIGMODE_INIT versus (mode & DST_SIGMODE_INIT) != 0.
the CPP symbol it uses from *_HAVENETINET6* to *_NEEDNETINET6* to better
clarify what's going on with regard to the symbol.
Moved processing of --with-kame to before the in6addr_any check, since
it needs to set LIBS for the check to work. [related to RT #105, and
previous configure.in revision 1.108.]
in6_pkinfo check only needs AC_TRY_COMPILE, not AC_TRY_LINK.
library if it is available; therefore the --with-mit-pthreads
option is no longer needed. The --with-ptl2 option is now documented
as being experimental and applying to NetBSD only.
library if it is available; therefore the --with-mit-pthreads
option is no longer needed. The --with-ptl2 option is now documented
as being experimental and applying to NetBSD only.
command a bit more obvious.
Addition of TCP fallback on UDP failure. Will add option to disable this.
Further work on nslookup.
(nslookup is not built by default now, and is far from fully functional.
Interactive mode currently segfaults.)
allow-query ACL, subsequent accesses to the same zone were denied because
dbversion->queryok was not being set. This caused mandatory glue to be
omitted from referral responses, ultimately causing lookups to fail if all
authoritative servers for the parent zone were running bind9.
170. [cleanup] Remove inter server consistancy checks from zone,
these should return as a seperate module in 9.1.
dns_zone_checkservers(), dns_zone_checkparents(),
dns_zone_checkchildren(), dns_zone_checkglue().
Remove dns_zone_setadb(), dns_zone_setresolver(),
dns_zone_setrequestmgr() these should now be found
via the view.
David Lawrence
Michael Graff
Mark Andrews