Commit Graph
38427 Commits
Author SHA1 Message Date
Mark AndrewsandMichał Kępień 349d9d3fee Add release note for [GL #4281]
(cherry picked from commit 2fbafc2675)
2024-01-05 12:03:59 +01:00
Mark AndrewsandMichał Kępień 121473e8b5 Add CHANGES note for [GL #4281]
(cherry picked from commit 0748965b7c)
2024-01-05 12:03:59 +01:00
Mark AndrewsandMichał Kępień b42b1fe051 Save the correct result value to resume with nxdomain-redirect
The wrong result value was being saved for resumption with
nxdomain-redirect when performing the fetch.  This lead to an assert
when checking that RFC 1918 reverse queries where not leaking to
the global internet.

(cherry picked from commit 9d0fa07c5e)
2024-01-05 12:03:59 +01:00
Michał Kępień 7f39a9888b Merge branch '4234-confidential-use-hashmap-when-parsing-9.18' into 'v9.18.22-release'
[9.18] [CVE-2023-4408] Use hashtable when parsing DNS messages

See merge request isc-private/bind9!585
2024-01-05 10:58:01 +00:00
Ondřej SurýandMichał Kępień 968d0a1415 Add CHANGES and release note for [GL #4234]
(cherry picked from commit 30d27928cf)
2024-01-05 11:50:23 +01:00
Ondřej SurýandMichał Kępień 849c05adf4 Use hashtable when parsing a message
When parsing messages use a hashtable instead of a linear search to
reduce the amount of work done in findname when there's more than one
name in the section.

There are two hashtables:

1) hashtable for owner names - that's constructed for each section when
we hit the second name in the section and destroyed right after parsing
that section;

2) per-name hashtable - for each name in the section, we construct a new
hashtable for that name if there are more than one rdataset for that
particular name.

(cherry picked from commit b8a9631754)
2024-01-05 11:50:23 +01:00
Michał Kępień 346b26823c Merge branch '4182-confidential-fix-races-in-dns-tsigkey-find-9.18' into 'v9.18.22-release'
[9.18] Address race in dns_tsigkey_find()

See merge request isc-private/bind9!622
2024-01-05 10:30:14 +00:00
Mark AndrewsandMichał Kępień 0a8367e17b Add CHANGES note for [GL #4182]
(cherry picked from commit a62cda787f)
2024-01-05 11:19:58 +01:00
Mark AndrewsandMichał Kępień f46a81932f Address race in dns_tsigkey_find()
Restart the process with a write lock if we discover an expired key
while holding the read lock.

(cherry picked from commit d2ba96488e)
2024-01-05 11:19:58 +01:00
Aydın Mercan 75677d375e Merge branch '4467-fix-stats-export-overflow-v9_18' into 'bind-9.18'
[9.18] Avoid overflow during statistics dump

See merge request isc-projects/bind9!8574
2024-01-03 18:20:17 +00:00
Aydın Mercan a83c749115 Use <isc/atomic.h> instead of <stdatomic.h> directly in <isc/types.h> 2024-01-03 20:36:35 +03:00
Aydın Mercan 6c0ae4ef6e Move atomic statscounter next to the non-atomic definition
(cherry picked from commit 9c4dd863a6)
2024-01-03 20:36:35 +03:00
Aydın Mercan 9601763943 Use a non-atomic counter when passing to stats dumper
(cherry picked from commit bb96142a17)
2024-01-03 20:36:35 +03:00
Petr ŠpačekandAydın Mercan b913d44ce6 Add CHANGES and release note for [GL #4467]
(cherry picked from commit b57c37d8c5)
2024-01-03 20:36:27 +03:00
Petr ŠpačekandAydın Mercan d33b0f9ddb Avoid overflow during statistics dump
Related: !1493
Fixes: #4467
(cherry picked from commit 7b0115e331)
2024-01-03 20:10:27 +03:00
Mark Andrews 0c49507b1b Merge branch '4513-system-tests-fail-with-net-dns-1-42-bind-9.18' into 'bind-9.18'
[9.18] Resolve "System tests fail with Net::DNS 1.42"

See merge request isc-projects/bind9!8618
2024-01-03 02:24:43 +00:00
Mark Andrews b831223b3e Support Net::DNS::Nameserver 1.42
In Net::DNS 1.42 $ns->main_loop no longer loops.  Use current methods
for starting the server, wait for SIGTERM then cleanup child processes
using $ns->stop_server(), then remove the pid file.

(cherry picked from commit c2c59dea60)
2024-01-03 11:57:59 +11:00
Mark Andrews 8f4e5f51fd Merge branch '4495-conversion-from-nsec3-to-nsec-removes-the-nsec3param-too-early-bind-9.18' into 'bind-9.18'
[9.18] Resolve "Conversion from NSEC3 to NSEC removes the NSEC3PARAM too early" !8578

See merge request isc-projects/bind9!8610
2024-01-03 00:04:53 +00:00
Mark Andrews 1a52dccd32 Handle multiple NSEC3PARAM records in tests
When transitioning from one NSEC3 chain to another it is legal for
there to be multiple complete chains in the zone with multiple
NSEC3PARAM records.  Handle this intermediate state by checking
for the expected length in the loop.
2024-01-03 09:25:43 +11:00
Mark Andrews d5aa22ec74 Add CHANGES for [GL #1794] and [GL #4459]
(cherry picked from commit 9b5ed853d0)
2024-01-03 09:25:43 +11:00
Matthijs MekkingandMark Andrews b9fc29cb95 Regression check for NSEC3 to NSEC3 conversion
When changing the NSEC3 chain, the new NSEC3 chain must be built before
the old NSEC3PARAM is removed.  Check each delta in the conversion to
ensure this ordering is met.

(cherry picked from commit 1d6b892e04)
2024-01-03 09:25:43 +11:00
Mark Andrews 7e24befc2a Regression check for NSEC3 to NSEC conversion
When transitioning from NSEC3 to NSEC the NSEC3 must be built before
the NSEC3PARAM is removed.  Check each delta in the conversion to
ensure this ordering is met.

(cherry picked from commit 7d90c056b0)
2024-01-03 09:25:43 +11:00
Mark Andrews d78df5f96d Don't delete the NSEC3PARAM immediately
Wait until the new NSEC or NSEC3 chain is generated then it should
be deleted.

(cherry picked from commit f3ae88d84e)
2023-12-21 22:07:53 +11:00
Tom Krizek 52770b05d3 Merge branch 'tkrizek/update-sphinx_rtd_theme-9.18' into 'bind-9.18'
[9.18] Update sphinx_rtd_theme and docutils

See merge request isc-projects/bind9!8604
2023-12-21 10:08:50 +00:00
Tom Krizek 916b121e42 Update sphinx_rtd_theme and docutils
(cherry picked from commit 4156fa09d9)
2023-12-21 10:33:26 +01:00
Mark Andrews b072bf612f Merge branch '4488-memory-reference-leak-in-lib-dns-zone-c-zone_sign-bind-9.18' into 'bind-9.18'
[9.18] Resolve "Memory/reference leak in lib/dns/zone.c:zone_sign" !8570

See merge request isc-projects/bind9!8607
2023-12-20 23:48:28 +00:00
Mark Andrews 7b10f5f154 Add CHANGES note for [GL #4488]
(cherry picked from commit 4e4200ee2e)
2023-12-21 10:06:29 +11:00
Mark Andrews 0ceb01386c Don't look for KSK status here and squash memory leak
Just remove the key from  consideration as it is being removed.

The old code could leak a key reference as dst_free_key was not
called every time we continued. This simplification will address
this as well.

(cherry picked from commit a3d0476d17)
2023-12-21 10:05:54 +11:00
Tom Krizek b04849c46a Merge tag 'v9.18.21' into bind-9.18 2023-12-20 16:07:25 +01:00
Mark Andrews 8f34392979 Merge branch '4498-gl-4495-followup-regression-test-was-too-strict-bind-9.18' into 'bind-9.18'
[9.18] Resolve "[GL #4494] followup: regression test was too strict"

See merge request isc-projects/bind9!8598
2023-12-20 00:46:40 +00:00
Mark Andrews 38babba214 The NSEC3 -> NSEC private record may be added later
Check each delta for the NSEC3 -> NSEC private record addition
as it may be added in the second delta.

(cherry picked from commit 80a4dff986)
2023-12-20 11:11:12 +11:00
Mark Andrews a26693e987 Merge branch '4500-log-the-change-that-generated-not-exact-when-applying-a-diff-bind-9.18' into 'bind-9.18'
[9.18] Resolve "Log the change that generated "not exact" when applying a diff."

See merge request isc-projects/bind9!8596
2023-12-19 22:04:20 +00:00
Mark Andrews 39f2fe0c7a Add CHANGES entry for [GL #4500]
(cherry picked from commit 71d67b6fdf)
2023-12-20 02:48:13 +11:00
Mark Andrews a2bcd4fc0e Log what change generated a 'not exact' error
(cherry picked from commit c896e07277)
2023-12-20 02:47:42 +11:00
Mark Andrews c5fee06ff9 Merge branch '4494-add_sigs-was-using-the-wrong-time-in-kasp-mode-bind-9.18' into 'bind-9.18'
[9.18] Resolve "add_sigs was using the wrong time in kasp mode"

See merge request isc-projects/bind9!8588
2023-12-19 02:27:53 +00:00
Mark Andrews 74d61641e1 Add CHANGES note for [GL #4494]
(cherry picked from commit 94b00f44ae)
2023-12-19 12:44:49 +11:00
Mark Andrews 15601cca43 Regression check for missing RRSIGs
When transitioning from NSEC3 to NSEC the added records where not
being signed because the wrong time was being used to determine if
a key should be used or not.  Check that these records are actually
signed.

(cherry picked from commit bdb42d3838)
2023-12-19 12:44:27 +11:00
Mark Andrews 65fdc892eb Use 'now' rather than 'inception' in 'add_sigs'
When kasp support was added 'inception' was used as a proxy for
'now' and resulted in signatures not being generated or the wrong
signatures being generated.  'inception' is the time to be set
in the signatures being generated and is usually in the past to
allow for clock skew.  'now' determines what keys are to be used
for signing.

(cherry picked from commit 6066e41948)
2023-12-19 12:39:16 +11:00
Michał Kępień 3713d6c909 Merge branch '4497-trust-anchor-telemetry-is-no-longer-experimental-9.18' into 'bind-9.18'
[9.18] "trust-anchor-telemetry" is no longer experimental

See merge request isc-projects/bind9!8587
2023-12-18 14:50:16 +00:00
Michał Kępień 6961509039 Add CHANGES entry for GL #4497
(cherry picked from commit 693fee4836)
2023-12-18 15:13:34 +01:00
Michał Kępień 8882d88731 "trust-anchor-telemetry" is no longer experimental
Remove the CFG_CLAUSEFLAG_EXPERIMENTAL flag from the
"trust-anchor-telemetry" statement as the behavior of the latter has not
been changed since its initial implementation and there are currently no
plans to do so.  This silences a relevant log message that was emitted
even when the feature was explicitly disabled.

(cherry picked from commit b1baf7af3a)
2023-12-18 15:13:34 +01:00
Arаm Sаrgsyаn 8f9c0eb284 Merge branch '4477-tests-statschannel-loadtime-bugfix-9.18' into 'bind-9.18'
[9.18] Resolve "statschannel test intermittently fails with incorrect zone loadtime"

See merge request isc-projects/bind9!8583
2023-12-18 10:24:49 +00:00
Aram Sargsyan ba923834b2 Fix a statschannel system test zone loadtime issue
The check_loaded() function compares the zone's loadtime value and
an expected loadtime value, which is based on the zone file's mtime
extracted from the filesystem.

For the secondary zones there may be cases, when the zone file isn't
ready yet before the zone transfer is complete and the zone file is
dumped to the disk, so a so zero value mtime is retrieved.

In such cases wait one second and retry until timeout. Also modify
the affected check to allow a possible difference of the same amount
of seconds as the chosen timeout value.

(cherry picked from commit 4e94ff2541)
2023-12-18 09:34:31 +00:00
Mark Andrews 418a1ad762 Merge branch '4478-redefinition-of-hmac-as-different-kind-of-symbol-on-netbsd-bind-9.18' into 'bind-9.18'
[9.18] Resolve "Redefinition of 'hmac' as different kind of symbol on NetBSD"

See merge request isc-projects/bind9!8573
2023-12-14 01:29:27 +00:00
Mark Andrews c705fee830 Add CHANGES note for [GL #4478]
(cherry picked from commit 648fa635f8)
2023-12-14 11:14:04 +11:00
Mark Andrews adfb365602 NetBSD has added 'hmac' to libc so rename our uses of hmac
(cherry picked from commit fd077c2661)
2023-12-14 11:14:04 +11:00
Michal Nowak c54c268c4c Merge branch 'mnowak/alpine-3.19-9.18' into 'bind-9.18'
[9.18] Add Alpine Linux 3.19

See merge request isc-projects/bind9!8566
2023-12-12 10:42:39 +00:00
Michal Nowak 3b603d0fe5 Add Alpine Linux 3.19
(cherry picked from commit 1fc56d705e)
2023-12-12 11:12:15 +01:00
Michal Nowak 07f6d1e67f Merge branch 'mnowak/replace-danger-python-with-hazard-9.18' into 'bind-9.18'
[9.18] Replace danger-python with Hazard

See merge request isc-projects/bind9!8563
2023-12-11 17:23:57 +00:00
Tom KrizekandMichal Nowak e97f4c0784 Handle empty MR description in dangerfile
A merge request might have no description at all (i.e. None, rather than
an empty string). This might happen when the MR is created via an API.
Check a description is present before trying to find a backport string
in it.

(cherry picked from commit 4f70f5bd7c)
2023-12-11 17:45:31 +01:00