Commit Graph
27250 Commits
Author SHA1 Message Date
Tony FinchandMark Andrews 2d7969e0a4 dig: a -r option to disable .digrc
(cherry picked from commit fdb74fed9e)
2018-11-15 12:59:29 +11:00
Evan Hunt e322c3ab4a Merge branch '347-various-bind-9-bugs-in-cleanup-after-fail-scenarios-v9_12' into 'v9_12'
Resolve "Various BIND 9 bugs in cleanup-after-fail scenarios"

See merge request isc-projects/bind9!1058
2018-11-14 19:25:16 -05:00
Mark AndrewsandEvan Hunt 5c47dd82ac uninitalize memory read on error path
(cherry picked from commit 4eadebe2b2)
2018-11-15 00:15:33 +00:00
Mark AndrewsandEvan Hunt 6b409b89cd errors initalizing badcaches were not caught or cleaned up on error paths
(cherry picked from commit 93776c4c81)
2018-11-15 00:15:29 +00:00
Mark Andrews b163281917 Merge branch '688-prefer-kyua-over-aft-run-v9_12' into 'v9_12'
Resolve "prefer kyua over aft-run"

See merge request isc-projects/bind9!1051
2018-11-14 16:05:23 -05:00
Mark Andrews ecf8ede7ea prefer kyua over atf
(cherry picked from commit 590d391bbb)
2018-11-14 15:32:13 -05:00
Evan Hunt 0401840cb1 Merge branch '558-nsupdate-leaks-memory-when-using-gss-tsig-and-receiving-sigterm-at-a-right-time-v9_12' into 'v9_12'
Resolve "nsupdate leaks memory when using GSS-TSIG and receiving SIGTERM at a "right" time"

See merge request isc-projects/bind9!1055
2018-11-14 15:00:55 -05:00
Mark AndrewsandEvan Hunt d7c484ac7a free tmpzonename and restart_master
(cherry picked from commit 50714a9b35)
2018-11-14 11:41:48 -08:00
Evan Hunt d33cc6e985 Merge branch '675-don-t-use-typename-v9_12' into 'v9_12'
Resolve "Don't use 'typename'"

See merge request isc-projects/bind9!1053
2018-11-14 14:17:07 -05:00
Mark AndrewsandEvan Hunt 5f9fde54cc don't use 'typename' as it is reserved in C++ 2018-11-14 11:08:44 -08:00
Mark Andrews 73e9dc7e99 Merge branch '584-dig-treats-4-6-m-after-q-argument-as-an-option-but-not-a-domain-name-v9_12' into 'v9_12'
Resolve "dig treats -4/-6/-m after -q argument as an option but not a domain name"

See merge request isc-projects/bind9!1046
2018-11-13 20:52:34 -05:00
Evan HuntandMark Andrews 1b5f73a25b style
(cherry picked from commit e356d93175)
2018-11-14 11:55:21 +11:00
Mark Andrews ba5726ec2f check that delv -q -m works
(cherry picked from commit 77128c867c)
2018-11-14 11:55:21 +11:00
Mark Andrews b9b8782144 check that dig -q -m works
(cherry picked from commit f6f07fb41e)
2018-11-14 11:55:21 +11:00
Mark Andrews 46d80fe979 add -q to dash_opts
(cherry picked from commit ba5d28dcfe)
2018-11-14 11:55:21 +11:00
Mark Andrews 999163cd77 dig and mdig failed to properly preparse dash value pairs when value was a seperate argument and started with a dash.
(cherry picked from commit 75fa84b67b)
2018-11-14 11:55:20 +11:00
Evan Hunt ac0eff46e7 Merge branch '587-statistics-channels-xml-v2-is-removed-but-still-documented-v9_12' into 'v9_12'
Resolve "statistics-channels /xml/v2 is removed but still documented"

See merge request isc-projects/bind9!1043
2018-11-13 14:09:26 -05:00
Mark AndrewsandEvan Hunt b7d61f8cf7 remove reference to obsolete xml/v2 schema
(cherry picked from commit 9e1af0cef1)
2018-11-13 11:08:39 -08:00
Michał Kępień 53d8c91de3 Merge branch '433-restore-localhost-fallback-in-bin-dig-dighost.c-v9_12' into 'v9_12'
[v9_12] Restore localhost fallback in bin/dig/dighost.c

See merge request isc-projects/bind9!1041
2018-11-13 08:52:45 -05:00
Michał Kępień 127f6c7d06 Add CHANGES entry
5089.	[bug]		Restore localhost fallback in dig and host which is
			used when no nameserver addresses present in
			/etc/resolv.conf are usable due to the requested
			address family restrictions. [GL #433]

(cherry picked from commit 867bc3399b)
2018-11-13 14:32:51 +01:00
Michał Kępień 8181ffefe7 Restore localhost fallback in bin/dig/dighost.c
In BIND 9.11 and earlier, dig and similar tools used liblwres for
parsing /etc/resolv.conf.  After getting a list of servers from
liblwres, a tool would check the address family of each server found and
reject those unusable.  When the resulting list of usable servers was
empty, localhost addresses were queried as a fallback.

When liblwres was removed in BIND 9.12, dig and similar tools were
updated to parse /etc/resolv.conf using libirs instead.  As part of that
process, the localhost fallback was removed from bin/dig/dighost.c since
the localhost fallback built into libirs was deemed to be sufficient.
However, libirs only falls back to localhost if it does not find any
name servers at all; if it does find any valid nameserver entry in
/etc/resolv.conf, it just returns it to the caller because it is
oblivious to whether the caller supports IPv4 and/or IPv6 or not.  The
code in bin/dig/dighost.c subsequently filters the returned list of
servers in get_server_list() according to the requested address family
restrictions.  This may result in none of the addresses returned by
libirs being usable, in which case a tool will attempt to work with an
empty server list, causing a hang and subsequently a crash upon user
interruption.

Restore the localhost fallback in bin/dig/dighost.c to prevent the
aforementioned hangs and crashes and ensure recent BIND versions behave
identically to the older ones in the circumstances described above.

(cherry picked from commit 18758392da)
2018-11-13 14:32:51 +01:00
Michał Kępień 14b8bf9d87 Merge branch '599-fix-a-shutdown-race-in-diagnostic-tools-v9_12' into 'v9_12'
[v9_12] Fix a shutdown race in bin/dig/dighost.c

See merge request isc-projects/bind9!1039
2018-11-13 08:25:13 -05:00
Michał Kępień e206bf8836 Add CHANGES entry
5088.	[bug]		dig/host/nslookup could crash when interrupted close to
			a query timeout. [GL #599]

(cherry picked from commit ae40e8039b)
2018-11-13 13:52:21 +01:00
Michał Kępień 9c963ed606 Fix a shutdown race in bin/dig/dighost.c
If a tool using the routines defined in bin/dig/dighost.c is sent an
interruption signal around the time a connection timeout is scheduled to
fire, connect_timeout() may be executed after destroy_libs() detaches
from the global task (setting 'global_task' to NULL), which results in a
crash upon a UDP retry due to bringup_timer() attempting to create a
timer with 'task' set to NULL.  Fix by preventing connect_timeout() from
attempting a retry when shutdown is in progress.

(cherry picked from commit 4621756596)
2018-11-13 13:52:21 +01:00
Evan Hunt 9186dba02d Merge branch 'fix-rules-typo-v9_12' into 'v9_12'
fix rules.in typo

See merge request isc-projects/bind9!1037
2018-11-13 03:33:57 -05:00
Evan Hunt 4357852699 fix typo
(cherry picked from commit 9671909289)
2018-11-13 00:24:24 -08:00
Mark Andrews 1e871d6904 Merge branch 'autoheader-v9_12' into 'v9_12'
autoheader

See merge request isc-projects/bind9!1032
2018-11-12 18:17:09 -05:00
Mark Andrews 7579f1fb22 autoheader 2018-11-13 10:07:57 +11:00
Mark Andrews dc14cafe7e Merge branch 'fix-test-linkages-v9_12' into 'v9_12'
Fix test linkages

See merge request isc-projects/bind9!1028
2018-11-12 15:58:59 -05:00
Mark Andrews 97a108f00d remove lib/isc/tests/result_test as it is now cmocka
(cherry picked from commit 9024cf0c15)
2018-11-13 07:50:13 +11:00
Mark Andrews 4dc0d7eadd fixup
(cherry picked from commit ba0e5ffc09)
2018-11-13 07:50:11 +11:00
Mark Andrews 433f77a5ef link in lib/isccc/tests/Kyuafile
(cherry picked from commit 9a59352b4c)
2018-11-13 07:49:11 +11:00
Mark Andrews e4831a81ba Merge branch 'backport-require-cmocka-greater-than-or-equal-1.0.0' into 'v9_12'
require cmocka >= 1.0.0

See merge request isc-projects/bind9!1023
2018-11-12 02:41:22 -05:00
Mark Andrews 1e8cdc20f3 define CMOCKA_CFLAGS and CMOCKA_LIBS 2018-11-12 18:31:02 +11:00
Mark Andrews f3ff5f63ac require cmocka >= 1.0.0 2018-11-12 18:00:55 +11:00
Mark Andrews 76960ad3ae Merge branch '351-fix-with-cmocka=path-build-v9_12' into 'v9_12'
Resolve "configure fails unless --enable-developer is specified"

See merge request isc-projects/bind9!1020
2018-11-12 01:34:07 -05:00
Ondřej SurýandMark Andrews 28a6c9e2a5 Use cmocka_set_message_output as test function for cmocka presence
(cherry picked from commit 0158c1a4ea)
2018-11-12 17:25:13 +11:00
Mark Andrews 4e002e9e02 Merge branch '351-disable-cmocka-by-default-v9_12' into 'v9_12'
Resolve "configure fails unless --enable-developer is specified"

See merge request isc-projects/bind9!1019
2018-11-12 00:12:41 -05:00
Ondřej SurýandMark Andrews a765151465 Set with_cmocka=no by default
(cherry picked from commit ed8000f333)
2018-11-12 00:01:55 -05:00
Mark Andrews fef2f618f7 Merge branch '676-isc_result_toid-tables-not-complete-v9_12' into 'v9_12'
Resolve "isc_result_toid tables not complete"

See merge request isc-projects/bind9!1016
2018-11-11 23:20:16 -05:00
Evan HuntandMark Andrews 0a2706b288 convert result tests to use CMocka instead of ATF
(cherry picked from commit 471110933a)
2018-11-12 15:10:52 +11:00
Mark Andrews 3bc66aa712 check result tables are complete
(cherry picked from commit 4f04a79250)
2018-11-12 15:09:37 +11:00
Mark Andrews 39fe368c4f Merge branch '250-integrate-cmocka-into-our-build-scripts-v9_12' into 'v9_12'
Add cmocka support to infrastructure (build) files

See merge request isc-projects/bind9!1014
2018-11-11 20:40:27 -05:00
Ondřej SurýandMark Andrews 3223b1b540 Add support for cmocka assert testing by overriding REQUIRE/INSIST/... macros when UNIT_TESTING is defined
(cherry picked from commit 52731c000d)
2018-11-12 12:31:45 +11:00
Ondřej SurýandMark Andrews f2243e5f18 Add --wrap linker option detection
(cherry picked from commit 10535d1c79)
2018-11-12 12:22:37 +11:00
Ondřej SurýandMark Andrews f28f971eca Enforce TAP output from cmocka based unit tests
(cherry picked from commit bd2ddec58f)
2018-11-12 12:22:37 +11:00
Ondřej SurýandMark Andrews 3b2f9ceec6 Integrate cmocka unit testing framework to kyua
(cherry picked from commit 07910f0153)
2018-11-12 12:22:33 +11:00
Mark Andrews a9c162d2e5 Merge branch '186-bind-9-12-x-potential-bug-with-dig-when-tools-installed-on-windows-v9_12' into 'v9_12'
Resolve "Bind 9.12.x: Potential bug with Dig when Tools installed on Windows"

See merge request isc-projects/bind9!1009
2018-11-09 00:47:47 -05:00
Mark Andrews 990743181b add CHANGES note
(cherry picked from commit 4f7deb348b)
2018-11-09 16:26:43 +11:00
Mark Andrews 4cc245abdc look in windows registry for nameservers, domainname and search list
(cherry picked from commit 6ead8c7be8)
2018-11-09 16:22:52 +11:00