Commit Graph
26236 Commits
Author SHA1 Message Date
Evan Hunt 2a6a2014b4 Alter distclean rule to prevent recursing into the same directory twice
Commit f87e0c03ee removed the "system" directory from the TESTDIRS
variable in bin/tests/Makefile.in in an attempt to fix "make distclean"
which was broken since commit 0d784de16a.  However, this change
prevented any system tests from being run when "make test" is invoked.

We now put it back into both SUBDIRS and TESTDIRS, but with a modified
rule to check for the existence of a Makefile in each subdirectory before
trying to run make there. This prevents "make distclean" from trying to
run again in a directory where it's already been run.

(cherry picked from commit 93ee6b8a22)
2018-04-10 20:04:40 -07:00
Michał KępieńandEvan Hunt 19db5fb1f3 Fail CI pipeline when "make test" does not run any system tests
Apart from ensuring "make test" returns 0, also check whether any system
test output was generated as a result of running it.  This prevents the
CI job running system tests from succeeding unless it actually tests
something.

(cherry picked from commit 80ab2c0f22)
2018-04-10 20:04:39 -07:00
Evan Hunt f7090700c7 Merge branch '197-dnstap-sockaddr-v9_11' into 'v9_11'
Resolve "dnstap: log actual local IPv6 address, not :: listening address"

Closes #197

See merge request isc-projects/bind9!188
2018-04-10 17:32:27 -07:00
Evan Hunt bd60a72551 CHANGES note
(cherry picked from commit 330b26c9df)
2018-04-10 17:32:27 -07:00
Tony FinchandEvan Hunt b53dee6d8f dnstap: log actual local IPv6 address, not :: listening address
(cherry picked from commit ccff953c25)
2018-04-10 17:26:08 -07:00
Evan Hunt 920eb326a5 Merge branch '183-add-dns_fixedname_initname-v9_11' into 'v9_11'
Add and use dns_fixedname_initname()

Closes #183

See merge request isc-projects/bind9!161
2018-04-10 14:08:27 -07:00
Mukund SivaramanandEvan Hunt 984182a3fc Add CHANGES entry:
4921.   [cleanup]       Add dns_fixedname_initname() and refactor the caller
                        code to make usage of the new function, as a part of
                        refactoring dns_fixedname_*() macros were turned into
                        functions. [GL #183]

(cherry picked from commit d7faee2566)
(cherry picked from commit d7676d0fa8)
2018-04-10 13:27:54 -07:00
Michał KępieńandEvan Hunt ab88043e74 Do not access dns_fixedname_t fields directly
Employ dns_fixedname_name() and dns_fixedname_initname() to no longer
directly access dns_fixedname_t fields.

(cherry picked from commit 39ddf9991f)
(cherry picked from commit 706f865a20)
2018-04-10 13:27:48 -07:00
Michał KępieńandEvan Hunt ecea678dac Use dns_fixedname_initname() where possible
Replace dns_fixedname_init() calls followed by dns_fixedname_name()
calls with calls to dns_fixedname_initname() where it is possible
without affecting current behavior and/or performance.

This patch was mostly prepared using Coccinelle and the following
semantic patch:

    @@
    expression fixedname, name;
    @@
    -	dns_fixedname_init(&fixedname);
    	...
    -	name = dns_fixedname_name(&fixedname);
    +	name = dns_fixedname_initname(&fixedname);

The resulting set of changes was then manually reviewed to exclude false
positives and apply minor tweaks.

It is likely that more occurrences of this pattern can be refactored in
an identical way.  This commit only takes care of the low-hanging fruit.

(cherry picked from commit 4df4a8e731)
(cherry picked from commit 0041aeb751)
2018-04-10 13:26:23 -07:00
Mukund SivaramanandEvan Hunt 1dea0795d1 Add a dns_fixedname_initname() helper function
This also turns the dns_fixedname macros into functions.

(cherry picked from commit 0d2a03c290)
(cherry picked from commit cee4fef7c5)
2018-04-10 13:14:25 -07:00
Mark Andrews 1b4f1c26b2 Merge branch 'ssl-double-free-v9_11' into 'v9_11'
Fix double free after keygen error in dnssec-keygen

Closes #109

See merge request isc-projects/bind9!70
2018-04-06 14:24:36 +10:00
Ondřej SurýandMark Andrews 9a4414b039 Add CHANGES entry
(cherry picked from commit ef2b2a6c92)
2018-04-06 14:24:27 +10:00
Ondřej SurýandMark Andrews c5d1fedca8 A couple of more cleanups after free in opensslrsa_generate()
(cherry picked from commit d2b3188c61)
2018-04-06 14:23:58 +10:00
Petr MensikandMark Andrews 8baf990392 Do not assign NULL conditionally in OpenSSL < 1.1, make it always explicit.
(cherry picked from commit edaafacf36)
2018-04-06 14:23:58 +10:00
Petr MensikandMark Andrews f36e13b039 Fix double free on RSA_generate_key_ex failure
(cherry picked from commit 01cc622e7b)
2018-04-06 14:23:57 +10:00
Mark Andrews 0f67278a7e system should only be in SUBDIRS
(cherry picked from commit 342e146fe3)
2018-04-06 13:09:45 +10:00
Ondřej Surý d653a8bf24 Merge branch 'pemensik/bind9-no-idn2-export-v9_11' into 'v9_11'
Don't include -lidn2 in isc-config.sh output

See merge request isc-projects/bind9!180
2018-04-05 06:13:44 -04:00
Ondřej Surý 31e5ceeea7 Print information about LIBIDN2 in Configuration summary (Closes: #163)
(cherry picked from commit 8da5e5290f)
2018-04-05 12:05:59 +02:00
Petr MenšíkandOndřej Surý 3b2294c56a Remove -lidn2 from exported LIBS. Do not propagate it from isc-config.sh --libs isc.
(cherry picked from commit 21c2871667)
2018-04-05 12:05:57 +02:00
Ondřej Surý ba1cb23fa3 Merge branch 'kchen/bind9-test-prereqs-v9_11' into 'v9_11'
Add a Net::DNS prereq for couple of tests

See merge request isc-projects/bind9!177
2018-04-04 17:09:29 -04:00
Kevin ChenandOndřej Surý a39c613ccc Add a Net::DNS prereq for digdelv, fetchlimit, rpzrecurse, and zero
tests to avoid failed tests when Net::DNS is not present.

(cherry picked from commit 8b1b809ab4)
2018-04-04 23:02:58 +02:00
Stephen Morris 51fd67202b Merge branch '139-tests-for-idna2008-libidn2-merge-v9_11' into 'v9_11'
Resolve "Tests for IDNA2008 (libidn2)" - Merge into 9.11

See merge request isc-projects/bind9!173
2018-04-04 10:00:30 -04:00
Stephen Morris 79b7a5c89b Check libidn2 version before proceding with one of the tests.
A known issue in libidn2 causes one of the tests of a fake A-label
to fail.  The problem should be corrected in version 2.0.5 of
libidn2.
2018-04-04 09:48:52 -04:00
Ondřej SurýandStephen Morris 05880829e0 Use C.UTF-8 if available, and en_US.UTF-8 is available, otherwise do nothing and let the test break 2018-04-04 09:48:51 -04:00
Stephen Morris 8319ece415 Set known locale prior to running tests. 2018-04-04 09:48:50 -04:00
Stephen Morris dfb264f85c Fix check for the presence of IDNA. 2018-04-04 09:48:49 -04:00
Stephen Morris 777a37affd Added additional tests for invalid punycode strings. 2018-04-04 09:48:49 -04:00
Stephen Morris e0b6c11840 Initial set of IDNA tests. 2018-04-04 09:48:47 -04:00
Michał Kępień a71c9a12f9 Merge branch '188-remove-duplicate-named_g_conffile-init-v9_11' into 'v9_11'
Remove redundant named_g_conffile initialization

Closes #188

See merge request isc-projects/bind9!166
2018-04-04 12:34:21 +02:00
Ondřej SurýandMichał Kępień 61715b2120 Remove redundant ns_g_conffile initialization from bin/named/win32/os.c
(cherry picked from commit c727f0797b)
2018-04-04 12:34:07 +02:00
Ondřej Surý 535a4ae85c Merge branch '26-fix-normalization-for-non-IDN-v9_11' into 'v9_11'
Don't use the IDN translated name if no conversion took a place

See merge request isc-projects/bind9!157
2018-03-22 10:04:10 -04:00
Ondřej Surý db7231e4ab Don't use the IDN traslated name if no conversion took a place
(cherry picked from commit 08f66d8509)
2018-03-22 13:54:49 +00:00
Mark Andrews 4dd54a688c Merge branch '167-coverity-dereferencing-a-null-pointer-in-lib-dns-tests-rbt_test-c-v9_11' into 'v9_11'
Resolve "coverity: Dereferencing a null pointer in lib/dns/tests/rbt_test.c"

Closes #167

See merge request isc-projects/bind9!150
2018-03-20 09:54:56 +11:00
Mukund SivaramanandMark Andrews 4445ee6491 Check return value of isc_mem_get()
(cherry picked from commit de3a4af1bf)
2018-03-20 09:54:55 +11:00
Mark Andrews f56b63d9ac fix temporary file name to have subtest number
(cherry picked from commit e12453f43c88bac722fb511b62f12303735b788c)
2018-03-19 23:13:10 +11:00
Mark Andrews 79c85f5e60 Merge branch 'fixtypo-v9_11' into 'v9_11'
fix typo

See merge request isc-projects/bind9!148
2018-03-19 22:55:24 +11:00
Mark Andrews c5d1d9d232 fix typo
(cherry picked from commit 6e4b5f2345)
2018-03-19 22:53:09 +11:00
Mark Andrews b05e162caa Merge branch '166-statistics-system-test-numbering-is-bad-v9_11' into 'v9_11'
Resolve "statistics system test numbering is bad"

Closes #166

See merge request isc-projects/bind9!146
2018-03-19 20:27:50 +11:00
Mark Andrews 7921d18f11 fix numbering of tests and make consistent
(cherry picked from commit dd5dff3096)
2018-03-19 20:27:26 +11:00
Ondřej SurýandMark Andrews 887fcc0061 Update libtool files to 2.4.6
(cherry picked from commit fe06778be7)
2018-03-19 13:03:56 +11:00
Ondřej Surý de32e55f3e Merge branch '164-remove-openssl-warning-v9_11' into 'v9_11'
[v9_11] Remove useless OpenSSL warning from configure script

See merge request isc-projects/bind9!141
2018-03-17 10:50:21 -04:00
Ondřej Surý 9e2d1ddf22 Remove obsolete OpenSSL version check
(cherry picked from commit e9571d29af)
2018-03-17 14:31:47 +00:00
Ondřej Surý eb48e66202 Merge branch '26-switch-to-IDNA2008-non-transitional-processing-v9_11' into 'v9_11'
Resolve "Switch to IDNA2008 non-transitional processing (and use libidn2 for that)"

Closes #26

See merge request isc-projects/bind9!124
2018-03-17 13:37:50 +00:00
Ondřej Surý 2ff3b664bc Add release notes for IDNA2008
(cherry picked from commit e7590c7528)
2018-03-17 13:37:48 +00:00
Ondřej Surý a0d45f5d50 Add CHANGES for idn2 support
(cherry picked from commit 8f44ef7d59)
2018-03-17 13:36:53 +00:00
Ondřej Surý b0c7cda6d7 Enable --with-libidn2 in GitLab CI checks
(cherry picked from commit 1c075646f5)
2018-03-17 13:36:34 +00:00
Ondřej Surý c085286822 Simplify the libidn2 configure checks
(cherry picked from commit 76c05a71fc)
2018-03-17 13:36:33 +00:00
Petr MenšíkandOndřej Surý 82914d0a41 Sanitize IDN initialization
Signed-off-by: Petr Menšík <pemensik@redhat.com>
(cherry picked from commit 29b94bbb04)
2018-03-17 13:35:59 +00:00
Petr MenšíkandOndřej Surý 9117bbe9a5 Remove support for libidn (IDN 2003)
Signed-off-by: Petr Menšík <pemensik@redhat.com>
(cherry picked from commit 8254cf69d3)
2018-03-17 13:35:58 +00:00
Petr MenšíkandOndřej Surý 2b031d1759 Remove conversion from locale to utf8 from public API
Emit fatal failures on locale to ACE encoding

Separate idnout support, disable it for libidn2 < 2.0

Add custom path to libidn. Leave default path for multilib support.

Allow turning off IDN input processing by dig option

Improve documentation, fix support in host

Fix configure changes to adjust help text

Use strlcpy with size guard

Improve IDN variants choosing. Fix idn2 function name.

Remove immediate idn_locale_to_ace and idn_ace_to_locale.

Signed-off-by: Petr Menšík <pemensik@redhat.com>
(cherry picked from commit 94757c1545)
2018-03-17 13:35:23 +00:00