Commit Graph

28052 Commits

Author SHA1 Message Date
Ondřej Surý
1e96fb8dc0 Request exclusive access when crashing via fatal()
When loading the configuration fails, there might be already other tasks
running and calling OpenSSL library functions.  The OpenSSL on_exit
handler is called when exiting the main process and there's a timing
race between the on_exit function that destroys OpenSSL allocated
resources (threads, locks, ...) and other tasks accessing the very same
resources leading to a crash in the system threading library. Therefore,
the fatal() function needs to request exlusive access to the task
manager to finish the already running tasks and exit only when no other
tasks are running.

(cherry picked from commit 952d7fde63)
2019-11-26 13:56:02 +01:00
Ondřej Surý
fff784b061 Merge branch 'ondrej/add-retry_quiet-function-to-conf.sh.common-v9_11' into 'v9_11'
Add retry_quiet() function to retry quietly for an event to occur

See merge request isc-projects/bind9!2632
2019-11-26 08:40:42 +00:00
Ondřej Surý
f5852f5f81 Add retry_quiet() function to retry quietly for an event to occur
(cherry picked from commit 31264a7e00)
2019-11-26 09:21:39 +01:00
Mark Andrews
0455351802 Merge branch '1367-threadsanitizer-data-race-dispatch-c-901-in-free_buffer-v9_11' into 'v9_11'
Resolve "ThreadSanitizer: data race dispatch.c:901 in free_buffer"

See merge request isc-projects/bind9!2628
2019-11-26 02:30:14 +00:00
Mark Andrews
d74a6a96c3 move maxbuffers test to allocate_udp_buffer
(cherry picked from commit 26a93d77aa)
2019-11-26 11:53:33 +11:00
Mark Andrews
1d928de33e Lock dispatch manager buffer_lock before accessing buffers;
Only test buffers for UDP dispatches.

(cherry picked from commit 011af4de71)
2019-11-26 11:53:33 +11:00
Mark Andrews
dcb21f39b6 lock disp->mgr before reading disp->mgr->buffers
(cherry picked from commit afc7389ce8)
2019-11-26 11:53:33 +11:00
Mark Andrews
40450fffc0 Merge branch '1397-install-isc-python-module-v9_11' into 'v9_11'
Resolve "Install ISC python module"

See merge request isc-projects/bind9!2626
2019-11-26 00:46:03 +00:00
Mark Andrews
dbd7d580e4 add CHANGES and note in README.md
(cherry picked from commit 8bbafeb5ef)
2019-11-26 10:04:53 +11:00
Mark Andrews
da75b8a7d1 check for 'distutils.core setup'
(cherry picked from commit 50e1bf3800)
2019-11-26 10:04:04 +11:00
Evan Hunt
542fb86f41 Merge branch 'each-notes-v9_11' into 'v9_11'
cleanup release notes text

See merge request isc-projects/bind9!2624
2019-11-25 21:21:18 +00:00
Evan Hunt
ad9c8efbf6 cleanup release notes text
(cherry picked from commit fa70fc8731)
2019-11-25 13:20:52 -08:00
Mark Andrews
e36730076a Merge branch '1334-threadsanitizer-data-race-dispatch-c-1339-in-tcp_recv-v9_11' into 'v9_11'
lock dispatch before reporting state

See merge request isc-projects/bind9!2619
2019-11-22 21:48:12 +00:00
Mark Andrews
9cffeb606a lock dispatch before reporting state
(cherry picked from commit 3075445ed6)
2019-11-23 08:25:47 +11:00
Mark Andrews
83d08bfb8e Merge branch '1317-alphabetise-delv-s-usage-v9_11' into 'v9_11'
alphabetise delv's usage.

See merge request isc-projects/bind9!2616
2019-11-22 19:34:06 +00:00
Mark Andrews
fcbabac0cd alphabetise delv's usage.
(cherry picked from commit 78685ed173)
2019-11-23 00:12:21 +11:00
Mark Andrews
b9be8bac52 Merge branch '1386-9-11-fix-conditional-define-of-lock_callback' into 'v9_11'
Resolve "9.11: fix conditional define of lock_callback"

See merge request isc-projects/bind9!2596
2019-11-21 00:18:33 +00:00
Mark Andrews
7d45e655a6 add CHANGES 2019-11-21 10:59:16 +11:00
Mark Andrews
9d4f5f88f3 Conditional compilation of lock_callback was inconsistent with
conditional use of the function when forcing BIND to build with
older and unsupported versions of OpenSSL.
2019-11-21 10:59:16 +11:00
Evan Hunt
5c4351d4bb Merge branch 'merge-v9_11_13' into 'v9_11'
merge 9.11.13 into v9_11 branch

See merge request isc-projects/bind9!2606
2019-11-20 21:47:53 +00:00
Evan Hunt
99203103b7 Merge tag 'v9_11_13' into merge-v9_11_13 2019-11-20 13:43:34 -08:00
Ondřej Surý
37f15ceaae Merge branch '1341-threadsanitizer-data-race-rbtdb-c-5756-in-add32-v9_11' into 'v9_11'
Resolve "ThreadSanitizer: data race rbtdb.c:5756 in add32"

See merge request isc-projects/bind9!2594
2019-11-19 17:33:58 +00:00
Mark Andrews
92a73a3abe add CHANGES
(cherry picked from commit 4534fb5ec1)
2019-11-20 01:05:03 +08:00
Mark Andrews
a64c9fae62 use update_recordsandbytes in rbt_datafixer
(cherry picked from commit 7d4d64340e)
2019-11-20 01:01:52 +08:00
Mark Andrews
cf78ae96e5 always obtain write lock when updating version->{records,bytes}
(cherry picked from commit 0cda448248)
2019-11-20 01:01:51 +08:00
Michał Kępień
fc91e783b1 Merge branch '1308-fix-tcp-system-test-v9_11' into 'v9_11'
[v9_11] Fix "tcp" system test

See merge request isc-projects/bind9!2592
2019-11-19 15:19:19 +00:00
Michał Kępień
87f7838a99 Address ShellCheck warnings
Address all outstanding warnings that ShellCheck reports for
bin/tests/system/tcp/tests.sh.

(cherry picked from commit 23ca0ec55b)
2019-11-19 15:46:55 +01:00
Michał Kępień
a390e261ad Use "set -e" in the "tcp" system test
Ensure any unexpected failure in the "tcp" system test causes it to be
immediately interrupted with an error to make the aforementioned test
more reliable.  Since the exit code for "expr 0 + 0" is 1, the status
variable needs to be updated using arithmetic expansion.

(cherry picked from commit 9841635b7f)
2019-11-19 15:46:35 +01:00
Michał Kępień
06705a0ee5 Ensure all "tcp" system test errors are caught
Ensure any "rndc stats" failure causes the "tcp" system test to fail.
Do not hide "rndc stats" output.

(cherry picked from commit 46df363a0d)
2019-11-19 15:46:34 +01:00
Michał Kępień
bc498bd6c9 Make all "tcp" system test checks numbered
Ensure all checks in the "tcp" system test are numbered, so that
forensic data is preserved in case of any failure.

(cherry picked from commit 2f4877d11c)
2019-11-19 15:46:04 +01:00
Michał Kępień
01a413cecc Fix argument order in assert_int_equal()
assert_int_equal() calls in bin/tests/system/tcp/tests.sh pass the found
value as the first argument and the expected value as the second
argument, while the function interprets its arguments the other way
round.  Fix argument handling in assert_int_equal() to make sure the
error messages printed by that function are correct.

(cherry picked from commit 6bd1f68bef)
2019-11-19 15:45:07 +01:00
Michał Kępień
3e9781087a Allow retries when checking TCP high-water stats
In the TCP high-water checks, "rndc stats" is run after ans6 reports
that it opened the requested number of TCP connections.  However, we
fail to account for the fact that ns5 might not yet have called accept()
for these connections, in which case the counts output by "rndc stats"
will be off.  To prevent intermittent "tcp" system test failures, allow
the relevant connection count checks to be retried (just once, after one
second, as that should be enough for any system to accept() a dozen TCP
connections under any circumstances).

(cherry picked from commit 1e22e052d0)
2019-11-19 15:43:16 +01:00
Mark Andrews
434615407e Merge branch '1299-parse-commandline-code-should-be-done-in-alphabetical-order-v9_11' into 'v9_11'
alphabetize command line switch

See merge request isc-projects/bind9!2590
2019-11-19 10:11:06 +00:00
Mark Andrews
8cff0b74ac alphabetize command line switch
(cherry picked from commit ca83a66618)
2019-11-19 20:54:49 +11:00
Ondřej Surý
1e24b9296c Merge branch 'ondrej/dont-call-dns_adb_endupdfetch-for-TCP-queries-v9_11' into 'v9_11'
lib/dns/resolver.c: Call dns_adb_endudpfetch() only for UDP queries

See merge request isc-projects/bind9!2586
2019-11-18 20:16:13 +00:00
Ondřej Surý
ab4e6c2fe7 lib/dns/resolver.c: Call dns_adb_endudpfetch() only for UDP queries
The dns_adb_beginudpfetch() is called only for UDP queries, but
the dns_adb_endudpfetch() is called for all queries, including
TCP.  This messages the quota counting in adb.c.

(cherry picked from commit a5189eefa5)
2019-11-19 03:48:47 +08:00
Ondřej Surý
666c4a28e5 Merge branch 'ondrej/switch-coccinelle-job-to-buster-v9_11' into 'v9_11'
Installing coccinelle on Debian sid is broken, switch to Debian buster

See merge request isc-projects/bind9!2584
2019-11-18 18:05:11 +00:00
Ondřej Surý
38cf022442 Installing coccinelle on Debian sid is broken, switch to Debian buster
(cherry picked from commit 0946db13de)
2019-11-19 02:02:48 +08:00
Michał Kępień
163be9bcf9 Merge branch 'fix-url-in-readme-v9_11' into 'v9_11'
[v9_11] updated a broken link for newer release notes.

See merge request isc-projects/bind9!2570
2019-11-13 12:02:29 +00:00
Vicky Risk
6c4fb259c4 Update broken release notes link
(cherry picked from commit c830a9116d)
2019-11-13 13:00:18 +01:00
Ondřej Surý
b734276748 Merge branch 'hurd-v9_11' into 'v9_11'
hurd: Fix build

See merge request isc-projects/bind9!2564
2019-11-12 09:08:28 +00:00
Ondřej Surý
d2c86b2159 Internally, use {PATH,NAME}_MAX instead of ISC_DIR_{PATH,NAME}MAX 2019-11-12 09:31:40 +01:00
Samuel Thibault
88061c2acb hurd: Fix build
Move PATH_MAX, NAME_MAX, IOV_MAX default definitions to the common
<isc/platform.h>.

(cherry picked from commit d10fbdec84)
2019-11-12 09:22:15 +01:00
Tinderbox User
8f32a30e5c Merge branch 'prep-release' into security-v9_11 v9.11.13 2019-11-06 21:46:22 +00:00
Tinderbox User
5edf8dcb0d regen security-v9_11 2019-11-06 21:43:00 +00:00
Tinderbox User
336d24089b prep 9.11.13 2019-11-06 21:26:36 +00:00
Ondřej Surý
7b6e1597f4 Add CHANGES entry 2019-11-06 21:32:54 +01:00
Ondřej Surý
1c59ff3a4d Add release note 2019-11-06 21:32:54 +01:00
Witold Kręcicki
7562485282 libns: Rename ns_tcpconn refs member to clients 2019-11-06 21:32:54 +01:00
Witold Kręcicki
7d14ea3795 Limit query pipelining within each TCP connection
Previously, there was no limit to the number of concurrently served
queries over one pipelined TCP connection; an unlimited number of
queries sent over a single TCP connection could have potentially
exhausted the server's resources.
2019-11-06 21:32:54 +01:00