Commit Graph
6030 Commits
Author SHA1 Message Date
Brian Wellington 1b1775921e If a message is built for one host, which isn't powered on, the tsig object
wasn't removed until the xfer object was deleted, so when the xfer tried the
second master, it asserted.
2000-07-24 05:30:30 +00:00
Michael Sawyer 2f0bfccf31 Remove dead REQUIRE 2000-07-22 00:40:39 +00:00
Michael Sawyer f592550498 Add comments and make a slight REQUIRE change 2000-07-22 00:27:40 +00:00
Michael Sawyer 0371079513 Wire up key option in masters line. 2000-07-21 23:13:59 +00:00
Andreas Gustafsson 3f290e501e don't use initial capital letter in log message 2000-07-21 23:04:44 +00:00
Brian Wellington c27767a7b9 tsig keys were not properly ref counted 2000-07-21 23:00:31 +00:00
Andreas Gustafsson 9bef4575d7 344. [bug] When shutting down, lwresd sometimes tried
to shut down its client tasks twice,
                        triggering an assertion.
(fixed in lwresd.c 1.11)
2000-07-21 22:45:44 +00:00
Brian Wellington 3b2efab212 There's no real difference between the "sring" and "dring" parameters, so
call them "ring1" and "ring2" instead.  Also remove a bogus assertion.
2000-07-21 22:38:31 +00:00
Andreas Gustafsson 87f4c7933f 343. [bug] Although zone maintenance SOA queries and
notify requests were signed with TSIG keys
                        when configured for the server in case,
                        the TSIG was not verified on the response.

 342.   [bug]           The wrong name was being passed to
                        dns_name_dup() when generating a TSIG
                        key using TKEY.
2000-07-21 22:31:12 +00:00
Brian Wellington 4e160a846f Removed the tsig keyring, since it's no longer needed. 2000-07-21 22:26:08 +00:00
Michael Sawyer f840a7bd0d Remove unused variable, fix char*[] variable 2000-07-21 22:25:15 +00:00
Brian Wellington 2483a850e8 The call to dns_tsig_verify doesn't need a keyring. 2000-07-21 22:22:55 +00:00
Andreas Gustafsson 5aa7bca733 dns_rbt_printnode() formatted the node name
into a buffer of 255 char pointers, not 255 chars; changed it
to use dns_name_format()
2000-07-21 22:08:42 +00:00
James Brister c35f1e5937 341. [func] Support 'key' clause in named.conf zone masters
statement:

                                masters {
                                        10.0.0.1 port 666 key "foo";
                                        10.0.0.2 ;
                                };
2000-07-21 21:25:01 +00:00
Andreas Gustafsson baf50a7210 removed unsightly spaces 2000-07-21 21:21:26 +00:00
Andreas Gustafsson b6dcb3d243 print_name() formatted text into a buffer of 256
character pointers, not 256 characters; also changed it to
use dns_name_format()
2000-07-21 21:13:40 +00:00
Brian Wellington 87ab7fb07d The keys weren't properly freed. Also added a "-p port" option and did
some other cleanup.
2000-07-21 21:02:46 +00:00
Andreas Gustafsson c3c57248e0 missing NULL initialization 2000-07-21 21:02:15 +00:00
Brian Wellington a49acbf201 Store tsig keys in an rbt, not a list. 2000-07-21 20:53:59 +00:00
Michael Sawyer b6e3718b20 Should really allocate memory before trying to use it. 2000-07-21 20:51:44 +00:00
Brian Wellington 42b98b222c The call to dns_tsigkey_setdeleted is no longer needed. 2000-07-21 20:38:30 +00:00
Andreas Gustafsson e30c4dbe6f typos 2000-07-21 20:37:01 +00:00
Brian Wellington 84a47e20ae If the request was signed with a tsig key, verify the signature on the
response.
2000-07-21 20:33:13 +00:00
Brian Wellington 4be64854b4 The wrong name was being duped when a tsig key was generated using tkey. 2000-07-21 20:32:12 +00:00
Michael Sawyer 5813d091e9 Spacing changes
replace memset with slightly more portable NULL initialization
properly NULL masterkeynames when zone is created
2000-07-21 20:10:03 +00:00
Michael Sawyer 9b72c4648f Internal code for masters with key entries. Not wired into config yet. 2000-07-21 18:47:23 +00:00
Michael Sawyer 8bf0f722f8 Count and possibly limit how many names and rr's in a xfr.
(Needed by GDIB folks)
2000-07-20 19:41:44 +00:00
Michael Sawyer 390132bd98 Run resolver test in make tests 2000-07-20 19:38:05 +00:00
Brian Wellington d6e6858bb9 If dns_request_getresponse() fails, log it. 2000-07-20 19:34:16 +00:00
Brian Wellington a5e73f3e9d Having a non-noerror value inn the tsig error field should always return
DNS_R_TSIGERRORSET in dns_tsig_verify.  Change the result text to reflect
this.
2000-07-20 19:32:57 +00:00
Brian Wellington e860332b07 A call to isc_mem_put could pass a different size than was gotten. Use
isc_mem_allocate instead.
2000-07-20 17:58:59 +00:00
Michael Sawyer 26cebf3482 Slight bug in batch processing 2000-07-20 17:56:20 +00:00
Andreas Gustafsson b7ebc6a127 minor tweak to hash function of previous change 2000-07-20 01:15:25 +00:00
Andreas Gustafsson f969863d54 replaced the hash function in dns_name_hash() by one
that is simpler, faster, and produces a much more even distribution,
particularly when the data to hash ends with a null byte like domain
names often do
2000-07-20 01:14:48 +00:00
Andreas Gustafsson dae5ce6ddb 340. [bug] The top-level COPYRIGHT file was missing from
the distribution.
2000-07-20 00:41:50 +00:00
Andreas Gustafsson 9a8fea7bc8 When handling the response to an ANY query in a secure zone, deal with
the multiple answer RRsets by validating each one separately.  Also,
eliminated the "done" variable in answer_response() because in the
rare situations where it got set to ISC_TRUE, it caused the function
to return prematurely by exiting a loop with a result of ISC_R_SUCCESS
and hitting a "if (result != ISC_R_NOMORE) return (result);" test
immediately following following the loop.

This should fix [RT #109], "ANY query in secure zone crashes server".
2000-07-20 00:06:28 +00:00
Andreas Gustafsson 99eba32b06 Removed the code added in revision 1.57:
"Store CNAMEs and their SIGs (if any) in their own name structure on
  the name list.  I.e. do not mix CNAMEs with non-CNAME data.  Do the
  same thing for DNAMEs."

because it caused DNSSEC validation of responses to ANY queries at
nodes with CNAME records to fail, and no one was able to figure out
why it was added in the first place.  As a beneficial side effect,
findname() now finds names even if they have attribute bits set
differently from the one being searched for.  This supersedes
the fix of revision 1.133.
2000-07-20 00:05:32 +00:00
Andreas Gustafsson aa5940281a When handling the response to an ANY query in a secure zone, deal with
the multiple answer RRsets by validating each one separately.  Also,
eliminated the "done" variable in answer_response() because in the
rare situations where it got set to ISC_TRUE, it caused the function
to return prematurely by exiting a loop with a result of ISC_R_SUCCESS
and hitting a "if (result != ISC_R_NOMORE) return (result);" test
immediately following following the loop.

This should fix [RT #109], "ANY query in secure zone crashes server".
2000-07-19 23:19:05 +00:00
Andreas Gustafsson c7d445ce7f edited 2000-07-19 20:34:40 +00:00
Andreas Gustafsson b0e67b3020 removed unnecessary call to isc_socket_cancel() 2000-07-19 20:34:14 +00:00
Andreas Gustafsson 8b2d2acbff in the multi-stage positive validation test, allow the
recursive server to omit the authority section
2000-07-19 19:54:50 +00:00
Michael Sawyer 3caa2d8362 Probably no need to call srandom() if we never call random(). 2000-07-19 18:24:40 +00:00
Michael Sawyer 68f0d29d61 Fix a minor race condition in SIGINT handling
Allow dig to used name key files
Allow SIGINT in nslookup
2000-07-19 17:52:27 +00:00
Brian Wellington 70c2802fd7 In query_addbestns, check that both the rdataset and sigrdataset are not
pending before adding them.
2000-07-18 22:24:45 +00:00
Michael Sawyer 5e804988e9 Add comments to source code 2000-07-18 18:51:40 +00:00
Andreas Gustafsson 0ade7651fc hint zones do go in views; match_clients -> match-clients 2000-07-18 18:16:19 +00:00
Brian Wellington 209ec709f3 Use the isc hmac library instead of a separate implementation (not that
the separate implementation was especially complicated).  dst hmac-md5 should
really go away at some point.
2000-07-18 18:15:27 +00:00
Brian Wellington 663841abe0 338. [bug] lwresd logged to syslog as named, not lwresd. 2000-07-18 17:50:02 +00:00
Andreas Gustafsson e54e6744d6 do two queries; added comments 2000-07-18 17:13:40 +00:00
James Brister 4ca8537286 Removed some debugging cruft.
Fixed handling of octal/hexadecimal numbers on input.
2000-07-18 13:19:27 +00:00