Commit Graph
35936 Commits
Author SHA1 Message Date
Michal Nowak 14f88bc241 Drop stress tests
After isc-projects/bind9-qa!9 merged BIND 9 releases without DoH/DoT
support are not supported.

Merge branch 'mnowak/drop-stress-tests' into 'bind-9.16'

See merge request isc-projects/bind9!10005
2025-01-27 16:10:36 +00:00
Michal Nowak 4a7753cda3 Drop stress tests
After isc-projects/bind9-qa!9 merged BIND 9 releases without DoH/DoT
support are not supported.
2025-01-27 16:26:54 +01:00
Arаm Sаrgsyаn 4f876e7111 [9.16] fix: dev: Fix a bug in isc_rwlock_trylock()
When isc_rwlock_trylock() fails to get a read lock because another
writer was faster, it should wake up other waiting writers in case
there are no other readers, but the current code forgets about
the currently active writer when evaluating 'cntflag'.

Unset the WRITER_ACTIVE bit in 'cntflag' before checking to see if
there are other readers, otherwise the waiting writers, if they exist,
might not wake up.

Closes #5121

Backport of MR !9937

Merge branch 'backport-aram/isc_rwlock_trylock-bugfix-9.18-9.16' into 'bind-9.16'

See merge request isc-projects/bind9!9938
2025-01-08 12:39:51 +00:00
Aram Sargsyan aef3f26aaf Fix a bug in isc_rwlock_trylock()
When isc_rwlock_trylock() fails to get a read lock because another
writer was faster, it should wake up other waiting writers in case
there are no other readers, but the current code forgets about
the currently active writer when evaluating 'cntflag'.

Unset the WRITER_ACTIVE bit in 'cntflag' before checking to see if
there are other readers, otherwise the waiting writers, if they exist,
might not wake up.

(cherry picked from commit 73b6d9e9e5)
2025-01-08 10:30:05 +00:00
Michal Nowak 40ecc8a67e [9.16] chg:test: Disable too-many/too-few pylint checks
Enforcing pylint standards and default for our test code seems
counter-productive. Since most of the newly added code are tests or is
test-related, encountering these checks rarely make us refactor the code
in other ways and we just disable these checks individually. Code that
is too complex or convoluted will be pointed out in reviews anyways.

(cherry picked from commit f7319a38cf277c2140f0ed7ab46fd616b9322587)

Backport of MR !9626

Merge branch 'backport-nicki/pylint-disable-too-few-too-many-checks-9.16' into 'bind-9.16'

See merge request isc-projects/bind9!9806
2024-12-03 10:32:21 +00:00
Nicki KřížekandMichal Nowak d4fb094ee8 Disable too-many/too-few pylint checks
Enforcing pylint standards and default for our test code seems
counter-productive. Since most of the newly added code are tests or is
test-related, encountering these checks rarely make us refactor the code
in other ways and we just disable these checks individually. Code that
is too complex or convoluted will be pointed out in reviews anyways.

(cherry picked from commit 7639c58c48)
2024-12-03 10:42:58 +01:00
Evan Hunt 31d8e3b21f [9.16] new: usr: Update bind.keys with the new 2025 IANA root key
Add an 'initial-ds' entry to bind.keys for the new root key, ID
38696, which is scheduled for publication in January 2025.

Closes #4896

Backport of MR !9422

Merge branch 'backport-4896-update-bind-keys-9.16' into 'bind-9.16'

See merge request isc-projects/bind9!9748
2024-11-16 00:31:28 +00:00
Evan Hunt a2f8b76c5e Add the DS for the new root key (38696)
Add an 'initial-ds' entry to bind.keys for the new root key, ID
38696, scheduled for publication in January 2025.

(cherry picked from commit 609bf35075)
2024-11-15 15:58:37 -08:00
Michal Nowak ce033c945d [9.16] chg: test: Support dnspython 2.7.0
Closes #4988

Backport of MR !9634

Merge branch 'backport-4988-dnspython-2.7.0-support-9.16' into 'bind-9.16'

See merge request isc-projects/bind9!9677
2024-10-22 07:13:12 +00:00
Nicki KřížekandMichal Nowak 11beae640e Support dnspython 2.7.0
CookieOption with new .server/.client attributes (rather than .data) was
added to dnspython. Adjust the code to use the new attributes if
available and fall back to the old code for dnspython<2.7.0
compatibility.

(cherry picked from commit 0d90b13646)
2024-10-22 08:31:07 +02:00
Michal Nowak 463a47bcc2 [9.16] chg: ci: Exclude some RPZ files from long stress test artifacts
This fixes 6f86885304, that excluded files
only from short stress tests.

Validation jobs:
- [x] short - [#4756989](https://gitlab.isc.org/isc-projects/bind9/-/jobs/4756989/artifacts/browse/output/ns4/) - 
- [x] long - [#4757196](https://gitlab.isc.org/isc-projects/bind9/-/jobs/4757196/artifacts/browse/output/ns4/)

Backport of MR !9522

Merge branch 'backport-mnowak/exclude-some-rpz-files-from-long-stress-tests-artifacts-9.16' into 'bind-9.16'

See merge request isc-projects/bind9!9540
2024-09-23 12:25:34 +00:00
Michal Nowak 2a500446ed Exclude some RPZ files from long stress test artifacts
This fixes 6f86885304, that excluded files
only from short stress tests.

(cherry picked from commit 871eeed519)
2024-09-23 11:21:00 +00:00
Michal Nowak 4540b3dd2d [9.16] chg: test: Be more patient when stopping servers in the system tests
When the TCP test is run on the busy server, the server might take a
while to wind the server down because it might still be processing all
that 300k invalid XFR requests.

Increate the rncd wait time to 120 seconds, the SIGTERM time to 300
seconds, and reduce the time to wait for ans servers from 1200 second
to just 120 seconds.

(cherry picked from commit d971472321)

Backport of MR !6847

Merge branch 'backport-ondrej-increase-the-time-to-wait-for-servers-to-gracefully-shutdown-9.16' into 'bind-9.16'

See merge request isc-projects/bind9!9468
2024-09-10 12:44:51 +00:00
Ondřej SurýandMichal Nowak 6d5e81c096 Be more patient when stopping servers in the system tests
When the TCP test is run on the busy server, the server might take a
while to wind the server down because it might still be processing all
that 300k invalid XFR requests.

Increate the rncd wait time to 120 seconds, the SIGTERM time to 300
seconds, and reduce the time to wait for ans servers from 1200 second
to just 120 seconds.

(cherry picked from commit d971472321)
2024-09-10 12:50:20 +02:00
Michal Nowak b16314289f [9.16] chg: ci: Cleanup stress test artifacts
Backport of MR !9424

Merge branch 'backport-mnowak/avoid-some-artifacts-in-stress-tests-9.16' into 'bind-9.16'

See merge request isc-projects/bind9!9430
2024-08-28 08:56:33 +00:00
Michal Nowak aa83d1150d Some stress test artifacts should not be saved in CI artifact
(cherry picked from commit 6f86885304)
2024-08-28 08:01:32 +00:00
Michal Nowak 5112d78950 chg: test: Bump max-recursion-queries to 100 in resolver system test
With max-recursion-queries set to 50 the resolver system test was
unstable in the "checking query resolution for a domain with a valid
glueless delegation chain" check as ns1 replied with SERVFAIL.

Closes #4897

Merge branch '4897-resolver-ns1-bump-max-recursion-queries-to-100' into 'bind-9.16'

See merge request isc-projects/bind9!9421
2024-08-28 07:26:13 +00:00
Michal Nowak 0c17917a40 Bump max-recursion-queries to 100 in resolver system test
With max-recursion-queries set to 50 the resolver system test was
unstable in the "checking query resolution for a domain with a valid
glueless delegation chain" check as ns1 replied with SERVFAIL.
2024-08-26 18:00:52 +02:00
Michal Nowak f65b8f517e [9.16] chg: ci: Drop removed system tests from cross-version-config-tests
The cross-version-config-tests job fails when a system test is removed
from the upcoming release. To avoid this, remove the system test also
from the $BIND_BASELINE_VERSION.

See the failure mode at https://gitlab.isc.org/isc-projects/bind9/-/jobs/4668947.

Backport of MR !9413

Merge branch 'backport-mnowak/remove-dialup-from-cross-version-config-tests-job-9.16' into 'bind-9.16'

See merge request isc-projects/bind9!9417
2024-08-26 15:25:32 +00:00
Michal Nowak bdd6abad73 Drop removed system tests from $BIND_BASELINE_VERSION
The cross-version-config-tests job fails when a system test is removed
from the upcoming release. To avoid this, remove the system test also
from the $BIND_BASELINE_VERSION.

(cherry picked from commit 60f5f2a9d9)
2024-08-26 16:35:33 +02:00
Michal Nowak fee5a1bd68 chg: ci: Fix formatting in lib/ns/query.c broken by !9284
Merge branch 'mnowak/fix-formating' into 'bind-9.16'

See merge request isc-projects/bind9!9414
2024-08-26 13:38:35 +00:00
Michal Nowak 2ac61b21bb Fix formatting in lib/ns/query.c broken by !9284 2024-08-26 14:25:55 +02:00
Petr Špaček 72e30c3cc0 [9.16] new: ci: Automate parts of MR workflow
Backport of MR !9244

Merge branch 'backport-pspacek/post-merge-ci-9.16' into 'bind-9.16'

See merge request isc-projects/bind9!9403
2024-08-23 08:45:28 +00:00
Petr Špaček bed0aea14f Remove milestone check from dangerfile
Milestone is automatically set by 'merged-metadata' CI job to 'Not
released yet' so it does not matter what the original value was.

(cherry picked from commit 73b950dc29)
2024-08-23 10:44:28 +02:00
Petr Špaček 1258078e8a Automatically adjust MR metadata after merge
1. Set milestone to 'Not released yet' after merge
   We will set milestone to actual version number when we actually tag a
   particular version. This will get rid of mass MR reassignment when we
   do last minute changes to a release plan etc.

2. Adjust No CHANGES and Release Notes MR labels to match gitchangelog
   workflow.

(cherry picked from commit 3165261ecd)
(cherry picked from commit d1c64d588b)
2024-08-23 10:44:28 +02:00
Ondřej Surý 5afaed14d3 [9.16] new: usr: Tighten 'max-recursion-queries' and add 'max-query-restarts' option
There were cases in resolver.c when the `max-recursion-queries` quota was ineffective. It was possible to craft zones that would cause a resolver to waste resources by sending excessive queries while attempting to resolve a name. This has been addressed by correcting errors in the implementation of `max-recursion-queries`, and by reducing the default value from 100 to 32.

In addition, a new `max-query-restarts` option has been added which limits the number of times a recursive server will follow CNAME or DNAME records before terminating resolution. This was previously a hard-coded limit of 16, and now defaults to 11.
 
Closes #4741

Backport of MR !9281

Merge branch 'backport-4741-reclimit-restarts-9.16' into 'bind-9.16'

See merge request isc-projects/bind9!9284
2024-08-22 09:31:53 +00:00
Evan HuntandOndřej Surý 3e0643a6dc implement 'max-query-restarts'
implement, document, and test the 'max-query-restarts' option
which specifies the query restart limit - the number of times
we can follow CNAMEs before terminating resolution.

(cherry picked from commit 104f3b82fb)
(cherry picked from commit 2e04f0380c)
2024-08-20 17:35:07 +00:00
Evan HuntandOndřej Surý a7a479c258 reduce the max-recursion-queries default to 32
the number of iterative queries that can be sent to resolve a
name now defaults to 32 rather than 100.

(cherry picked from commit 7e3b425dc2)
(cherry picked from commit a11367ade3)
2024-08-20 17:35:07 +00:00
Evan HuntandOndřej Surý 95376b45f5 make "max_restarts" a configurable value
MAX_RESTARTS is no longer hard-coded; ns_server_setmaxrestarts()
and dns_client_setmaxrestarts() can now be used to modify the
max-restarts value at runtime. in both cases, the default is 11.

(cherry picked from commit c5588babaf)
(cherry picked from commit bfbc6a6c84)
2024-08-20 17:35:07 +00:00
Evan HuntandOndřej Surý d1797c9151 reduce MAX_RESTARTS to 11
the number of steps that can be followed in a CNAME chain
before terminating the lookup has been reduced from 16 to 11.
(this is a hard-coded value, but will be made configurable later.)

(cherry picked from commit 05d78671bb)
(cherry picked from commit dd88a4cdfc)
2024-08-20 17:35:07 +00:00
Evan HuntandOndřej Surý 2b756caa4c add debug logging when creating or attaching to a query counter
fctx_create() now logs at debug level 9 when the fctx attaches
to an existing counter or creates a new one.

(cherry picked from commit 825f3d68c5)
(cherry picked from commit 14bce7e275)
2024-08-20 17:35:07 +00:00
Evan HuntandOndřej Surý f89f8af34a apply max-recursion-queries quota to validator queries
previously, validator queries for DNSKEY and DS records were
not counted toward the quota for max-recursion-queries; they
are now.

(cherry picked from commit af7db89513)
(cherry picked from commit 18e39d989f)
2024-08-20 17:35:07 +00:00
Evan HuntandOndřej Surý 1e54e9bb92 attach query counter to NS fetches
there were cases in resolver.c when queries for NS records were
started without passing a pointer to the parent fetch's query counter;
as a result, the max-recursion-queries quota for those queries started
counting from zero, instead of sharing the limit for the parent fetch,
making the quota ineffective in some cases.

(cherry picked from commit d3b7e92783)
(cherry picked from commit 5ab4cae4ed)
2024-08-20 17:35:07 +00:00
Michal Nowak a33dfc4c6f [9.16] rem: ci: Drop Oracle Linux 7
See #3729

Backport of MR !9352

Merge branch 'backport-3729-drop-oracle-linux-7-9.16' into 'bind-9.16'

See merge request isc-projects/bind9!9353
2024-08-19 15:57:48 +00:00
Michal Nowak f917cc3abb Drop Oracle Linux 7
(cherry picked from commit 4af28f9ffc)
2024-08-19 17:49:20 +02:00
Ondřej Surý 3644299c49 [9.16] chg: test: Drop TSAN jobs, drop bullseye jobs
The new TSAN images, the TSAN-enabled images install libraries to
opt/tsan, this doesn't work, just drop the TSAN jobs.

Additionally, drop Debian bullseye that's EOL now.

Backport of MR !9324

Merge branch 'backport-ondrej/use-staging-tsan-images-9.16' into 'bind-9.16'

See merge request isc-projects/bind9!9327
2024-08-16 07:09:39 +00:00
Ondřej Surý 3aa7be0c4f Also drop softhsm2.6 jobs 2024-08-16 09:07:52 +02:00
Ondřej Surý 8b3b25935d Don't bother with TSAN jobs for end-of-life release 2024-08-16 08:36:05 +02:00
Ondřej Surý a3372ccb5d Remove Debian bullseye jobs
The Debian bullseye has reached end-of-life, remove it from the CI.

(cherry picked from commit d02d6af2b9)
2024-08-16 08:24:05 +02:00
Ondřej Surý f1f88ccc15 For TSAN builds, use libraries from /opt/tsan
The new TSAN images, the TSAN-enabled images install libraries to
/opt/tsan, synchronize the configure options and CFLAGS between gcc:tsan
and clang:tsan images and set the PKG_CONFIG_PATH to /opt/tsan/lib.

(cherry picked from commit 2a46396f29)
2024-08-16 08:06:03 +02:00
Ondřej Surý 39ee669f7e [9.16] chg: test: Use new images with TSAN-enabled libraries
The new Fedora 40 TSAN images use libuv, urcu and OpenSSL libraries compiled with ThreadSanitizer.  This (in theory) should enable better detection of memory races in those (most important) libraries.

Backport of MR !9264

Merge branch 'backport-ondrej/test-new-tsan-images-9.16' into 'bind-9.16'

See merge request isc-projects/bind9!9280
2024-08-07 16:02:51 +00:00
Ondřej Surý bdb4f57549 Add configure for libraries in /usr/local for the gcc:tsan job
The TSAN-enabled libraries are installed to /usr/local, pass the
PKG_CONFIG_PATH and few other options to CFLAGS to the configure
arguments.

(cherry picked from commit ed766efc15)
2024-08-07 16:02:42 +00:00
Michał Kępień 17e6a3e334 [9.16] fix: test: refresh base image repos before installing from them
Stale repositories cause issue on installation in the `docs:pdf` CI job:

    E: Failed to fetch http://deb.debian.org/debian/pool/main/s/systemd/libsystemd-shared_252.22-1%7edeb12u1_amd64.deb  404  Not Found [IP: 2a04:4e42:78::644 80]
    E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

Validation job: https://gitlab.isc.org/isc-projects/bind9/-/jobs/4487570

Backport of MR !9164

Merge branch 'mnowak/refresh-base-image-repo-before-installation' into 'bind-9.16'

See merge request isc-projects/bind9!9129
2024-08-07 15:41:57 +00:00
Michal NowakandMichał Kępień a9bc69889c Refresh base image repos before installing from them
Stale repositories cause issue on installation in the docs:pdf CI job:

    E: Failed to fetch http://deb.debian.org/debian/pool/main/s/systemd/libsystemd-shared_252.22-1%7edeb12u1_amd64.deb  404  Not Found [IP: 2a04:4e42:78::644 80]
    E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

(cherry picked from commit 0077cfd7a6)
2024-08-07 17:04:04 +02:00
Michał Kępień 8026a59dba chg: test: use --without-python for Debian "sid" builds
Debian "sid" images used in GitLab CI no longer contain the distutils
Python module, which prevents the ./configure script from succeeding on
that operating system.  Instead of explicitly installing optional
dependencies for a branch that is no longer actively maintained, add the
--without-python switch to the ./configure invocations on Debian "sid"
to work around the problem.

Merge branch 'michal/disable-python-for-debian-sid-builds' into 'bind-9.16'

See merge request isc-projects/bind9!9260
2024-08-06 11:22:38 +00:00
Michał Kępień 5254bf662d chg: test: use --without-python for Debian "sid" builds
Debian "sid" images used in GitLab CI no longer contain the distutils
Python module, which prevents the ./configure script from succeeding on
that operating system.  Instead of explicitly installing optional
dependencies for a branch that is no longer actively maintained, add the
--without-python switch to the ./configure invocations on Debian "sid"
to work around the problem.
2024-08-06 09:34:53 +02:00
Nicki Křížek 62eb73b626 [9.16] chg: Remove danger checks for release notes and CHANGES
Since 9.21.0-dev, the release notes and changelog process has been
changed. Backport to the EoL branch are no longer expected to have
either CHANGES or release notes, as we aren't going to release any more
versions anyway.

Related #75

Merge branch '75-gitchangelog-9.16' into 'bind-9.16'

See merge request isc-projects/bind9!9182
2024-08-05 15:55:46 +00:00
Nicki Křížek 7ee9398e10 Remove danger checks for release notes and CHANGES
Since 9.21.0-dev, the release notes and changelog process has been
changed. Backport to the EoL branch are no longer expected to have
either CHANGES or release notes, as we aren't going to release any more
versions anyway.
2024-08-05 16:53:52 +02:00
Ondřej Surý 07077fb199 [9.16] fix: usr: Add a compatibility shim for older libuv versions (< 1.19.0)
The uv_stream_get_write_queue_size() is supported only in relatively newer versions of libuv (1.19.0 or higher).  Provide a compatibility shim for this function , so BIND 9 can be built in environments with older libuv version.

Fixes: #4822

Backport of MR !9153

Merge branch 'backport-uv_stream_get_write_queue_size_wrapper-9.16' into 'bind-9.16'

See merge request isc-projects/bind9!9248
2024-08-05 10:32:36 +00:00
JINMEI TatuyaandOndřej Surý aca98dfaa5 add a trivial wrapper for uv_stream_get_write_queue_size
(cherry picked from commit b9bef2cc89)
2024-08-05 10:31:15 +00:00