Commit Graph

26480 Commits

Author SHA1 Message Date
Michał Kępień
12bedaef75 Do not spam console if "git status --ignored" fails during tests
The "git status" command in Git versions before 1.7.2 does not support
the "--ignored" option.  Prevent spamming the console when running
system tests from a Git repository on a host with an ancient Git version
installed.

(cherry picked from commit 2be97feb46)
2018-07-13 12:15:36 +02:00
Michał Kępień
e0dbc27c0d Remove IDN subtest from the "digdelv" system test
The output of certain "dig +idnout" invocations may be locale-dependent.
Remove the "dig +idnout" subtest from the "digdelv" system test as IDN
support is already thoroughly tested by the "idna" system test.

(cherry picked from commit fd30a03f2b)
2018-07-13 12:15:36 +02:00
Michał Kępień
4fdee34a0b Improve error handling in idn_ace_to_locale()
While idn2_to_unicode_8zlz() takes a 'flags' argument, it is ignored and
thus cannot be used to perform IDN checks on the output string.

The bug in libidn2 versions before 2.0.5 was not that a call to
idn2_to_unicode_8zlz() with certain flags set did not cause IDN checks
to be performed.  The bug was that idn2_to_unicode_8zlz() did not check
whether a conversion can be performed between UTF-8 and the current
locale's character encoding.  In other words, with libidn2 version
2.0.5+, if the current locale's character encoding is ASCII, then
idn2_to_unicode_8zlz() will fail when it is passed any Punycode string
which decodes to a non-ASCII string, even if it is a valid IDNA2008
name.

Rework idn_ace_to_locale() so that invalid IDNA2008 names are properly
and consistently detected for all libidn2 versions and locales.

Update the "idna" system test accordingly.  Add checks for processing a
server response containing Punycode which decodes to an invalid IDNA2008
name.  Fix invalid subtest description.

(cherry picked from commit 7fe0f00a3b)
2018-07-13 12:15:03 +02:00
Michał Kępień
a996e26b8b Include conf.sh from all prereq.sh scripts
Every prereq.sh script must include bin/tests/system/conf.sh, otherwise
if some prerequisite is not met, errors about echo_i not being found
will be printed instead of actual error messages.

(cherry picked from commit cc0e8cda71)
2018-07-13 08:24:55 +02:00
Michał Kępień
03f2cb37f1 Update ATF path in the ./configure invocation used during CI
The Docker images used for CI install ATF to /usr, not /usr/local.
Update the ./configure invocation in .gitlab-ci.yml accordingly in order
to prevent confusion.

(cherry picked from commit 12df6829d1)
2018-07-13 08:24:50 +02:00
Michał Kępień
9506bf412f Add "-f" to command line arguments for autoreconf in autogen.sh
Depending on tool versions being used, "autoreconf -i" may not update
all Autoconf-generated files, which in turn may result in build errors.
Make autogen.sh call autoreconf with the "-f" command line argument to
ensure all Autoconf-generated files are updated when autogen.sh is run.

(cherry picked from commit 45e77a3680)
2018-07-13 08:24:34 +02:00
Ondřej Surý
71736e6af1 Merge branch 'pkcs11-missing-gitignore-v9_11' into 'v9_11'
PKCS#11 build missing some .gitignore files and ignore .gitignore files

See merge request isc-projects/bind9!515
2018-07-12 12:24:24 -04:00
Ondřej Surý
9c253f6cc8 Don't check copyrights on .gitignore files
(cherry picked from commit 718c527e1d)
2018-07-12 12:18:33 -04:00
Ondřej Surý
d4baf8b117 Add .gitignore for PKCS#11 test files
(cherry picked from commit 96907d636d)
2018-07-12 12:18:33 -04:00
Mark Andrews
594a8b22c2 Merge branch '373-generic_tostruct_tlsa-incorrectly-initialises-common-structure-v9_11' into 'v9_11'
Resolve "generic_tostruct_tlsa incorrectly initialises common structure."

See merge request isc-projects/bind9!526
2018-07-11 19:55:35 -04:00
Mark Andrews
43c6f0d801 remove re-initalisation of common structure
(cherry picked from commit 6e06d3e7c6)
2018-07-12 09:49:01 +10:00
Evan Hunt
5a059f2f4c Merge branch '403-missing-sanity-check-for-call-to-next_token-in-file-dig-c-v9_12-v9_11' into 'v9_11'
Resolve "Missing Sanity Check for call to next_token() in file 'dig.c'"

See merge request isc-projects/bind9!524
2018-07-11 15:18:32 -04:00
Evan Hunt
79e313fe9e CHANGES
(cherry picked from commit 8ae1774089)
(cherry picked from commit 6fc6b3ab69)
2018-07-11 12:12:34 -07:00
Mark Andrews
41a632bae1 add test for bad dig option '+ednsopt=:' being handled gracefully
(cherry picked from commit ad86878d61)
(cherry picked from commit 9f126bac32)
2018-07-11 12:12:32 -07:00
Bill Parker
d7d3383573 check code is non NULL
(cherry picked from commit 408bcf9c07)
(cherry picked from commit 62d047658a)
2018-07-11 12:11:46 -07:00
Evan Hunt
4990b6128b Merge branch '235-enhance-denied-logging-for-dynamic-updates-v9_11' into 'v9_11'
Add tcp-self policy tests.

See merge request isc-projects/bind9!522
2018-07-11 14:48:40 -04:00
Mukund Sivaraman
a829bb3f1b Add system tests for "tcp-self" update-policy
(cherry picked from commit a7e6a584ea)
2018-07-11 11:13:24 -07:00
Michał Kępień
bcdb6c2846 Merge branch '392-send-upstream-tat-queries-for-locally-served-zones-v9_11' into 'v9_11'
[v9_11] Trust anchor telemetry queries are not sent for locally served zones

See merge request isc-projects/bind9!517
2018-07-11 03:25:45 -04:00
Michał Kępień
3c710a851c Add CHANGES entry
4994.	[bug]		Trust anchor telemetry queries were not being sent
			upstream for locally served zones. [GL #392]

(cherry picked from commit e54cddc0c1)
2018-07-11 09:14:11 +02:00
Michał Kępień
d4a6cb321b Send upstream TAT queries for locally served zones
Trying to resolve a trust anchor telemetry query for a locally served
zone does not cause upstream queries to be sent as the response is
determined just by consulting local data.  Work around this issue by
calling dns_view_findzonecut() first in order to determine the NS RRset
for a given domain name and then passing the zone cut found to
dns_resolver_createfetch().

Note that this change only applies to TAT queries generated by the
resolver itself, not to ones received from downstream resolvers.

(cherry picked from commit 873c091408)
2018-07-11 09:14:11 +02:00
Michał Kępień
4fdd248f53 Extract TAT QNAME preparation to a separate function
Extract the part of dotat() reponsible for preparing the QNAME for a TAT
query to a separate function in order to limit the number of local
variables used by each function and improve code readability.

Rename 'name' to 'origin' to better convey the purpose of that variable.

(cherry picked from commit 2e7dd0d61f)
2018-07-11 09:14:09 +02:00
Evan Hunt
4b227d90eb Merge branch 'git-replay-merge-no-push-option-v9_12-v9_11' into 'v9_11'
Add --no-push and --push options and DONT_PUSH environment variable

See merge request isc-projects/bind9!511
2018-07-11 00:05:02 -04:00
Evan Hunt
3b97ce9f67 fixed an argument counting bug
(cherry picked from commit 458f273444)
2018-07-10 21:04:25 -07:00
Ondřej Surý
4255be661a Add --no-push and --push options and DONT_PUSH environment as default to control what happens after merge
(cherry picked from commit 23f69e5626)
(cherry picked from commit e50988255c)
2018-07-10 21:04:25 -07:00
Evan Hunt
f26ea345eb Merge branch 'ci-check-libs-v9_11' into 'v9_11'
check correctness of win32 .def files in CI 'precheck' step

See merge request isc-projects/bind9!506
2018-07-10 23:39:52 -04:00
Evan Hunt
fdee3237eb add checklibs to precheck CI step
(cherry picked from commit f74fc06ede)
2018-07-10 20:39:00 -07:00
Evan Hunt
348906e414 Merge branch 'remove-redundant-test-v9_11' into 'v9_11'
remove redundant test

See merge request isc-projects/bind9!503
2018-07-10 22:11:21 -04:00
Mark Andrews
f1f2c0c493 remove redundant test
(cherry picked from commit 6eec7fe092)
2018-07-10 19:05:12 -07:00
Evan Hunt
7903d0316d Merge branch '379-trust-anchor-telemetry-log-should-include-client-ip-address-v9_11' into 'v9_11'
Resolve "trust anchor telemetry log should include client IP address"

See merge request isc-projects/bind9!501
2018-07-10 21:37:46 -04:00
Mark Andrews
5ddff2b184 add CHANGES note 2018-07-10 18:31:04 -07:00
Mark Andrews
078962a616 fix spelling of 'telemetry'
(cherry picked from commit 4f18b6a09a)
2018-07-10 18:30:45 -07:00
Mark Andrews
40cfb519f6 use extracted netaddr rather than client->destaddr
(cherry picked from commit 69fd3f5ba4)
2018-07-10 18:29:30 -07:00
Evan Hunt
639be7f1d3 Merge branch '382-trust-anchor-telemetry-is-misspelt-in-bin-named-log-c-in-9-11-and-earlier' into 'v9_11'
Resolve "trust-anchor-telemetry is misspelt in bin/named/log.c in 9.11 and earlier."

See merge request isc-projects/bind9!477
2018-07-10 21:12:20 -04:00
Mark Andrews
b2ccc58206 fix category trust-anchor-telemetry spelling 2018-07-10 18:11:02 -07:00
Evan Hunt
a7865cdc4b Merge branch '378-run-xmllint-on-xml-and-docbook-in-precheck-v9_11' into 'v9_11'
Check correctness of *.xml, *.docbook, and *.html during precheck

See merge request isc-projects/bind9!499
2018-07-10 20:57:22 -04:00
Mark Andrews
d846e59a62 Resolve "run xmllint on *.xml and *.docbook in precheck"
(cherry picked from commit bb1937aaec)
2018-07-10 17:50:15 -07:00
Evan Hunt
e8e6734a3a Merge branch '401-null-pointer-de-reference-found-in-bind-9-12-1-p2-v9_11' into 'v9_11'
Resolve "NULL Pointer de-reference found in BIND 9.12.1-P2"

See merge request isc-projects/bind9!496
2018-07-10 17:46:02 -04:00
Evan Hunt
28544ada3e CHANGES 2018-07-10 14:39:53 -07:00
Bill Parker
48aa0659f7 check param_template[i].pValue is non NULL
(cherry picked from commit 8ac0152651)
2018-07-10 14:39:30 -07:00
Michał Kępień
e6dc9bc382 Merge branch '393-fix-a-net-dns-version-quirk-in-the-resolver-system-test-v9_11' into 'v9_11'
[v9_11] Fix a Net::DNS version quirk in the "resolver" system test

See merge request isc-projects/bind9!493
2018-07-10 09:14:46 -04:00
Michał Kępień
740b3a9118 Fix a Net::DNS version quirk in the "resolver" system test
Net::DNS versions older than 0.68 insert a ./ANY RR into the QUESTION
section if the latter is empty.  Since the latest Net::DNS version
available with stock RHEL/CentOS 6 packages is 0.65 and we officially
support that operating system, bin/tests/system/resolver/ans8/ans.pl
should behave consistently for various Net::DNS versions.  Ensure that
by making handleUDP() return the query ID and flags generated by
Net::DNS with 8 zero bytes appended.

(cherry picked from commit 6c3c6aea37)
2018-07-10 15:08:05 +02:00
Mark Andrews
5276f1d90e Merge branch '402-memory-leak-found-in-file-fuzz-c-in-bind-9-12-1-p2-v9_11' into 'v9_11'
Resolve "Memory Leak found in file 'fuzz.c' in BIND-9.12.1-P2"

See merge request isc-projects/bind9!490
2018-07-10 01:13:58 -04:00
Mark Andrews
6fbbe4ef7e free rbuf
(cherry picked from commit ecb2f20324)
2018-07-10 14:38:05 +10:00
Evan Hunt
2fe4344de4 Merge branch 'prep-release-v9_11_4' into 'v9_11'
prep 9.11.4

See merge request isc-projects/bind9!471
v9.11.4
2018-07-03 02:56:55 -04:00
Tinderbox User
20f8b9a91f prep 9.11.4 2018-07-03 06:50:01 +00:00
Evan Hunt
644915b508 Merge branch 'fix-readme-v9_11' into 'v9_11'
Fix README typo

See merge request isc-projects/bind9!464
2018-07-02 20:18:08 -04:00
Evan Hunt
a4717005b1 9.11.4 was incorrectly referred to as 9.11.3 2018-07-02 17:14:25 -07:00
Evan Hunt
0de0733307 Merge branch 'prep-release-v9_11_4rc2' into 'v9_11'
prep 9.11.4rc2

See merge request isc-projects/bind9!451
v9.11.4rc2
2018-06-28 01:25:28 -04:00
Tinderbox User
3bbd725a2c prep 9.11.4rc2 2018-06-28 05:07:42 +00:00
Evan Hunt
2d46759916 Merge branch '339-issues-with-large-journal-entries-v9_11' into 'v9_11'
Fix handling of large journal entries.

See merge request isc-projects/bind9!445
2018-06-27 21:46:57 -04:00