Commit Graph
32001 Commits
Author SHA1 Message Date
Mark AndrewsandOndřej Surý 06b76b2b16 Check LOC's altitude field is properly parsed and encoded.
(cherry picked from commit 888dfd78c7)
2020-08-26 16:44:00 +02:00
Mark AndrewsandOndřej Surý 7eb5d61703 Tighten LOC parsing to reject period and/or m as a value.
(cherry picked from commit 9225c67835)
2020-08-26 16:44:00 +02:00
Mark Andrews 92a13be6a0 Merge branch '2080-data-race-in-rdataset_addglue-v9_16' into 'v9_16'
Resolve "data race in rdataset_addglue"

See merge request isc-projects/bind9!4020
2020-08-26 12:18:35 +00:00
Mark Andrews c37fd4ac56 Add CHANGES note
(cherry picked from commit 48973c3ec6)
2020-08-26 21:51:33 +10:00
Ondřej SurýandMark Andrews 5674f76590 Use the Fibonacci Hashing for the RBTDB glue table
The rbtdb version glue_table has been refactored similarly to rbt.c hash
table, so it does use 32-bit hash function return values and apply
Fibonacci Hashing to lookup the index to the hash table instead of
modulo.  For more details, see the lib/dns/rbt.c commit log.

(cherry picked from commit 01684cc219)
2020-08-26 21:49:59 +10:00
Mark Andrews 511747307f rbtversion->glue_table_size must be read when holding a lock
(cherry picked from commit 33d0e8d168)
2020-08-26 21:49:59 +10:00
Michal Nowak b1526940f4 Merge branch 'mnowak/tumbleweed-fix-krb5-config-location-v9_16' into 'v9_16'
[v9_16] Tumbleweed changed location of krb5-config

See merge request isc-projects/bind9!4018
2020-08-26 09:04:45 +00:00
Michal Nowak 9a305e0d47 Tumbleweed changed location of krb5-config
krb5-config is now in /usr/bin/ and we should detect it automatically.

(cherry picked from commit 6095811461)
2020-08-26 10:59:29 +02:00
Ondřej Surý 48c757eb79 Merge branch '2095-shifting-large-rcode-in-dns-message-c-results-in-undefined-behaviour-v9_16' into 'v9_16'
Cast the original rcode to (dns_ttl_t) when setting extended rcode

See merge request isc-projects/bind9!4014
2020-08-25 19:00:50 +00:00
Mark AndrewsandOndřej Surý 3fce53b0e3 Cast the original rcode to (dns_ttl_t) when setting extended rcode
Shifting (signed) integer left could trigger undefined behaviour when
the shifted value would overflow into the sign bit (e.g. 2048).

The issue was found when using AFL++ and UBSAN:

    message.c:2274:33: runtime error: left shift of 2048 by 20 places cannot be represented in type 'int'
    SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior message.c:2274:33 in

(cherry picked from commit a347641782)
2020-08-25 16:40:42 +02:00
Michal Nowak fbcff0ab14 Merge branch '2053-test-disable-buffer-useinline-in-gitlab-ci-v9_16' into 'v9_16'
[v9_16] Resolve "Test --disable-buffer-useinline in GitLab CI"

See merge request isc-projects/bind9!4012
2020-08-25 14:28:35 +00:00
Michal Nowak a0e55857c7 Build CentOS 8 with --enable-buffer-useinline
(cherry picked from commit f34df4ef90)
2020-08-25 16:08:47 +02:00
Michal Nowak 79e8f1076a Fix warnings in when build with --enable-buffer-useinline
sockaddr.c:147:49: error: pointer targets in passing argument 2 of ‘isc__buffer_putmem’ differ in signedness
    rdata.c:1780:30: error: pointer targets in passing argument 2 of ‘isc__buffer_putmem’ differ in signedness

(cherry picked from commit dd425254a7)
2020-08-25 16:08:44 +02:00
Mark Andrews 92d4a23f28 Merge branch 'marka-add-missing-isc_mutex_init-v9_16' into 'v9_16'
Add missing isc_mutex_init to manytasks subtest.

See merge request isc-projects/bind9!4007
2020-08-25 00:21:27 +00:00
Mark Andrews dd5be2940c add missing copyright entry 2020-08-25 10:01:28 +10:00
Mark Andrews da4f189ea8 Add missing isc_mutex_init to manytasks subtest.
(cherry picked from commit 2eb5c29c83)
2020-08-25 09:58:30 +10:00
Michal Nowak 38fc4b11e2 Merge branch 'mnowak/update_BIND_BASELINE_VERSION_to_v9_16_6' into 'v9_16'
Update BIND_BASELINE_VERSION to v9_16_6

See merge request isc-projects/bind9!4000
2020-08-21 09:30:06 +00:00
Michal Nowak e9d9c88747 Update BIND_BASELINE_VERSION to v9_16_6 2020-08-21 11:23:59 +02:00
Evan Hunt 1c7e3c8515 Merge tag 'v9_16_6' into v9_16
BIND 9.16.6
2020-08-20 12:08:57 -07:00
Mark Andrews 845bd649ed Merge branch '2077-negative-hook-point-value-in-filter-aaaa-c-v9_16' into 'v9_16'
Remove stray '-' from filter-aaaa initialisation

See merge request isc-projects/bind9!3986
2020-08-19 00:40:53 +00:00
Mark Andrews 590328178c Remove stray '-' from filter-aaaa initialisation
(cherry picked from commit 2fd5ba6507)
2020-08-19 10:18:47 +10:00
Michal Nowak 56e24987ee Merge branch 'mnowak/add-missing-only-schedules-v9_16' into 'v9_16'
[v9_16] Add missing 'only:schedules' to tarball-create job

See merge request isc-projects/bind9!3978
2020-08-18 09:36:16 +00:00
Michal Nowak 816a72889a Add missing 'only:schedules' to tarball-create job
Missing 'only:schedules' prevents schedule jobs to run.
Regressed in 2b5007ef1a.

(cherry picked from commit b3c80fafe0)
2020-08-18 11:35:05 +02:00
Ondřej Surý 6f9487c51b Merge branch 'marka-fuzz-consolidated-v9_16' into 'v9_16'
Consolidated fuzz fixes (v9.16)

See merge request isc-projects/bind9!3976
2020-08-18 09:32:01 +00:00
Mark AndrewsandOndřej Surý d8a57d32b1 A6: return FORMERR in fromwire if bits are non zero.
oss_fuzz: Issue 24864: bind9:dns_rdata_fromwire_text_fuzzer: Overwrites-const-input in dns_rdata_fromwire_text_fuzzer

(cherry picked from commit 8452404bd7)
2020-08-18 11:11:40 +02:00
Mark AndrewsandOndřej Surý 6b1675a62c RRSIG: reject records with empty SIG section
(cherry picked from commit f6d7b8c20d)
2020-08-18 11:11:40 +02:00
Mark AndrewsandOndřej Surý f6d64fb2c8 Disable compression in dns_rdata_fromwire_text()
(cherry picked from commit 3e743da1bd)
2020-08-18 11:11:39 +02:00
Mark AndrewsandOndřej Surý 8ed9da7324 dns_rdata_fromwire() only accepts input up to 2^16-1 octets.
(cherry picked from commit aa811801cb)
2020-08-18 11:11:36 +02:00
Mark AndrewsandOndřej Surý 6aa46945ff Print out input if dns_rdata_fromtext() fails in debug mode.
(cherry picked from commit e4d30cb007)
2020-08-18 11:11:10 +02:00
Michal Nowak 0421ea1259 Merge branch 'mnowak/gcovr-v9_16' into 'v9_16'
[v9_16] Report coverage with gcovr

See merge request isc-projects/bind9!3973
2020-08-17 15:27:29 +00:00
Michal Nowak 764087eb19 Report coverage with gcovr 2020-08-17 16:55:26 +02:00
Michal Nowak c5dc650b63 Merge branch 'mnowak/broaden-abi-check-scope-v9_16' into 'v9_16'
[v9_16] Broaden scope of abi-check

See merge request isc-projects/bind9!3971
2020-08-17 13:14:08 +00:00
Michal Nowak a1227c3376 Broaden scope of abi-check
For abi-check we should use as broad 'configure' options as possible.

(cherry picked from commit 8e43f5e860)
2020-08-17 15:10:48 +02:00
Mark Andrews 156df0f808 Merge branch 'patch-3-v9_16' into 'v9_16'
Option -s is not supported in tsig-keygen

See merge request isc-projects/bind9!3968
2020-08-17 04:02:06 +00:00
JP MensandMark Andrews d2e1c8c75e Option -s is not supported in tsig-keygen
(cherry picked from commit b01d26c608)
2020-08-17 12:39:50 +10:00
Mark Andrews 5a4c7a8015 Merge branch 'marka-fuzz-fixes-v9_16' into 'v9_16'
Marka fuzz fixes v9 16

See merge request isc-projects/bind9!3957
2020-08-13 15:51:43 +00:00
Mark Andrews 9af25fbc26 Add CHANGES note
(cherry picked from commit 80d69ba04c)
2020-08-14 00:38:45 +10:00
Mark Andrews 96096adc46 Add previously detected dns_rdata_fromwire_text failures
(cherry picked from commit 7ae055cef1)
2020-08-14 00:38:45 +10:00
Mark Andrews 9675d83b96 X25: Check that record is all ASCII digits
(cherry picked from commit 7e49689746)
2020-08-14 00:38:45 +10:00
Mark Andrews ee10a93cbc WKS: reject records with zero octets at the end of the bitmap
(cherry picked from commit 9d446142d8)
2020-08-14 00:38:45 +10:00
Mark Andrews e44da35092 TLSA: fix fromwire length checks
(cherry picked from commit 3429c35f52)
2020-08-14 00:38:45 +10:00
Mark Andrews b4a66cffa8 SIG: reject records with a zero length signature
(cherry picked from commit 9b93e5d684)
2020-08-14 00:38:45 +10:00
Mark Andrews 10e8ad22c5 NXT: fix fromwire bitmap checks
(cherry picked from commit 73dd849655)
2020-08-14 00:38:45 +10:00
Mark Andrews c712394b34 NSEC3PARAM: check that saltlen is consistent with the rdata length
(cherry picked from commit 7dc8e720ff)
2020-08-14 00:38:45 +10:00
Mark Andrews 26be6c817b NSEC3: reject records with a zero length hash field
(cherry picked from commit 031ee9e279)
2020-08-14 00:38:45 +10:00
Mark Andrews ebd8033a96 IPSECKEY: require non-zero length public keys
(cherry picked from commit d7f7014803)
2020-08-14 00:38:45 +10:00
Mark Andrews baf7d114af CERT: reject records with a empty certificate field
(cherry picked from commit a238f37239)
2020-08-14 00:38:45 +10:00
Mark Andrews f09691feff Get rid of type 'RESERVED0'.
(cherry picked from commit 3c492b3ef1)
2020-08-14 00:38:45 +10:00
Mark Andrews 0c95100f98 dns_rdata_fromwire_text fixes:
* Disallow compression pointers in names as we are not
  reading from a packet and as a result length checks fail.
* Increase totext buffer size as fuzzer ran out of space on
  big bitmaps.
* NUL terminate totext to make fault diagnosis easier.
* Add debugging messages to make fault diagnosie easier.

(cherry picked from commit a92d973430)
2020-08-14 00:38:45 +10:00
Mark Andrews 5806d856cf base32_decode*() could incorrectly decode a input.
base32_decode_char() added a extra zero octet to the output
if the fifth character was a pad character.  The length
of octets to copy to the output was set to 3 instead of 2.

(cherry picked from commit 6c7e50c267)
2020-08-14 00:11:06 +10:00