ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

665. [bug] Signed responses were not sent when the size of the

Browse Source 
TSIG + question exceeded the maximum message size.
                        [RT #628]
This commit is contained in:
Brian Wellington
2001-01-08 20:36:14 +00:00
parent c26c349eab
commit fff07c1022
3 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGES
View File

@@ -1,3 +1,6 @@
665. [bug] Signed responses were not sent when the size of the
TSIG + question exceeded the maximum message size.
[RT #628]
664. [bug] The t_tasks and t_timers module tests are now skipped
when building without threads, since they require

6
bin/named/client.c
View File

@@ -15,7 +15,7 @@
* WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
/* $Id: client.c,v 1.136 2000/12/19 19:21:39 gson Exp $ */
/* $Id: client.c,v 1.137 2001/01/08 20:36:10 bwelling Exp $ */
#include <config.h>
@@ -835,6 +835,10 @@ ns_client_send(ns_client_t *client) {
}
result = dns_message_rendersection(client->message,
DNS_SECTION_QUESTION, 0);
if (result == ISC_R_NOSPACE) {
client->message->flags |= DNS_MESSAGEFLAG_TC;
goto renderend;
}
if (result != ISC_R_SUCCESS)
goto done;
result = dns_message_rendersection(client->message,

7
lib/dns/message.c
View File

@@ -15,7 +15,7 @@
* WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
/* $Id: message.c,v 1.168 2001/01/05 00:17:29 bwelling Exp $ */
/* $Id: message.c,v 1.169 2001/01/08 20:36:11 bwelling Exp $ */
/***
*** Imports
@@ -1882,7 +1882,8 @@ dns_message_renderend(dns_message_t *msg) {
/*
* If we're adding a TSIG or SIG(0) to a truncated message,
* clear all rdatasets from the message except for the question
* before adding the TSIG or SIG(0).
* before adding the TSIG or SIG(0). If the question doesn't fit,
* don't include it.
*/
if ((msg->tsigkey != NULL || msg->sig0key != NULL) &&
(msg->flags & DNS_MESSAGEFLAG_TC) != 0)
@@ -1898,7 +1899,7 @@ dns_message_renderend(dns_message_t *msg) {
dns_compress_rollback(&msg->cctx, 0);
result = dns_message_rendersection(msg, DNS_SECTION_QUESTION,
0);
if (result != ISC_R_SUCCESS)
if (result != ISC_R_SUCCESS && result != ISC_R_NOSPACE)
return (result);
}