ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Removed unnecessary check (mpctx->items == NULL)

Browse Source 
There is no possibility for mpctx->items to be NULL at the point where
the code was removed, since we enforce that fillcount > 0, if
mpctx->items == NULL when isc_mempool_get is called, then we will
allocate fillcount more items and add to the mpctx->items list.
This commit is contained in:
Diego Fronza
2021-04-01 16:48:16 -03:00
parent 19df09d225
commit efb9c540cd
1 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/isc/mem.c
View File

@@ -1366,15 +1366,7 @@ isc__mempool_get(isc_mempool_t *mpctx FLARG) {
}
}
/*
* If we didn't get any items, return NULL.
*/
item = mpctx->items;
if (ISC_UNLIKELY(item == NULL)) {
atomic_fetch_sub_release(&mpctx->allocated, 1);
goto out;
}
mpctx->items = item->next;
INSIST(atomic_fetch_sub_release(&mpctx->freecount, 1) > 0);
@@ -1382,7 +1374,6 @@ isc__mempool_get(isc_mempool_t *mpctx FLARG) {
ADD_TRACE(mpctx->mctx, item, mpctx->size, file, line);
out:
MPCTXUNLOCK(mpctx);
return (item);