ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

client manager cleanup could access freed memory

Browse Source
This commit is contained in:
Andreas Gustafsson
2000-01-18 18:07:07 +00:00
parent 1a087ddc8f
commit d468db05b3
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
bin/named/client.c
View File

@@ -113,7 +113,8 @@ release_quotas(ns_client_t *client) {
static void
maybe_free(ns_client_t *client) {
isc_boolean_t need_clientmgr_destroy = ISC_FALSE;
ns_clientmgr_t *manager;
REQUIRE(NS_CLIENT_VALID(client));
/*
@@ -181,7 +182,7 @@ maybe_free(ns_client_t *client) {
if (client->task != NULL)
isc_task_detach(&client->task);
if (client->manager != NULL) {
ns_clientmgr_t *manager = client->manager;
manager = client->manager;
LOCK(&manager->lock);
INSIST(manager->nclients > 0);
@@ -200,7 +201,7 @@ maybe_free(ns_client_t *client) {
isc_mem_put(client->mctx, client, sizeof *client);
if (need_clientmgr_destroy)
clientmgr_destroy(client->manager);
clientmgr_destroy(manager);
}
/*