ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

lib/ns/query.c: Fix invalid order of DbC checks that could cause dereference before NULL check

Browse Source
This commit is contained in:
Ondřej Surý
2019-09-27 12:12:14 +02:00
parent 033f3eb580
commit d1f035bbba
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/ns/query.c
View File

@@ -10930,15 +10930,19 @@ log_queryerror(ns_client_t *client, isc_result_t result, int line, int level) {
void
ns_query_start(ns_client_t *client) {
isc_result_t result;
dns_message_t *message = client->message;
dns_message_t *message;
dns_rdataset_t *rdataset;
ns_client_t *qclient;
dns_rdatatype_t qtype;
unsigned int saved_extflags = client->extflags;
unsigned int saved_flags = client->message->flags;
unsigned int saved_extflags;
unsigned int saved_flags;
REQUIRE(NS_CLIENT_VALID(client));
message = client->message;
saved_extflags = client->extflags;
saved_flags = client->message->flags;
CTRACE(ISC_LOG_DEBUG(3), "ns_query_start");
/*