ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

[9.20] fix: dev: CID 498025 and CID 498031: Overflowed constant INTEGER_OVERFLOW

Browse Source 
Add INSIST to fail if the multiplication would cause the variables to overflow.

Closes #4798

Backport of MR !9131

Merge branch 'backport-4798-cid-498025-and-cid-498031-overflowed-constant-integer_overflow-9.20' into 'bind-9.20'

See merge request isc-projects/bind9!9229
This commit is contained in:
Mark Andrews
2024-08-05 01:09:34 +00:00
parent 7939166564 25466b18a2
commit b6298b394e
2 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
bin/dig/host.c
View File

@@ -183,6 +183,7 @@ retry:
result = dns_rdata_totext(rdata, NULL, b);
if (result == ISC_R_NOSPACE) {
isc_buffer_free(&b);
INSIST(bufsize <= (UINT_MAX / 2));
bufsize *= 2;
goto retry;
}

1
bin/dig/nslookup.c
View File

@@ -189,6 +189,7 @@ printrdata(dns_rdata_t *rdata) {
check_result(result, "dns_rdata_totext");
}
isc_buffer_free(&b);
INSIST(size <= (UINT_MAX / 2));
size *= 2;
}
}