ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Fix a logical flaw that would skip logging notify success

Browse Source 
The notify_done() would never log a success as the logging part was
always skipped.  Fix the code flow in the function.
This commit is contained in:
Ondřej Surý
2023-05-03 08:15:31 +02:00
parent d4cf522d65
commit b3c6ee7b9a
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/dns/zone.c
View File

@@ -15802,17 +15802,14 @@ notify_done(void *arg) {
(int)buf.used, rcode);
}
dns_message_detach(&message);
goto done;
fail:
dns_message_detach(&message);
if (result == ISC_R_SUCCESS) {
notify_log(notify->zone, ISC_LOG_INFO,
notify_log(notify->zone, ISC_LOG_DEBUG(1),
"notify to %s successful", addrbuf);
} else if (result == ISC_R_SHUTTINGDOWN || result == ISC_R_CANCELED) {
goto done;
/* just destroy the notify */
} else if ((notify->flags & DNS_NOTIFY_TCP) == 0) {
notify_log(notify->zone, ISC_LOG_NOTICE,
"notify to %s failed: %s: retrying over TCP",
@@ -15830,7 +15827,6 @@ fail:
"notify to %s failed: %s", addrbuf,
isc_result_totext(result));
}
done:
notify_destroy(notify, false);
}