ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Fix RPZ reference counting error on shutdown

Browse Source 
A dns_rpz_unref_rpzs() call is missing when taking the 'goto unlock;'
path on shutdown, in order to compensate for the earlier
dns_rpz_ref_rpzs() call.

Move the dns_rpz_ref_rpzs() call after the shutdown check.
This commit is contained in:
Aram Sargsyan
2023-02-13 14:47:09 +00:00
parent b274d388f1
commit afbe63565f
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/dns/rpz.c
View File

@@ -1945,8 +1945,6 @@ dns__rpz_timer_cb(void *arg) {
REQUIRE(rpz->updb == NULL);
REQUIRE(rpz->updbversion == NULL);
dns_rpz_ref_rpzs(rpz->rpzs);
LOCK(&rpz->rpzs->maint_lock);
if (rpz->rpzs->shuttingdown) {
@@ -1966,6 +1964,7 @@ dns__rpz_timer_cb(void *arg) {
isc_log_write(dns_lctx, DNS_LOGCATEGORY_GENERAL, DNS_LOGMODULE_MASTER,
ISC_LOG_INFO, "rpz: %s: reload start", domain);
dns_rpz_ref_rpzs(rpz->rpzs);
isc_work_enqueue(rpz->loop, update_rpz_cb, update_rpz_done_cb, rpz);
isc_timer_destroy(&rpz->updatetimer);