ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Use attach()/detach() functions instead of touching .references

Browse Source 
In rbtdb.c, there were two places where the code touched .references
directly instead of using the helper functions.  Use the helper
functions instead.
This commit is contained in:
Ondřej Surý
2024-11-27 21:17:22 +01:00
parent 60be885c9b
commit a4e3d25652
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/dns/rbtdb.c
+2 -5
View File
@@ -2483,10 +2483,7 @@ cleanup_dead_nodes_callback(isc_task_t *task, isc_event_t *event) {
isc_task_send(task, &event);
} else {
isc_event_free(&event);
if (isc_refcount_decrement(&rbtdb->references) == 1) {
(void)isc_refcount_current(&rbtdb->references);
maybe_free_rbtdb(rbtdb);
}
detach((dns_db_t **)&rbtdb);
}
}
@@ -2749,7 +2746,7 @@ closeversion(dns_db_t *db, dns_dbversion_t **versionp, bool commit) {
sizeof(*changed));
}
if (event != NULL) {
isc_refcount_increment(&rbtdb->references);
attach((dns_db_t *)rbtdb, &(dns_db_t *){ NULL });
isc_task_send(rbtdb->task, &event);
} else {
RWUNLOCK(&rbtdb->tree_lock, isc_rwlocktype_write);