Merge branch 'ci-check-libs' into 'master'

check correctness of win32 .def files in CI 'precheck' step

See merge request isc-projects/bind9!455

.gitlab-ci.yml

@@ -140,6 +140,7 @@ precheck:debian:sid:amd64:
   <<: *debian_sid_amd64_image
   stage: precheck
   script:
+    - sh util/checklibs.sh > checklibs.out
     - perl util/check-changes CHANGES
     - perl -w util/merge_copyrights
     - diff -urNap util/copyrights util/newcopyrights
@@ -149,6 +150,7 @@ precheck:debian:sid:amd64:
   artifacts:
     paths:
     - util/newcopyrights
+    - checklibs.out
     expire_in: '1 week'
     when: on_failure
 

util/checklibs.sh

@@ -25,20 +25,6 @@ list=`git grep -l snprintf lib bin |
     echo "$list"
 }
 
-#
-# Check for missing #include <isc/string.h>"
-#
-list=`git grep -lw strsep lib bin |
-      grep '\.c$' |
-      grep -vE -e '(lib/bind|lib/dns/rdata|lib/dns/gen.c)' \
-	       -e '(lib/isc/win32/time.c)' |
-      xargs grep -L "<isc/string.h>"`
-[ -n "$list" ] && {
-    status=1
-    echo 'Missing #include <isc/string.h>:'
-    echo "$list"
-}
-
 #
 # Check for missing #include <inttypes.h>"
 #