ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

BN_free() and BN_clear_free() both accept NULL

Browse Source 
Remove the extra check in opensslrsa_components_free() as both BN_free()
and BN_clear_free() both accepts NULL as valid argument and do nothing.
This commit is contained in:
Ondřej Surý
2023-01-09 16:00:18 +01:00
parent edd1b44d0b
commit 9e185cd611
1 changed files with 15 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
lib/dns/opensslrsa_link.c
View File

@@ -144,30 +144,21 @@ opensslrsa_components_free(rsa_components_t *c) {
if (!c->bnfree) {
return;
}
if (c->e != NULL) {
BN_free((BIGNUM *)c->e);
}
if (c->n != NULL) {
BN_free((BIGNUM *)c->n);
}
if (c->d != NULL) {
BN_clear_free((BIGNUM *)c->d);
}
if (c->p != NULL) {
BN_clear_free((BIGNUM *)c->p);
}
if (c->q != NULL) {
BN_clear_free((BIGNUM *)c->q);
}
if (c->dmp1 != NULL) {
BN_clear_free((BIGNUM *)c->dmp1);
}
if (c->dmq1 != NULL) {
BN_clear_free((BIGNUM *)c->dmq1);
}
if (c->iqmp != NULL) {
BN_clear_free((BIGNUM *)c->iqmp);
}
/*
* NOTE: BN_free() frees the components of the BIGNUM, and if it was
* created by BN_new(), also the structure itself. BN_clear_free()
* additionally overwrites the data before the memory is returned to the
* system. If a is NULL, nothing is done.
*/
BN_free((BIGNUM *)c->e);
BN_free((BIGNUM *)c->n);
BN_clear_free((BIGNUM *)c->d);
BN_clear_free((BIGNUM *)c->p);
BN_clear_free((BIGNUM *)c->q);
BN_clear_free((BIGNUM *)c->dmp1);
BN_clear_free((BIGNUM *)c->dmq1);
BN_clear_free((BIGNUM *)c->iqmp);
c->bnfree = false;
}
static bool