ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Add missing isc_refcount_*() calls

Browse Source 
Commits 76bcb4d16b and
d48d8e1cf0 did not include
isc_refcount_destroy() calls that would be logical counterparts of the
isc_refcount_init() calls these commits added.  Add the missing
isc_refcount_destroy() calls to destroy().

Adding these calls (which ensure a given structure's reference count
equals 0 when it is destroyed, therefore detecting reference counting
issues) uncovered another flaw in the commits mentioned above: missing
isc_refcount_decrement() calls that would be logical counterparts of the
isc_refcount_increment*() calls these commits added.  Add the missing
isc_refcount_decrement() calls to unlink_name() and unlink_entry().
This commit is contained in:
Evan Hunt
2022-07-04 16:02:12 +02:00
committed by Michał Kępień
parent ef86653d80
commit 975a5a98cf
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/dns/adb.c
View File

@@ -871,6 +871,8 @@ unlink_name(dns_adbname_t *name) {
} else {
ISC_LIST_UNLINK(nbucket->names, name, plink);
}
isc_refcount_decrement(&nbucket->references);
}
/*
@@ -944,6 +946,8 @@ unlink_entry(dns_adbentry_t *entry) {
} else {
ISC_LIST_UNLINK(ebucket->entries, entry, plink);
}
isc_refcount_decrement(&ebucket->references);
}
static void
@@ -2056,6 +2060,7 @@ destroy(dns_adb_t *adb) {
isc_ht_iter_current(it, (void **)&nbucket);
cleanup_names(nbucket, INT_MAX);
isc_mutex_destroy(&nbucket->lock);
isc_refcount_destroy(&nbucket->references);
isc_mem_put(adb->mctx, nbucket, sizeof(*nbucket));
}
isc_ht_iter_destroy(&it);
@@ -2072,6 +2077,7 @@ destroy(dns_adb_t *adb) {
isc_ht_iter_current(it, (void **)&ebucket);
cleanup_entries(ebucket, INT_MAX);
isc_mutex_destroy(&ebucket->lock);
isc_refcount_destroy(&ebucket->references);
isc_mem_put(adb->mctx, ebucket, sizeof(*ebucket));
}
isc_ht_iter_destroy(&it);
@@ -2080,6 +2086,7 @@ destroy(dns_adb_t *adb) {
isc_rwlock_destroy(&adb->entries_lock);
isc_mutex_destroy(&adb->lock);
isc_refcount_destroy(&adb->references);
isc_task_detach(&adb->task);
isc_stats_detach(&adb->stats);