ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Fix a function cleanup bug in dns_request_createraw

Browse Source 
When get_dispatch() returns an error code, the dns_request_createraw()
function jumps to the `cleanup` label, which will leave a previous
attachment to the `request` pointer unattached.

Fix the issue by jumping to the `detach` label instead.
This commit is contained in:
Aram Sargsyan
2022-03-07 11:24:09 +00:00
parent e229d46a87
commit 963f6a2203
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/dns/request.c
View File

@@ -558,7 +558,7 @@ again:
result = get_dispatch(tcp, newtcp, requestmgr, srcaddr, destaddr, dscp,
&connected, &request->dispatch);
if (result != ISC_R_SUCCESS) {
goto cleanup;
goto detach;
}
if ((options & DNS_REQUESTOPT_FIXEDID) != 0) {