don't try to remove newline from the output

of dns_rdataset_totext() if it returned failure

CHANGES

@@ -1,4 +1,8 @@
 
+ 371.	[bug]		At high debug levels, doing an outgoing zone transfer
+			of a very large RRset could cause an assertion failure
+			during logging.
+
  370.	[bug]		The error messages for rollforward failures were
 			overly terse.
 

bin/named/xfrout.c

@@ -15,7 +15,7 @@
  * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: xfrout.c,v 1.70 2000/08/01 01:12:01 tale Exp $ */
+/* $Id: xfrout.c,v 1.71 2000/08/07 20:39:10 gson Exp $ */
 
 #include <config.h>
 
@@ -263,15 +263,16 @@ log_rr(dns_name_t *name, dns_rdata_t *rdata, isc_uint32_t ttl) {
 	result = dns_rdataset_totext(&rds, name,
 				     ISC_FALSE, ISC_FALSE, &buf);
 
-	/* Get rid of final newline. */
-	INSIST(buf.used >= 1 && ((char *) buf.base)[buf.used-1] == '\n');
-	buf.used--;
-
 	/*
 	 * We could use xfrout_log(), but that would produce
 	 * very long lines with a repetitive prefix.
 	 */
 	if (result == ISC_R_SUCCESS) {
+		/* Get rid of final newline. */
+		INSIST(buf.used >= 1 &&
+		       ((char *) buf.base)[buf.used-1] == '\n');
+		buf.used--;
+		
 		isc_buffer_usedregion(&buf, &r);
 		isc_log_write(XFROUT_DEBUG_LOGARGS(8),
 			      "%.*s", (int) r.length, (char *) r.base);