ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Do not call nghttp2_session_terminate_session() in server-side code

Browse Source 
We should not call nghttp2_session_terminate_session() in server-side
code after all of the active HTTP/2 streams are processed. The
underlying transport connection is expected to remain opened at least
for some time in this case for new HTTP/2 requests to arrive. That is
what flamethrower was expecting and it makes perfect sense from the
HTTP/2 perspective.
This commit is contained in:
Artem Boldariev
2021-05-12 11:48:13 +03:00
parent 4d888458ab
commit 9155a87528
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/isc/netmgr/http.c
View File

@@ -562,10 +562,6 @@ on_server_stream_close_callback(int32_t stream_id,
int rv = 0;
ISC_LIST_UNLINK(session->sstreams, &sock->h2, link);
if (ISC_LIST_EMPTY(session->sstreams)) {
rv = nghttp2_session_terminate_session(session->ngsession,
NGHTTP2_NO_ERROR);
}
session->nsstreams--;
isc__nmsocket_detach(&sock);
return (rv);