ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

4312. [bug] dig's unknown dns and edns flags (MBZ value) logging

Browse Source 
was not consistent. [RT #41600]
This commit is contained in:
Mark Andrews
2016-02-02 14:19:22 +11:00
parent e370cdf4ba
commit 8d00c5ab2c
3 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGES
View File

@@ -1,3 +1,6 @@
4312. [bug] dig's unknown dns and edns flags (MBZ value) logging
was not consistent. [RT #41600]
4311. [bug] Prevent "rndc delzone" from being used on
response-policy zones. [RT #41593]

4
bin/tests/system/ednscompliance/tests.sh
View File

@@ -38,10 +38,10 @@ if [ $ret != 0 ]; then echo "I:failed $reason"; fi
status=`expr $status + $ret`
n=`expr $n + 1`
echo "I:check +ednsflags=0x80 sets flags to 0080 ($n)"
echo "I:check +ednsflags=0x80 sets flags to 0x0080 ($n)"
ret=0 reason=
$DIG -p 5300 @10.53.0.1 +qr +norec +ednsflags=0x80 soa $zone > dig.out$n
grep "MBZ: 0080" dig.out$n > /dev/null || { ret=1; reason="flags"; }
grep "MBZ: 0x0080," dig.out$n > /dev/null || { ret=1; reason="flags"; }
if [ $ret != 0 ]; then echo "I:failed $reason"; fi
status=`expr $status + $ret`

2
lib/dns/message.c
View File

@@ -3327,7 +3327,7 @@ dns_message_pseudosectiontotext(dns_message_t *msg,
mbz &= ~DNS_MESSAGEEXTFLAG_DO; /* Known Flags. */
if (mbz != 0) {
ADD_STRING(target, "; MBZ: ");
snprintf(buf, sizeof(buf), "%.4x ", mbz);
snprintf(buf, sizeof(buf), "0x%.4x", mbz);
ADD_STRING(target, buf);
ADD_STRING(target, ", udp: ");
} else