ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

silence coverity warnings

Browse Source 
silence coverity warnings in the DNSPRS code:
- CID 451097, failure to check return value of rpz_ready()
- CID 451099, resource leak
This commit is contained in:
Evan Hunt
2023-04-03 12:18:11 -07:00
committed by Ondřej Surý
parent 7e17ed410e
commit 80e2a23f9e
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/dns/include/dns/librpz.h
View File

@@ -887,6 +887,7 @@ librpz_lib_open(librpz_emsg_t *emsg, void **dl_handle, const char *path) {
if (new_librpz != NULL) {
if (dl_handle != NULL) {
*dl_handle = handle;
handle = NULL;
}
return (new_librpz);
}
@@ -914,6 +915,7 @@ librpz_lib_open(librpz_emsg_t *emsg, void **dl_handle, const char *path) {
if (new_librpz != NULL) {
if (dl_handle != NULL) {
*dl_handle = handle;
handle = NULL;
}
return (new_librpz);
}

5
lib/ns/query.c
View File

@@ -3439,7 +3439,10 @@ dnsrps_set_p(librpz_emsg_t *emsg, ns_client_t *client, dns_rpz_st_t *st,
region.length = pname_buf.size;
dns_name_fromregion(st->p_name, &region);
rpz_ready(client, p_rdatasetp);
result = rpz_ready(client, p_rdatasetp);
if (result != ISC_R_SUCCESS) {
return (false);
}
dns_db_attach(st->rpsdb, &p_db);
policy = dns_dnsrps_2policy(rpsdb->result.policy);
if (policy != DNS_RPZ_POLICY_RECORD) {