ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Merge branch 'fanf-rndc-nta-newlines' into 'main'

Browse Source 
Fix missing newlines in output of `rndc nta -dump`

See merge request isc-projects/bind9!8454
This commit is contained in:
Evan Hunt
2023-11-02 16:31:25 +00:00
parent 01b1ae7bef 37b101b6e2
commit 7d650fde89
3 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGES
View File

@@ -1,3 +1,6 @@
6280. [bug] Fix missing newlines in the output of "rndc nta -dump".
[GL !8454]
6279. [func] Use QNAME minimization when fetching nameserver
addresses. [GL #4209]

8
bin/named/server.c
View File

@@ -15253,6 +15253,8 @@ named_server_nta(named_server_t *server, isc_lex_t *lex, bool readonly,
* If -dump was specified, list NTA's and return
*/
if (dump) {
size_t last = 0;
for (view = ISC_LIST_HEAD(server->viewlist); view != NULL;
view = ISC_LIST_NEXT(view, link))
{
@@ -15264,6 +15266,12 @@ named_server_nta(named_server_t *server, isc_lex_t *lex, bool readonly,
continue;
}
if (last != isc_buffer_usedlength(*text)) {
CHECK(putstr(text, "\n"));
}
last = isc_buffer_usedlength(*text);
CHECK(dns_ntatable_totext(ntatable, view->name, text));
}
CHECK(putnull(text));

9
bin/tests/system/rndc/tests.sh
View File

@@ -817,5 +817,14 @@ grep 'include 2' dig.out.2.test$n >/dev/null || ret=1
if [ $ret != 0 ]; then echo_i "failed"; fi
status=$((status + ret))
n=$((n + 1))
echo_i "check rndc nta -dump reports NTAs in multiple views ($n)"
ret=0
$RNDCCMD 10.53.0.3 nta -dump >rndc.out.test$n 2>&1 || ret=1
lines=$(cat rndc.out.test$n | wc -l)
[ ${lines:-0} -eq 2 ] || ret=1
if [ $ret != 0 ]; then echo_i "failed"; fi
status=$((status + ret))
echo_i "exit status: $status"
[ $status -eq 0 ] || exit 1