acquire task lock before calling push_readyq for task->flags access

This commit is contained in:
Mark Andrews
2019-12-12 22:54:15 +00:00
parent fba81c5d28
commit 7c94d2cd7d
+4
View File
@@ -473,7 +473,9 @@ task_ready(isc__task_t *task) {
XTRACE("task_ready");
LOCK(&manager->lock);
LOCK(&task->lock);
push_readyq(manager, task);
UNLOCK(&task->lock);
#ifdef USE_WORKER_THREADS
if (manager->mode == isc_taskmgrmode_normal || has_privilege)
SIGNAL(&manager->work_available);
@@ -1263,7 +1265,9 @@ dispatch(isc__taskmgr_t *manager) {
* might even hurt rather than help.
*/
#ifdef USE_WORKER_THREADS
LOCK(&task->lock);
push_readyq(manager, task);
UNLOCK(&task->lock);
#else
ENQUEUE(new_ready_tasks, task, ready_link);
if ((task->flags & TASK_F_PRIVILEGED) != 0)