ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

RFC1123 says ignore the RD bit in multicast requests, not

Browse Source 
FORMERR multicast requests with RD set
This commit is contained in:
Andreas Gustafsson
2001-10-13 01:10:26 +00:00
parent 0bd2ea544e
commit 79432444e8
2 changed files with 9 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGES
View File

@@ -60,8 +60,8 @@
currently do not), respond from a unicast address
as specified in RFC 1123. [RT #137]
1034. [bug] Multicast queries must not have RD set, RFC 1123.
FORMERR those that do. [RT #137]
1034. [bug] Ignore the RD bit on multicast queries as specified
in RFC 1123. [RT #137]
1033. [bug] Always respond to requests with an unsupported opcode
with NOTIMP, even if we don't have a matching view

19
bin/named/client.c
View File

@@ -15,7 +15,7 @@
* WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
/* $Id: client.c,v 1.188 2001/10/13 00:44:24 gson Exp $ */
/* $Id: client.c,v 1.189 2001/10/13 01:10:26 gson Exp $ */
#include <config.h>
@@ -1226,6 +1226,10 @@ client_request(isc_task_t *task, isc_event_t *event) {
client->message->rcode = dns_rcode_noerror;
/* RFC1123 section 6.1.3.2 */
if ((client->attributes & NS_CLIENTATTR_MULTICAST) != 0)
client->message->flags &= ~DNS_MESSAGEFLAG_RD;
/*
* Deal with EDNS.
*/
@@ -1296,8 +1300,8 @@ client_request(isc_task_t *task, isc_event_t *event) {
&client->interface->addr);
if (allowed(&netaddr, view->matchclients) &&
allowed(&destaddr, view->matchdestinations) &&
!((flags & DNS_MESSAGEFLAG_RD) == 0 &&
view->matchrecursiveonly))
!((client->message->flags & DNS_MESSAGEFLAG_RD)
== 0 && view->matchrecursiveonly))
{
dns_view_attach(view, &client->view);
break;
@@ -1375,15 +1379,6 @@ client_request(isc_task_t *task, isc_event_t *event) {
}
}
if ((client->attributes & NS_CLIENTATTR_MULTICAST) != 0) {
ns_client_log(client, NS_LOGCATEGORY_CLIENT,
NS_LOGMODULE_CLIENT, ISC_LOG_DEBUG(2),
"multicast request");
if ((flags & DNS_MESSAGEFLAG_RD) != 0)
ns_client_error(client, notimp ? DNS_R_NOTIMP :
DNS_R_FORMERR);
}
/*
* Decide whether recursive service is available to this client.
* We do this here rather than in the query code so that we can