ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Fix keyfromlabel test, missing status update

Browse Source 
Fix a missing status=$((status+ret)) in the keyfromlabel system test,
which would ignore the error if ZSK key creation failed.
This commit is contained in:
Matthijs Mekking
2022-02-04 11:55:46 +01:00
parent a449709441
commit 7845f51178
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
bin/tests/system/keyfromlabel/tests.sh
View File

@@ -65,13 +65,14 @@ do
ret=0
zsk=$(keyfromlabel $alg $zone keyfromlabel-zsk)
test -z "$zsk" && ret=1
test "$ret" -eq 0 || echo_i "failed (zsk=$zsk)"
status=$((status+ret))
echo_i "Get KSK $alg $zone $type:$bits"
ret=0
ksk=$(keyfromlabel $alg $zone keyfromlabel-ksk -f KSK)
test -z "$ksk" && ret=1
test "$ret" -eq 0 || echo_i "failed (zsk=$zsk ksk=$ksk)"
test "$ret" -eq 0 || echo_i "failed (ksk=$ksk)"
status=$((status+ret))
# Skip signing if dnssec-keyfromlabel failed.