ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Silence unchecked return of dns_db_find()

Browse Source 
190        dns_rdataset_init(&rdataset);
   	3. Condition r == 0, taking true branch.
   	4. Condition result, taking false branch.

	CID 1452691 (#1 of 1): Unchecked return value (CHECKED_RETURN)
	5. check_return: Calling dns_db_find without checking return
	value (as is done elsewhere 39 out of 45 times).

191        check_assertion(dns_db_find(db1, dns_rootname, v2,
192                                    dns_rdatatype_soa, 0, 0, NULL,
193                                    name, &rdataset, NULL));

(cherry picked from commit e8bf82efc6)
This commit is contained in:
Mark Andrews
2020-02-06 11:02:55 +11:00
parent a6f09283cd
commit 76df419b27
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/dns/tests/dbversion_test.c
View File

@@ -188,9 +188,9 @@ find(void **state) {
}
dns_rdataset_init(&rdataset);
check_assertion(dns_db_find(db1, dns_rootname, v2,
dns_rdatatype_soa, 0, 0, NULL,
name, &rdataset, NULL));
check_assertion((void)dns_db_find(db1, dns_rootname, v2,
dns_rdatatype_soa, 0, 0, NULL,
name, &rdataset, NULL));
}
/*