ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Drop superfluous isc_mem_get() NULL check

Browse Source 
coccinelle v1.1 trips over a superfluous isc_mem_get() NULL check in
tests/libtest/ns.c and reports the following failure in CI:

    EXN: Failure("rule starting on line 26: already tagged token:\nC code context\nFile \"./tests/libtest/ns.c\", line 350, column 1, charpos = 7939\n  around = 'if',\n  whole content = \tif (qctx != NULL) {") in ./tests/libtest/ns.c

(cherry picked from commit cf76851c75)
This commit is contained in:
Michal Nowak
2024-12-13 13:50:06 +00:00
parent 7324e1f70b
commit 75931127ac
1 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/libtest/ns.c
+1 -7
View File
@@ -357,15 +357,9 @@ extract_qctx(void *arg, void *data, isc_result_t *resultp) {
* gets unwound.
*/
qctx = isc_mem_get(mctx, sizeof(*qctx));
if (qctx != NULL) {
memmove(qctx, (query_ctx_t *)arg, sizeof(*qctx));
}
memmove(qctx, (query_ctx_t *)arg, sizeof(*qctx));
qctxp = (query_ctx_t **)data;
/*
* If memory allocation failed, the supplied pointer will simply be set
* to NULL. We rely on the user of this hook to react properly.
*/
*qctxp = qctx;
*resultp = ISC_R_UNSET;