Disable loadtime check in statschannel test

It is better to disable the specific check that causes the test to fail
rather than mark the entire test as xfail, which can mask other issues
which the test is capable of detecting.

bin/tests/system/statschannel/generic.py

@@ -34,10 +34,12 @@ def check_refresh(refresh, min_time, max_time):
     assert refresh <= max_time
 
 
-def check_loaded(loaded, expected):
+def check_loaded(loaded, expected):  # pylint: disable=unused-argument
     # Sanity check the zone timers values
-    assert loaded == expected
-    assert loaded < now
+    # NOTE This check has been disabled due to GL #3983
+    # assert loaded == expected
+    # assert loaded < now
+    pass
 
 
 def check_zone_timers(loaded, expires, refresh, loaded_exp):

bin/tests/system/statschannel/tests_json.py

@@ -12,7 +12,6 @@
 # information regarding copyright ownership.
 
 from datetime import datetime
-import os
 
 import pytest
 
@@ -83,7 +82,6 @@ def test_zone_timers_primary_json(statsport):
     )
 
 
-@pytest.mark.xfail(reason="GL #3983", strict="LEGACY_TEST_RUNNER" not in os.environ)
 def test_zone_timers_secondary_json(statsport):
     generic.test_zone_timers_secondary(
         fetch_zones_json,

bin/tests/system/statschannel/tests_xml.py

@@ -12,7 +12,6 @@
 # information regarding copyright ownership.
 
 from datetime import datetime
-import os
 import xml.etree.ElementTree as ET
 
 import pytest
@@ -113,7 +112,6 @@ def test_zone_timers_primary_xml(statsport):
     )
 
 
-@pytest.mark.xfail(reason="GL #3983", strict="LEGACY_TEST_RUNNER" not in os.environ)
 def test_zone_timers_secondary_xml(statsport):
     generic.test_zone_timers_secondary(
         fetch_zones_xml,