Enforce a run time limit on unit test binaries

When a unit test binary hangs, the GitLab CI job in which it is run is
stuck until its run time limit is exceeded.  Furthermore, it is not
trivial to determine which test(s) hung in a given GitLab CI job based
on its log.  To prevent these issues, enforce a run time limit on every
binary executed by the lib/unit-test-driver.sh script.  Use a timeout of
5 minutes for consistency with older BIND 9 branches, which employed
Kyua for running unit tests.  Report an exit code of 124 when the run
time limit is exceeded for a unit test binary, for consistency with the
"timeout" tool included in GNU coreutils.
This commit is contained in:
Michał Kępień
2021-04-07 11:41:45 +02:00
parent d1bb1b01b9
commit 6bdd55a9b3

View File

@@ -9,9 +9,24 @@ if [ -z "${1}" ]; then
fi
TEST_PROGRAM="${1}"
TIMEOUT=300
"${TEST_PROGRAM}"
STATUS=${?}
"${TEST_PROGRAM}" &
TEST_PROGRAM_PID=${!}
STATUS=124
while [ ${TIMEOUT} -gt 0 ]; do
if ! kill -0 "${TEST_PROGRAM_PID}" 2>/dev/null; then
wait "${TEST_PROGRAM_PID}"
STATUS=${?}
break
fi
sleep 1
TIMEOUT=$((TIMEOUT - 1))
done
if [ ${TIMEOUT} -eq 0 ]; then
echo "PID ${TEST_PROGRAM_PID} exceeded run time limit, sending SIGKILL" >&2
kill -KILL "${TEST_PROGRAM_PID}" 2>/dev/null
fi
TEST_PROGRAM_NAME=$(basename "${TEST_PROGRAM}")
TEST_PROGRAM_WORK_DIR=$(dirname "${TEST_PROGRAM}")