ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

[master] nsupdate: send tkey queries to the right server

Browse Source 
4588.	[bug]		nsupdate could send queries for TKEY to the wrong
			server when using GSSAPI. Thanks to Tomas Hozza.
			[RT #39893]
This commit is contained in:
Evan Hunt
2017-04-20 09:28:37 -07:00
parent 706c6ac5e2
commit 66b71679b7
2 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGES
View File

@@ -1,3 +1,7 @@
4588. [bug] nsupdate could send queries for TKEY to the wrong
server when using GSSAPI. Thanks to Tomas Hozza.
[RT #39893]
4587. [bug] named-checkzone failed to handle occulted data below
DNAMEs correctly. [RT #44877]

10
bin/nsupdate/nsupdate.c
View File

@@ -2799,10 +2799,8 @@ start_gssrequest(dns_name_t *master) {
if (kserver == NULL)
fatal("out of memory");
}
if (servers == NULL)
get_addresses(namestr, dnsport, kserver, 1);
else
memmove(kserver, &servers[ns_inuse], sizeof(isc_sockaddr_t));
memmove(kserver, &master_servers[master_inuse], sizeof(isc_sockaddr_t));
dns_fixedname_init(&fname);
servname = dns_fixedname_name(&fname);
@@ -2947,11 +2945,11 @@ recvgss(isc_task_t *task, isc_event_t *event) {
}
if (eresult != ISC_R_SUCCESS) {
next_server("recvgss", addr, eresult);
next_master("recvgss", addr, eresult);
ddebug("Destroying request [%p]", request);
dns_request_destroy(&request);
dns_message_renderreset(tsigquery);
sendrequest(&servers[ns_inuse], tsigquery, &request);
sendrequest(&master_servers[master_inuse], tsigquery, &request);
isc_mem_put(gmctx, reqinfo, sizeof(nsu_gssinfo_t));
isc_event_free(&event);
return;