ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

3350. [bug] Memory read overrun in isc___mem_reallocate if

Browse Source 
ISC_MEM_DEBUGCTX memory debugging flag is set.
                        [RT #30240]
This commit is contained in:
Mark Andrews
2012-07-18 09:54:25 +10:00
parent d92f5ce987
commit 6439173dae
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGES
View File

@@ -1,3 +1,7 @@
3350. [bug] Memory read overrun in isc___mem_reallocate if
ISC_MEM_DEBUGCTX memory debugging flag is set.
[RT #30240]
3348. [security] prevent RRSIG data from being cached if a negative
record matching the covering type exists at a higher
trust level. Such data already can't be retrieved from

6
lib/isc/mem.c
View File

@@ -1405,7 +1405,11 @@ isc__mem_reallocate(isc_mem_t *ctx, void *ptr, size_t size FLARG) {
oldsize = (((size_info *)ptr)[-1]).u.size;
INSIST(oldsize >= ALIGNMENT_SIZE);
oldsize -= ALIGNMENT_SIZE;
copysize = oldsize > size ? size : oldsize;
if ((isc_mem_debugging & ISC_MEM_DEBUGCTX) != 0) {
INSIST(oldsize >= ALIGNMENT_SIZE);
oldsize -= ALIGNMENT_SIZE;
}
copysize = (oldsize > size) ? size : oldsize;
memcpy(new_ptr, ptr, copysize);
isc__mem_free(ctx, ptr FLARG_PASS);
}