unlink before unlock

(cherry picked from commit 4742f4ecba)
This commit is contained in:
Mark Andrews
2018-08-24 10:58:30 +10:00
parent 1bbed57e94
commit 58e33fcdb4
+1 -1
View File
@@ -513,6 +513,7 @@ free_session_list(pk11_sessionlist_t *slist) {
LOCK(&sessionlock);
while (!ISC_LIST_EMPTY(*slist)) {
sp = ISC_LIST_HEAD(*slist);
ISC_LIST_UNLINK(*slist, sp, link);
UNLOCK(&sessionlock);
if (sp->session != CK_INVALID_HANDLE) {
rv = pkcs_C_CloseSession(sp->session);
@@ -520,7 +521,6 @@ free_session_list(pk11_sessionlist_t *slist) {
ret = DST_R_CRYPTOFAILURE;
}
LOCK(&sessionlock);
ISC_LIST_UNLINK(*slist, sp, link);
pk11_mem_put(sp, sizeof(*sp));
}
UNLOCK(&sessionlock);